Create a blocking task group. [chromium/src : main]

0 views
Skip to first unread message

Olivier Li Shing Tat-Dupuis (Gerrit)

unread,
May 4, 2026, 2:48:36 PM (7 days ago) May 4
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray

Olivier Li Shing Tat-Dupuis added 1 comment

File base/task/task_features.cc
Line 34, Patchset 13 (Latest): 4);
Olivier Li Shing Tat-Dupuis . unresolved

Being able to tweak this number and attempt to chose an optimal value probably requires a metric that logs how long blocking takes in relation to how many blocked threads already exist.

If the speed is constant at all number of threads, then it would indicate that we haven't gone high enough.

Conversely if the blocking is strictly worse at the higher worker count then it probably need to be lowered.

I thought that it would probably be a lot to add this to the first CL and plan on doing it as a follow-up.

What do you think?

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I203c95e9db6ef9930009f969e7dbffb11cdcebda
Gerrit-Change-Number: 7775968
Gerrit-PatchSet: 13
Gerrit-Owner: Olivier Li Shing Tat-Dupuis <oliv...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Olivier Li Shing Tat-Dupuis <oliv...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Mon, 04 May 2026 18:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages