Reland "[task] Integrate SequenceManager "best effort" into ThreadType mapping" [chromium/src : main]
0 views
Skip to first unread message
Mei Liang (Gerrit)
Apr 27, 2026, 6:41:46 PM (14 days ago) Apr 27
to Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Joe Mason
Mei Liang voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Apr 27, 2026, 6:42:20 PM (14 days ago) Apr 27
to Mei Liang, Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Joe Mason
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mei Liang (Gerrit)
Apr 27, 2026, 6:44:04 PM (14 days ago) Apr 27
to rubber-...@appspot.gserviceaccount.com, Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray, Gabriel Charette and Joe Mason
Mei Liang voted![]( "Open in Gerrit")
| Auto-Submit | +0 |
| Commit-Queue | +0 |
| Owners-Override | +0 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mei Liang (Gerrit)
Apr 27, 2026, 6:44:23 PM (14 days ago) Apr 27
to rubber-...@appspot.gserviceaccount.com, Gabriel Charette, Chromium LUCI CQ, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Mei Liang abandoned this change.
Abandoned
I think this is the correct revert
Mei Liang abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 28, 2026, 5:15:34 PM (13 days ago) Apr 28
to Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Gabriel Charette and Joe Mason
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Gabriel Charette
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
Apr 28, 2026, 5:16:32 PM (13 days ago) Apr 28
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Etienne Pierre-Doray and Joe Mason
Gabriel Charette voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 28, 2026, 5:58:33 PM (13 days ago) Apr 28
to Gabriel Charette, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Attention needed from Joe Mason
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 28, 2026, 11:08:20 PM (13 days ago) Apr 28
to Etienne Pierre-Doray, Gabriel Charette, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, scheduler...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[task] Integrate SequenceManager "best effort" into ThreadType mapping"
This is a reland of commit 0c91a42a7765ab67ed253908362e3e25087ab46a
Reason for revert: Tree is broken, https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8683330511251170193
Fix: https://chromium-review.git.corp.google.com/c/chromium/src/+/7783493 introduced
a call to GetCurrentBestEffort(), but that was reverted as well.
Now relanding without GetCurrentBestEffort() as
https://chromium-review.git.corp.google.com/c/chromium/src/+/7801737
Original change's description:
> [task] Integrate SequenceManager "best effort" into ThreadType mapping
>
> This CL integrates concept of SequenceManager best effort task runner
> into ThreadType mapping, allowing for multiple TaskPriority to be considered "best effort".
> This also removes unused GetCurrentBestEffort(), since it would otherwise need to be updated.
>
> Bug: 495439030
> Change-Id: I3c71c4b81ea05a767868d0f07076e0760fe4dec6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7736792
> Reviewed-by: Gabriel Charette <g...@chromium.org>
> Reviewed-by: Joe Mason <joenot...@google.com>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1621347}
Bug: 495439030
Change-Id: If10815ebb9238429575800c39df2dc5e0d19a9ef
Reviewed-by: Gabriel Charette <g...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1622201}
Files:
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/task/sequence_manager/sequence_manager_impl.h
- M base/task/sequence_manager/sequence_manager_impl_unittest.cc
- M base/task/sequenced_task_runner.cc
- M base/task/sequenced_task_runner.h
- M base/task/sequenced_task_runner_unittest.cc
- M base/task/single_thread_task_runner.cc
- M base/task/single_thread_task_runner.h
- M base/task/single_thread_task_runner_unittest.cc
- M base/test/task_environment.cc
- M base/test/task_environment.h
Change size: L
Delta: 11 files changed, 42 insertions(+), 571 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gabriel Charette
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages