Nan Lin (Gerrit)

unread,

Apr 23, 2026, 1:47:52 PMApr 23

to Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner and Shivani Sharma

Nan Lin added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Nan Lin . resolved

@ale...@chromium.org @shiva...@chromium.org Could you PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Shivani Sharma

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shivani Sharma (Gerrit)

unread,

Apr 27, 2026, 5:32:26 PM (14 days ago) Apr 27

to Nan Lin, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner and Nan Lin

Shivani Sharma voted and added 4 comments

Votes added by Shivani Sharma

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 19 (Latest):

Shivani Sharma . resolved

lgtm % nits, thanks!

File chrome/renderer/actor/page_stability_monitor_delegate.cc

Line 28, Patchset 19 (Latest):void PageStabilityMonitorDelegate::WillMoveToState(

Shivani Sharma . unresolved

are there existing tests for journal entries that need to be updated as well?

File components/page_content_annotations/content/renderer/network_and_main_thread_stability_monitor.h

Line 54, Patchset 19 (Latest): raw_ptr<PageStabilityMonitorDelegate> delegate_ = nullptr;

Shivani Sharma . unresolved

Can we add a comment on why only one delgate is sufficient?

File components/page_content_annotations/content/renderer/paint_stability_monitor.cc

Line 135, Patchset 19 (Latest):// TODO(crbug.com/434268231): This is not based on data and should be revisited

Shivani Sharma . unresolved

here and below should be b/434268231. Also, should a new bug be created to track data-based values since the existing one is marked fixed?

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Nan Lin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nan Lin (Gerrit)

unread,

Apr 27, 2026, 6:49:43 PM (14 days ago) Apr 27

to Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner

Nan Lin added 3 comments

File chrome/renderer/actor/page_stability_monitor_delegate.cc

Line 28, Patchset 19:void PageStabilityMonitorDelegate::WillMoveToState(

Shivani Sharma . resolved

are there existing tests for journal entries that need to be updated as well?

Nan Lin

I don't think there are existing tests that we need to update. All the existing tests pass.

File components/page_content_annotations/content/renderer/network_and_main_thread_stability_monitor.h

Line 54, Patchset 19: raw_ptr<PageStabilityMonitorDelegate> delegate_ = nullptr;

Shivani Sharma . resolved

Can we add a comment on why only one delgate is sufficient?

Nan Lin

Added comment, thanks!

File components/page_content_annotations/content/renderer/paint_stability_monitor.cc

Line 135, Patchset 19:// TODO(crbug.com/434268231): This is not based on data and should be revisited

Shivani Sharma . resolved

here and below should be b/434268231. Also, should a new bug be created to track data-based values since the existing one is marked fixed?

Nan Lin

Created b/507143691. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nan Lin (Gerrit)

unread,

Apr 27, 2026, 6:50:21 PM (14 days ago) Apr 27

to Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner and Min Qin

Nan Lin added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Nan Lin . resolved

@qin...@chromium.org Could you PTAL? Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Min Qin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Apr 27, 2026, 6:55:58 PM (14 days ago) Apr 27

to Nan Lin, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Giovanni Ortuno Urquidi and Min Qin

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ort...@chromium.org

Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Giovanni Ortuno Urquidi
Min Qin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,

Apr 28, 2026, 10:46:57 AM (13 days ago) Apr 28

to Nan Lin, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Min Qin and Nan Lin

Giovanni Ortuno Urquidi voted and added 1 comment

Votes added by Giovanni Ortuno Urquidi

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Giovanni Ortuno Urquidi . resolved

mojo lgtm

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Min Qin
Nan Lin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nan Lin (Gerrit)

unread,

Apr 28, 2026, 1:49:40 PM (13 days ago) Apr 28

to Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Avi Drissman and Min Qin

Nan Lin added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Nan Lin . resolved

@a...@chromium.org Could you PTAL at //chrome/renderer, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Avi Drissman
Min Qin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nan Lin (Gerrit)

unread,

Apr 28, 2026, 1:50:52 PM (13 days ago) Apr 28

to Etienne Pierre-Doray, Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Avi Drissman, Etienne Pierre-Doray and Min Qin

Nan Lin added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Nan Lin . resolved

@etie...@chromium.org Could you PTAL at base/task, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Avi Drissman
Etienne Pierre-Doray
Min Qin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Apr 28, 2026, 1:51:12 PM (13 days ago) Apr 28

to Nan Lin, Avi Drissman, Etienne Pierre-Doray, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Etienne Pierre-Doray, Min Qin and Nan Lin

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Etienne Pierre-Doray
Min Qin
Nan Lin

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Apr 28, 2026, 3:10:00 PM (13 days ago) Apr 28

to Nan Lin, Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Min Qin, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner, Min Qin and Nan Lin

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 21 (Latest):

Etienne Pierre-Doray . resolved

base/task LGTM

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Min Qin
Nan Lin

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Apr 28, 2026, 11:42:25 PM (13 days ago) Apr 28

to Nan Lin, Etienne Pierre-Doray, Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner and Nan Lin

Min Qin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner
Nan Lin

satisfied_requirement

open

diffy

Nan Lin (Gerrit)

unread,

Apr 29, 2026, 8:58:17 AM (12 days ago) Apr 29

to Min Qin, Etienne Pierre-Doray, Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Shivani Sharma, Alex Turner, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Attention needed from Alex Turner

Nan Lin voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Alex Turner

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 29, 2026, 9:02:04 AM (12 days ago) Apr 29

to Nan Lin, Min Qin, Etienne Pierre-Doray, Avi Drissman, Giovanni Ortuno Urquidi, Chromium IPC Reviews, Shivani Sharma, Alex Turner, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, droger+w...@chromium.org, ipc-securi...@chromium.org, mfoltz+wa...@chromium.org, scheduler...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Componentize PageStabilityMonitor

This CL relocates and refactors the PageStabilityMonitor and its
associated monitoring logic (paint and network/main thread stability)
from //chrome/renderer/actor/ to
//components/page_content_annotations/content/renderer/.

The goal is to move this functionality into a shared component layer,
allowing it to be used by features beyond the actor system. To achieve
this, the monitor has been decoupled from actor-specific concepts like
Journal and TaskId. Actor-specific behavior is maintained by
implementing a delegate that preserves the legacy Journal logging and
metrics collection within the new architecture.

New feature flags and parameters are introduced in the shared component
layer to allow independent configuration and tuning for different
features using the monitor, while the existing actor-specific parameters
are preserved via the delegate to maintain legacy behavior.

Bug: 422120832

Change-Id: I334cf1fe44a0881c6f0a25ba52cddb6222e1cff2

Bypass-Check-License: Refactor

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7780750

Reviewed-by: Shivani Sharma <shiva...@chromium.org>

Commit-Queue: Nan Lin <lin...@chromium.org>

Reviewed-by: Avi Drissman <a...@chromium.org>

Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>

Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>

Reviewed-by: Min Qin <qin...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1622387}

Files:

M base/task/sequenced_task_runner.h
M chrome/renderer/BUILD.gn
M chrome/renderer/DEPS
M chrome/renderer/actor/BUILD.gn
D chrome/renderer/actor/network_and_main_thread_stability_monitor.h
M chrome/renderer/actor/page_stability_metrics.cc
M chrome/renderer/actor/page_stability_metrics.h
D chrome/renderer/actor/page_stability_monitor.h
A chrome/renderer/actor/page_stability_monitor_delegate.cc
A chrome/renderer/actor/page_stability_monitor_delegate.h
D chrome/renderer/actor/paint_stability_monitor.cc
M chrome/renderer/chrome_render_frame_observer.cc
M chrome/renderer/chrome_render_frame_observer.h
M components/BUILD.gn
M components/page_content_annotations/content/mojom/page_stability.mojom
A components/page_content_annotations/content/renderer/BUILD.gn
A components/page_content_annotations/content/renderer/DEPS
R components/page_content_annotations/content/renderer/network_and_main_thread_stability_monitor.cc
A components/page_content_annotations/content/renderer/network_and_main_thread_stability_monitor.h
A components/page_content_annotations/content/renderer/page_stability_event.h
R components/page_content_annotations/content/renderer/page_stability_monitor.cc
A components/page_content_annotations/content/renderer/page_stability_monitor.h
A components/page_content_annotations/content/renderer/page_stability_monitor_delegate.cc
A components/page_content_annotations/content/renderer/page_stability_monitor_delegate.h
A components/page_content_annotations/content/renderer/page_stability_state.cc
A components/page_content_annotations/content/renderer/page_stability_state.h
A components/page_content_annotations/content/renderer/paint_stability_monitor.cc
R components/page_content_annotations/content/renderer/paint_stability_monitor.h
R components/page_content_annotations/content/renderer/paint_stability_monitor_browsertest.cc
M components/page_content_annotations/core/page_content_annotations_features.cc
M components/page_content_annotations/core/page_content_annotations_features.h

Change size: XL

Delta: 31 files changed, 1082 insertions(+), 637 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Etienne Pierre-Doray, +1 by Shivani Sharma, +1 by Avi Drissman, +1 by Min Qin, +1 by Giovanni Ortuno Urquidi

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Componentize PageStabilityMonitor [chromium/src : main]

Nan Lin (Gerrit)

Nan Lin added 1 comment

Related details

Shivani Sharma (Gerrit)

Shivani Sharma voted and added 4 comments

Votes added by Shivani Sharma

4 comments

Related details

Nan Lin (Gerrit)

Nan Lin added 3 comments

Related details

Nan Lin (Gerrit)

Nan Lin added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Giovanni Ortuno Urquidi (Gerrit)

Giovanni Ortuno Urquidi voted and added 1 comment

Votes added by Giovanni Ortuno Urquidi

1 comment

Related details

Nan Lin (Gerrit)

Nan Lin added 1 comment

Related details

Nan Lin (Gerrit)

Nan Lin added 1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

1 comment

Related details

Min Qin (Gerrit)

Min Qin voted Code-Review+1

Related details

Nan Lin (Gerrit)

Nan Lin voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information