[task] Avoid using ThreadControllerImpl in RenderViewTest [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Mar 30, 2026, 5:58:39 PM (3 days ago) Mar 30
to Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Attention needed from Dave Tapuska
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/renderer/autofill/password_generation_agent_browsertest.cc
Line 142, Patchset 17 (Parent):
std::make_unique<base::RunLoop>();Etienne Pierre-Doray . resolved
Since ChromeRenderViewTest now initializes the default task runner in SetUp() rather than constructor, this needs to happen in SetUp() as well.
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Mar 30, 2026, 7:05:51 PM (3 days ago) Mar 30
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Attention needed from Etienne Pierre-Doray
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Mar 31, 2026, 7:16:14 AM (2 days ago) Mar 31
to Dominic Battre, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Attention needed from Dominic Battre
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dominic Battre
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battre (Gerrit)
Mar 31, 2026, 7:26:51 AM (2 days ago) Mar 31
to Etienne Pierre-Doray, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Attention needed from Etienne Pierre-Doray
Dominic Battre voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominic Battre
| Code-Review | +1 |
2 comments
Patchset-level comments
Dominic Battre . resolved
chrome/renderer/autofill/password_generation_agent_browsertest.cc RSLGTM
File content/public/test/render_view_test.h
Line 207, Patchset 17 (Latest):
class CustomTaskEnvironment : public base::test::TaskEnvironment {Dominic Battre . unresolved
Drive-by: Do you want to document why this needs a custom task environment?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Mar 31, 2026, 8:32:42 AM (2 days ago) Mar 31
to Dominic Battre, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Etienne Pierre-Doray voted and added 2 comments![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File content/public/test/render_view_test.h
Line 207, Patchset 17:
class CustomTaskEnvironment : public base::test::TaskEnvironment {Dominic Battre . resolved
Drive-by: Do you want to document why this needs a custom task environment?
Etienne Pierre-Doray
Good idea, done.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Mar 31, 2026, 6:09:43 PM (2 days ago) Mar 31
to Dominic Battre, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 31, 2026, 8:11:32 PM (2 days ago) Mar 31
to Etienne Pierre-Doray, Dominic Battre, Dave Tapuska, chromium...@chromium.org, AyeAye, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, browser-comp...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org, blink-re...@chromium.org, chikamu...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
17 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: content/public/test/render_view_test.h
Insertions: 3, Deletions: 0.
@@ -204,6 +204,9 @@
// Install a fake URL loader factory for the RenderFrameImpl.
void CreateFakeURLLoaderFactory();
+ // A derived TaskEnvironment is needed to create WebThreadScheduler and give
+ // it access to the sequence_manager that's owned by the TaskEnvironment base
+ // class.
class CustomTaskEnvironment : public base::test::TaskEnvironment {
public:
CustomTaskEnvironment();
```
Change information
Commit message:
[task] Avoid using ThreadControllerImpl in RenderViewTest
This CL converts RenderViewTest to use a custom TaskEnvironment that
creates WebThreadScheduler directly with sequence_manager, instead
of running on top of (deprecated) ThreadControllerImpl.
This requires exposing CreatePrioritySettingsForTesting from blink.
Bug: 40881604
Change-Id: I7808a80fc5bf665dc160e0d04faaa3cc4a616f26
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Dominic Battre <bat...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608193}
Files:
- M chrome/renderer/autofill/password_generation_agent_browsertest.cc
- M content/public/test/render_view_test.cc
- M content/public/test/render_view_test.h
- M third_party/blink/public/platform/scheduler/DEPS
- M third_party/blink/public/platform/scheduler/web_thread_scheduler.h
- M third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 7 files changed, 73 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Battre, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages