[cleanup] Scheduler should no longer reference retro frames [chromium/src : main]
0 views
Skip to first unread message
Stacy Gaikovaia (Gerrit)
May 8, 2026, 11:42:38 AM (3 days ago) May 8
to Tzarial, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Tzarial
Stacy Gaikovaia has uploaded the change for review![]( "Open in Gerrit")
Stacy Gaikovaia would like Tzarial to review this change.
Commit message
[cleanup] Scheduler should no longer reference retro frames
Retro frames no longer exist, update old comment.
R=zo...@chromium.org
Bug: 498204524
Change-Id: I6dc73f03edccdffff7c7646327af5e78edcf092a
Change diff
diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc
index 005deca..d4a012a6 100644
--- a/cc/scheduler/scheduler.cc
+++ b/cc/scheduler/scheduler.cc
@@ -383,8 +383,8 @@
// BeginFrame is the mechanism that tells us that now is a good time to start
// making a frame. Usually this means that user input for the frame is complete.
-// If the scheduler is busy, we queue the BeginFrame to be handled later as
-// a BeginRetroFrame.
+// If the scheduler is busy, we queue the BeginFrame to be handled later as a
+// pending BeginMainFrame.
bool Scheduler::OnBeginFrameDerivedImpl(const viz::BeginFrameArgs& args) {
TRACE_EVENT1("cc,benchmark", "Scheduler::BeginFrame", "args", args.AsValue());
Change information
Files:
- M cc/scheduler/scheduler.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention is currently required from:
- Tzarial
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tzarial (Gerrit)
May 8, 2026, 1:48:15 PM (3 days ago) May 8
to Stacy Gaikovaia, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Attention needed from Stacy Gaikovaia
Tzarial voted![]( "Open in Gerrit")
Attention is currently required from:
- Stacy Gaikovaia
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 8, 2026, 1:54:29 PM (3 days ago) May 8
to Stacy Gaikovaia, Tzarial, chromium...@chromium.org, cc-...@chromium.org, schedule...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cleanup] Scheduler should no longer reference retro frames
Retro frames no longer exist, update old comment.
R=zo...@chromium.org
Bug: 498204524
Change-Id: I6dc73f03edccdffff7c7646327af5e78edcf092a
Auto-Submit: Stacy Gaikovaia <ga...@google.com>
Reviewed-by: Tzarial <zo...@chromium.org>
Commit-Queue: Tzarial <zo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1627766}
Files:
- M cc/scheduler/scheduler.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tzarial
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages