Remove non-adaptor uses of base::IgnoreResult [chromium/src : main]
0 views
Skip to first unread message
gwsq (Gerrit)
Feb 12, 2026, 8:27:10 AM (10 days ago) Feb 12
to Andrew Paseltiner, Chromium UI Views Reviews, Dana Fried, Abhijith Nair, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Abhijith Nair, Dana Fried and Nico Weber
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
dfr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)
Related details
Attention is currently required from:
- Abhijith Nair
- Dana Fried
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Feb 12, 2026, 11:06:04 AM (10 days ago) Feb 12
to Andrew Paseltiner, Chromium UI Views Reviews, Abhijith Nair, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Abhijith Nair, Andrew Paseltiner and Nico Weber
Dana Fried added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Dana Fried . unresolved
While I am concerned about the discarding of non-discardable results in production code, I am comfortable with these changes in that they won't change any actual behavior. However, perhaps we should revisit places where `std::ignore` is now used.
Related details
Attention is currently required from:
- Abhijith Nair
- Andrew Paseltiner
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Feb 12, 2026, 11:06:09 AM (10 days ago) Feb 12
to Andrew Paseltiner, Chromium UI Views Reviews, Abhijith Nair, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Abhijith Nair, Andrew Paseltiner and Nico Weber
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Abhijith Nair
- Andrew Paseltiner
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Feb 12, 2026, 11:24:39 AM (10 days ago) Feb 12
to Dana Fried, Chromium UI Views Reviews, Abhijith Nair, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Abhijith Nair and Nico Weber
Andrew Paseltiner added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dana Fried . resolved
While I am concerned about the discarding of non-discardable results in production code, I am comfortable with these changes in that they won't change any actual behavior. However, perhaps we should revisit places where `std::ignore` is now used.
Andrew Paseltiner
There are hundreds of preexisting uses of `std::ignore`, and there would be even more of them if more APIs took advantage of `[[nodiscard]]`. It might be worth auditing them, and perhaps even requiring some kind of comment or annotation about *why* the value is being ignored (e.g. "side-effect only", "will be destroyed on stack", etc). I do think that could be beneficial, but would be a lot of effort.
Related details
Attention is currently required from:
- Abhijith Nair
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Abhijith Nair (Gerrit)
Feb 13, 2026, 7:11:47 AM (9 days ago) Feb 13
to Andrew Paseltiner, Dana Fried, Chromium UI Views Reviews, Nico Weber, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Paseltiner and Nico Weber
Abhijith Nair voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Paseltiner
- Nico Weber
Nico Weber (Gerrit)
Feb 18, 2026, 11:00:21 AM (4 days ago) Feb 18
to Andrew Paseltiner, Nico Weber, Code Review Nudger, Abhijith Nair, Dana Fried, Chromium UI Views Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Paseltiner
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
Patchset-level comments
Nico Weber . resolved
Sorry, I thought I had lg'd this already.
Related details
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Feb 18, 2026, 11:00:39 AM (4 days ago) Feb 18
to Nico Weber, Code Review Nudger, Abhijith Nair, Dana Fried, Chromium UI Views Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Andrew Paseltiner voted Commit-Queue+2![]( "Open in Gerrit")
Chromium LUCI CQ (Gerrit)
Feb 18, 2026, 12:19:24 PM (4 days ago) Feb 18
to Andrew Paseltiner, Nico Weber, Code Review Nudger, Abhijith Nair, Dana Fried, Chromium UI Views Reviews, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, fdoray...@chromium.org, jessemcke...@google.com, scheduler...@chromium.org, gab+...@chromium.org, fuzzin...@chromium.org, android-web...@chromium.org, cros-report...@google.com, roblia...@chromium.org, sky+...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove non-adaptor uses of base::IgnoreResult
base::IgnoreResult adapts functions or callbacks; to ignore a
[[nodiscard]] value in general code should use std::ignore.
We mark base::IgnoreResult itself [[nodiscard]] with an appropriate
message to help prevent future misuse.
Change-Id: I8983266602f7c109d20ec663d3f066ac257d51a3
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Andrew Paseltiner <apase...@chromium.org>
Reviewed-by: Dana Fried <dfr...@chromium.org>
Reviewed-by: Abhijith Nair <abhiji...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586479}
Files:
- M android_webview/js_sandbox/service/js_sandbox_message_port.cc
- M base/functional/bind.h
- M base/task/thread_pool/sequence_unittest.cc
- M chrome/browser/ash/app_list/app_list_sort_browsertest.cc
- M chrome/browser/ash/policy/reporting/user_session_activity/user_session_activity_reporter_delegate.cc
- M chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client_unittest.cc
- M chrome/browser/policy/messaging_layer/util/reporting_server_connector.cc
- M chrome/test/fuzzing/atspi_in_process_fuzzer.cc
- M chrome/test/fuzzing/domato_html_in_process_fuzzer.cc
- M chrome/test/fuzzing/html_in_process_fuzzer.cc
- M chrome/test/fuzzing/page_load_in_process_fuzzer.cc
- M components/os_crypt/sync/key_storage_kwallet.cc
- M components/prefs/pref_service_unittest.cc
- M ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone.cc
Change size: M
Delta: 14 files changed, 43 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Abhijith Nair, +1 by Dana Fried, +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages