[input_mode] Increase Window length [chromium/src : main]

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray added 1 comment

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Line 1735, Patchset 1 (Latest): static base::TimeTicks last_input_started = base::TimeTicks::Min();

Etienne Pierre-Doray . unresolved

Let's use an object member (of MainThreadSchedulerImpl) instead.

Open in Gerrit

Related details

Attention is currently required from:

• Thiabaud Engelbrecht

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 1

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Comment-Date: Tue, 10 Feb 2026 19:11:25 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[AI Code Reviewer (Gerrit)]

Attention needed from Thiabaud Engelbrecht

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Line 1735, Patchset 1 (Latest): static base::TimeTicks last_input_started = base::TimeTicks::Min();

AI Code Reviewer . unresolved

Avoid using static local variables for state. This introduces global state that persists across scheduler instances (e.g. in tests) and resembles a shared memory pattern which is discouraged. Please make 'last_input_started' a member variable of 'MainThreadSchedulerImpl'. (Blink Style Guide: Threading model)

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

• Thiabaud Engelbrecht

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 1

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Comment-Date: Tue, 10 Feb 2026 19:13:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Thiabaud Engelbrecht (Gerrit)]

Attention needed from Etienne Pierre-Doray

Thiabaud Engelbrecht added 2 comments

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Line 1735, Patchset 1: static base::TimeTicks last_input_started = base::TimeTicks::Min();

Etienne Pierre-Doray . resolved

Let's use an object member (of MainThreadSchedulerImpl) instead.

Thiabaud Engelbrecht

Done

Line 1735, Patchset 1: static base::TimeTicks last_input_started = base::TimeTicks::Min();

AI Code Reviewer . resolved

Avoid using static local variables for state. This introduces global state that persists across scheduler instances (e.g. in tests) and resembles a shared memory pattern which is discouraged. Please make 'last_input_started' a member variable of 'MainThreadSchedulerImpl'. (Blink Style Guide: Threading model)

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Thiabaud Engelbrecht

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Etienne Pierre-Doray

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 3

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 15:14:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray voted and added 3 comments

Votes added by Etienne Pierre-Doray

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Etienne Pierre-Doray . resolved

LGTM with comment

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Line 294, Patchset 6 (Latest):BASE_FEATURE_PARAM(size_t,

Etienne Pierre-Doray . unresolved

Nit: TimeDelta
Then the conversion below isn't needed.

Line 1785, Patchset 6 (Latest): last_input_time_ = base::TimeTicks::Now();

Etienne Pierre-Doray . unresolved

Nit: last_input_use_case_time_

Open in Gerrit

Related details

Attention is currently required from:

• Thiabaud Engelbrecht

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 6

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Comment-Date: Thu, 12 Feb 2026 20:12:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Thiabaud Engelbrecht (Gerrit)]

Thiabaud Engelbrecht added 2 comments

File third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

Line 294, Patchset 6 (Latest):BASE_FEATURE_PARAM(size_t,

Etienne Pierre-Doray . resolved

Nit: TimeDelta
Then the conversion below isn't needed.

Thiabaud Engelbrecht

Done

Line 1785, Patchset 6 (Latest): last_input_time_ = base::TimeTicks::Now();

Etienne Pierre-Doray . resolved

Nit: last_input_use_case_time_

Thiabaud Engelbrecht

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 6

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 12 Feb 2026 20:49:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>

[Francois Pierre Doray (Gerrit)]

Francois Pierre Doray voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 6

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 12 Feb 2026 20:49:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Francois Pierre Doray (Gerrit)]

Attention needed from Thiabaud Engelbrecht

Francois Pierre Doray voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Thiabaud Engelbrecht

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 7

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Comment-Date: Thu, 12 Feb 2026 21:32:36 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Thiabaud Engelbrecht (Gerrit)]

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fbfef08f9d065cb57f4d4affc643beeddb67e20

Gerrit-Change-Number: 7559293

Gerrit-PatchSet: 7

Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 13 Feb 2026 15:42:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes