Etienne Pierre-Doray (Gerrit)

unread,

May 1, 2026, 2:56:49 PM (10 days ago) May 1

to Dave Tapuska, chromium...@chromium.org, Nate Chapin, kinuko...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, scheduler-...@chromium.org, dtapuska+...@chromium.org, loading...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, chikamu...@chromium.org

Attention needed from Dave Tapuska

Etienne Pierre-Doray has uploaded the change for review

Etienne Pierre-Doray would like Dave Tapuska to review this change.

Commit message

[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in third_party/blink

This CL replaces legacy TRACE_EVENT_OBJECT macros (e.g., TRACE_EVENT_OBJECT_DELETED_WITH_ID)
with modern TRACE_EVENT_INSTANT macros. These events are now emitted with more explicit
event names to provide better context, utilizing perfetto::TerminatingFlow where
applicable to maintain flow tracking.

This CL was uploaded by git cl split.

R=dtap...@chromium.org

Bug: 432427382

Change-Id: I74311fdaef9778cbbe07699538976fcfe1bb6aa7

Change diff

Change information

Files:

M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/loader/frame_loader.cc
M third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Change size: M

Delta: 5 files changed, 51 insertions(+), 33 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

May 1, 2026, 5:20:14 PM (10 days ago) May 1

to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, scheduler-...@chromium.org

Attention needed from Etienne Pierre-Doray

Dave Tapuska voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

May 1, 2026, 6:58:49 PM (10 days ago) May 1

to Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, scheduler-...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 1, 2026, 7:02:33 PM (10 days ago) May 1

to Etienne Pierre-Doray, Dave Tapuska, chromium...@chromium.org, Nate Chapin, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, dtapuska+...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, scheduler-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in third_party/blink

This CL replaces legacy TRACE_EVENT_OBJECT macros (e.g., TRACE_EVENT_OBJECT_DELETED_WITH_ID)
with modern TRACE_EVENT_INSTANT macros. These events are now emitted with more explicit
event names to provide better context, utilizing perfetto::TerminatingFlow where
applicable to maintain flow tracking.

This CL was uploaded by git cl split.

R=dtap...@chromium.org

Bug: 432427382

Change-Id: I74311fdaef9778cbbe07699538976fcfe1bb6aa7

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7810394

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1624154}

Files:

M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/loader/frame_loader.cc
M third_party/blink/renderer/platform/instrumentation/tracing/trace_event.h
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Change size: M

Delta: 5 files changed, 51 insertions(+), 33 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Dave Tapuska

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[tracing] Migrate legacy TRACE_EVENT_OBJECT macros in third_party/blink [chromium/src : main]

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray has uploaded the change for review

Commit message

Change diff

Change information

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted Code-Review+1

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information