fix animation.finished being accidentally GCed before running [chromium/src : main]

0 views
Skip to first unread message

Thiabaud Engelbrecht (Gerrit)

unread,
Mar 27, 2026, 2:59:55 PM (6 days ago) Mar 27
to Kevin Ellis, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Kevin Ellis

Thiabaud Engelbrecht added 1 comment

File third_party/blink/renderer/core/animation/animation.cc
Line 2252, Patchset 4: pending_finish_notification_ ||
Kevin Ellis . resolved

Can likely fix the failing unit test in compositor_animations_test.cc by adding a call to perform a microtask checkpoint in SimulateFrame() after the call to Update(). This will ensure that he pending_finish_notification_ flag is cleared before the GC call in the test. This checkpoint was called in version of SimulateFrame() in animation_test.cc by was missing from compositor_animations_test.cc.

Thiabaud Engelbrecht

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
Gerrit-Change-Number: 7681235
Gerrit-PatchSet: 12
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Mar 2026 18:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Ellis <kev...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Mar 27, 2026, 3:37:11 PM (6 days ago) Mar 27
to Thiabaud Engelbrecht, Kevin Ellis, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
Attention needed from Kevin Ellis and Thiabaud Engelbrecht

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Etienne Pierre-Doray . resolved

LGTM

File third_party/blink/renderer/core/animation/compositor_animations_test.cc
Line 572, Patchset 13 (Latest): SimulateMicrotask();
Etienne Pierre-Doray . unresolved

Does this make tests fail otherwise without the fix?

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
  • Thiabaud Engelbrecht
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
    Gerrit-Change-Number: 7681235
    Gerrit-PatchSet: 13
    Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
    Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Comment-Date: Fri, 27 Mar 2026 19:37:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thiabaud Engelbrecht (Gerrit)

    unread,
    Mar 30, 2026, 9:50:01 AM (3 days ago) Mar 30
    to Etienne Pierre-Doray, Kevin Ellis, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
    Attention needed from Kevin Ellis

    Thiabaud Engelbrecht added 1 comment

    File third_party/blink/renderer/core/animation/compositor_animations_test.cc
    Line 572, Patchset 13 (Latest): SimulateMicrotask();
    Etienne Pierre-Doray . resolved

    Does this make tests fail otherwise without the fix?

    Thiabaud Engelbrecht

    Yes

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kevin Ellis
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
      Gerrit-Change-Number: 7681235
      Gerrit-PatchSet: 13
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 13:49:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kevin Ellis (Gerrit)

      unread,
      Mar 30, 2026, 11:47:10 AM (3 days ago) Mar 30
      to Thiabaud Engelbrecht, Etienne Pierre-Doray, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org
      Attention needed from Thiabaud Engelbrecht

      Kevin Ellis voted and added 1 comment

      Votes added by Kevin Ellis

      Code-Review+1

      1 comment

      Patchset-level comments
      Kevin Ellis . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Thiabaud Engelbrecht
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
      Gerrit-Change-Number: 7681235
      Gerrit-PatchSet: 13
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 15:47:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Thiabaud Engelbrecht (Gerrit)

      unread,
      Mar 30, 2026, 12:02:15 PM (3 days ago) Mar 30
      to Kevin Ellis, Etienne Pierre-Doray, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

      Thiabaud Engelbrecht voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
      Gerrit-Change-Number: 7681235
      Gerrit-PatchSet: 13
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Mon, 30 Mar 2026 16:01:52 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 30, 2026, 1:20:11 PM (3 days ago) Mar 30
      to Thiabaud Engelbrecht, Kevin Ellis, Etienne Pierre-Doray, Olga Gerchikov, Menard, Alexis, Raphael Kubo da Costa, Kentaro Hara, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      fix animation.finished being accidentally GCed before running

      This CL fixes a bug where the animation.finished promise is accidentally GCed before it has a chance to run. This relies on timing and should be very rare in practice.
      Bug:
      Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
      Reviewed-by: Kevin Ellis <kev...@chromium.org>
      Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>
      Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1607201}
      Files:
      • M third_party/blink/renderer/core/animation/animation.cc
      • M third_party/blink/renderer/core/animation/compositor_animations_test.cc
      • M third_party/blink/renderer/core/animation/effect_stack_test.cc
      Change size: S
      Delta: 3 files changed, 14 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kevin Ellis, +1 by Etienne Pierre-Doray
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8355fd19f3b8b422deeff40cdf04ca7bd73634c8
      Gerrit-Change-Number: 7681235
      Gerrit-PatchSet: 14
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages