Rust-based ETC1 encoder for Clank

[Tatsuyuki Ishi]

Hi Chrome Rust folks,

My team is developing a Rust-based ETC1 encoder for Clank, designed to be a fast (50x) and safe replacement for the existing ETC1 encoder. The algorithm is based on that of etcpak, an external ETC1 encoder (not used by Chromium), but we are replacing platform-specific SIMD intrinsics and shuffling with fully portable SIMD in our implementation, while maintaining the same performance. The design doc is below and we have a sign-off from my team's director.

https://docs.google.com/document/d/1zVgpetbG7OX6jbKQ2TtY0vjO-K9eEZx5nOLhUUt8ULQ/edit?tab=t.0 (Internal only)

Our team is planning to maintain this component, but ultimately the encoder will be called from Clank code. I would like to know if I should also have a sign-off from the director of the Clank team?

(General comments on the doc are also appreciated.)

Tatsuyuki

[David Adrian]

> Our team is planning to maintain this component, but ultimately the encoder will be called from Clank code. I would like to know if I should also have a sign-off from the director of the Clank team?

You should have sign-off from the Clank OWNERs who are calling your code. Presumably, they will not sign off on something that their director wouldn't approve of. This can be had as part of the standard code review process.

--
You received this message because you are subscribed to the Google Groups "rust-fyi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rust-fyi+u...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/rust-fyi/CABqzrSMOcixmZqoHCE6-orWkyP6tT_guf1Q6fmTa8u_qn-NeZQ%40mail.gmail.com.

[Tatsuyuki Ishi]

On Jan 24, 2025, at 2:39, David Adrian <dad...@google.com> wrote:

> Our team is planning to maintain this component, but ultimately the encoder will be called from Clank code. I would like to know if I should also have a sign-off from the director of the Clank team?

You should have sign-off from the Clank OWNERs who are calling your code. Presumably, they will not sign off on something that their director wouldn't approve of. This can be had as part of the standard code review process.

Ack, I’ve already had a few folks from Clank review my previous doc, and I plan to go down the route of getting standard code review OWNERs approval.

[David Adrian]

We're excited to see this, let @chrome-rust know if you need any help with the toolchain or interop!