The non-inclusive language check and 3p code

[Daniel Cheng]

What is the expectation around non-inclusive language and 3p code?

In this case, the problematic file is here:

https://github.com/bluss/either/blob/master/.github/workflows/ci.yml

The flagged word reflects the name of the git branch. I *could* request the upstream project to rename their git branch and update their CI config, but while this would be the ideal outcome in an ideal world, it also imposes extra process work on the volunteer maintainers of an OSS project.

I could apply a local patch to this crate to add # nocheck comments as requested, but that seems heavyweight and complicates future work to update the 3p crate (anyone updating it has to remember there are local patches, and to re-apply them, and/or update the patches if needed).

Instead, I'm opting to just skip the presubmit, but it feels like there should be a better option here for 3p code (e.g. maybe we could provide an escape hatch via a tag in the CL description).

(There is a third option, which is for me to go and personally fix their project, but I think requiring that of every 3p library would be sub-optimal)

Daniel

[Peter Kasting]

Imo, skipping the presubmit is fine, and I might drop a friendly note upstream telling them if they make a change it would be convenient for us, but I wouldn't go further.

PK

--
You received this message because you are subscribed to the Google Groups "community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to community+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/community/CAF3XrKpjhVdaYc9z35X7%3D0ySmhBYApr%2BSi5YJDnV6cMqMi-yjg%40mail.gmail.com.

[Dirk Pranke]

I feel like we actually have guidance for this somewhere (that says that 3p code is out of scope) but I'm not finding it at the moment. I would also say that skipping presubmit in this case is fine. I can check w/ the Gerrit folks to see if there's an allowlist of exceptions we can maintain somewhere.

-- Dirk

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/community/CAAHOzFBti__6bHViLGcksFggO4dbGHcVw2AtS4Sc3HSnUmqaPw%40mail.gmail.com.

[Dirk Pranke]

Hi Josip,

Do you know if the inclusive language checker has any guidance on how to manage 3p code, and/or if there's some allowlist we can modify to make things pass?

-- Dirk

[Josip Sokcevic]

Afaik, there's no 3p guidance, but we have allowlist: https://source.chromium.org/chromium/chromium/src/+/main:infra/inclusive_language_presubmit_exempt_dirs.txt so I'd recommend adding it there. 

--

Josip Sokcevic

[Daniel Cheng]

Thanks. I've sent out  https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4944933 to add language to consider updating the allowlist if appropriate. I hope that's OK—it specifically mentions 3p code, which I think should be understood to be about things under third_party (excepting Blink). I did this because I think a lot of people don't know about it: https://chromium-review.googlesource.com/c/chromium/src/+/4945250/

(And maybe we should be stricter about not allowing new additions in non 3p code?)

Daniel