Add the most basic possible ContentBrowserTest in Rust [chromium/src : main]

danakj (Gerrit)

unread,

May 12, 2022, 6:49:39 PM5/12/22

to Łukasz Anforowicz, rust...@chromium.org, Matthew Riley, Adrian Taylor

Attention is currently required from: Łukasz Anforowicz.

danakj would like Łukasz Anforowicz to review this change.

Add the most basic possible ContentBrowserTest in Rust

Bug: 1305396
Change-Id: Ia87ab5856260f9edc9c211804a5af221e63058f7
---
M content/public/test/browser_test_base.h
M content/public/test/content_browser_test.cc
M content/test/BUILD.gn
M testing/rust_gtest_interop/gtest_attribute.rs
M testing/rust_gtest_interop/rust_gtest_interop_unittest.rs
M testing/rust_gtest_interop/rust_gtest_interop_unittest_main.cc
M testing/rust_gtest_interop/test/test_subclass.cc
M testing/rust_gtest_interop/test/test_subclass.h
M testing/rust_gtest_interop/test/test_subclass.rs
9 files changed, 252 insertions(+), 35 deletions(-)

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

May 12, 2022, 6:49:47 PM5/12/22

to rust...@chromium.org, Łukasz Anforowicz, Adrian Taylor, Matthew Riley, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Would you like me to split up the testing/ and content/ parts of this?

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

May 12, 2022, 6:49:57 PM5/12/22

to rust...@chromium.org, Łukasz Anforowicz, Adrian Taylor, Matthew Riley, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

View Change

1 comment:

Patchset:

- Patch Set #2:
  Would you like me to split up the testing/ and content/ parts of this?

- Unresolving

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

May 12, 2022, 6:50:19 PM5/12/22

to rust...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

danakj uploaded patch set #3 to this change.

View Change

Add the most basic possible ContentBrowserTest in Rust

Bug: 1305396
Change-Id: Ia87ab5856260f9edc9c211804a5af221e63058f7

Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,linux-rust-x64-dbg,android-rust-arm-rel,android-rust-arm-dbg


---
M content/public/test/browser_test_base.h
M content/public/test/content_browser_test.cc
M content/test/BUILD.gn
M testing/rust_gtest_interop/gtest_attribute.rs
M testing/rust_gtest_interop/rust_gtest_interop_unittest.rs
M testing/rust_gtest_interop/rust_gtest_interop_unittest_main.cc
M testing/rust_gtest_interop/test/test_subclass.cc
M testing/rust_gtest_interop/test/test_subclass.h
M testing/rust_gtest_interop/test/test_subclass.rs

9 files changed, 253 insertions(+), 35 deletions(-)

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

May 12, 2022, 6:53:46 PM5/12/22

to rust...@chromium.org, Chromium LUCI CQ, Łukasz Anforowicz, Adrian Taylor, Matthew Riley, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Now with all the files added!

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

May 13, 2022, 11:51:21 AM5/13/22

to rust...@chromium.org, Chromium LUCI CQ, Łukasz Anforowicz, Adrian Taylor, Matthew Riley, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

View Change

1 comment:

Patchset:
- Patch Set #10:
  I've realized the content bits need to change and made a bunch of changes there and filed https://bugs.chromium.org/p/chromium/issues/detail?id=1325336 about it. But I think it's good to split it into another CL at this point. So I will do that now.

To view, visit change 3644893. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward