Remove _rs suffix from mixed target Rust crates. [chromium/src : main]

2 views
Skip to first unread message

danakj (Gerrit)

unread,
Mar 8, 2022, 12:18:35 PM3/8/22
to rust...@chromium.org, security-...@chromium.org, vmpstr...@chromium.org

Attention is currently required from: Adrian Taylor.

danakj uploaded patch set #2 to this change.

View Change

Remove _rs suffix from mixed target Rust crates.

As //base is a mixed target, the crate name was previously base_rs. Now
base_rs::Foo becomes base::Foo as intended.

R=adet...@chromium.org

Bug: 1296158
Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel
---
M base/json/json_parser_unittest.rs
M base/values_unittest.rs
M build/rust/mixed_target.gni
M build/rust/tests/test_rust_exe/main.rs
M build/rust/tests/test_rust_unittests/main.rs
M testing/rust_gtest_interop/gtest_attribute.rs
M testing/rust_gtest_interop/rust_gtest_interop_unittest.rs
7 files changed, 31 insertions(+), 18 deletions(-)

To view, visit change 3510293. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
Gerrit-Change-Number: 3510293
Gerrit-PatchSet: 2
Gerrit-Owner: danakj <dan...@chromium.org>
Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Matthew Riley <mat...@chromium.org>
Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Attention: Adrian Taylor <adet...@chromium.org>
Gerrit-MessageType: newpatchset

danakj (Gerrit)

unread,
Mar 8, 2022, 12:18:36 PM3/8/22
to rust...@chromium.org, security-...@chromium.org, vmpstr...@chromium.org, Adrian Taylor, chromium...@chromium.org, Łukasz Anforowicz, Matthew Riley

Attention is currently required from: Adrian Taylor.

View Change

    To view, visit change 3510293. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
    Gerrit-Change-Number: 3510293
    Gerrit-PatchSet: 1
    Gerrit-Owner: danakj <dan...@chromium.org>
    Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
    Gerrit-CC: Matthew Riley <mat...@chromium.org>
    Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
    Gerrit-Attention: Adrian Taylor <adet...@chromium.org>
    Gerrit-Comment-Date: Tue, 08 Mar 2022 17:18:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Adrian Taylor (Gerrit)

    unread,
    Mar 8, 2022, 12:23:11 PM3/8/22
    to danakj, rust...@chromium.org, security-...@chromium.org, vmpstr...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Łukasz Anforowicz, Matthew Riley

    Attention is currently required from: danakj.

    Patch set 2:Code-Review +1

    View Change

      To view, visit change 3510293. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
      Gerrit-Change-Number: 3510293
      Gerrit-PatchSet: 2
      Gerrit-Owner: danakj <dan...@chromium.org>
      Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
      Gerrit-Reviewer: danakj <dan...@chromium.org>
      Gerrit-CC: Matthew Riley <mat...@chromium.org>
      Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
      Gerrit-Attention: danakj <dan...@chromium.org>
      Gerrit-Comment-Date: Tue, 08 Mar 2022 17:22:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      danakj (Gerrit)

      unread,
      Mar 9, 2022, 11:40:41 AM3/9/22
      to rust...@chromium.org, security-...@chromium.org, vmpstr...@chromium.org, Adrian Taylor, Chromium LUCI CQ, chromium...@chromium.org, Łukasz Anforowicz, Matthew Riley

      Patch set 8:Commit-Queue +2

      View Change

        To view, visit change 3510293. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
        Gerrit-Change-Number: 3510293
        Gerrit-PatchSet: 8
        Gerrit-Owner: danakj <dan...@chromium.org>
        Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
        Gerrit-Reviewer: danakj <dan...@chromium.org>
        Gerrit-CC: Matthew Riley <mat...@chromium.org>
        Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
        Gerrit-Comment-Date: Wed, 09 Mar 2022 16:40:32 +0000

        Chromium LUCI CQ (Gerrit)

        unread,
        Mar 9, 2022, 1:21:54 PM3/9/22
        to danakj, rust...@chromium.org, security-...@chromium.org, vmpstr...@chromium.org, Adrian Taylor, chromium...@chromium.org, Łukasz Anforowicz, Matthew Riley

        Chromium LUCI CQ submitted this change.

        View Change



        2 is the latest approved patch-set.
        The change was submitted with unreviewed changes in the following files:

        ```
        The name of the file: mojo/public/rust/lib.rs
        Insertions: 1, Deletions: 1.

        The diff is too large to show. Please review the diff.
        ```

        Approvals: Adrian Taylor: Looks good to me danakj: Commit
        Remove _rs suffix from mixed target Rust crates.

        As //base is a mixed target, the crate name was previously base_rs. Now
        base_rs::Foo becomes base::Foo as intended.

        R=adet...@chromium.org

        Bug: 1296158
        Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
        Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510293
        Reviewed-by: Adrian Taylor <adet...@chromium.org>
        Commit-Queue: danakj <dan...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#979321}

        ---
        M base/json/json_parser_unittest.rs
        M base/values_unittest.rs
        M build/rust/mixed_target.gni
        M build/rust/tests/test_rust_exe/main.rs
        M build/rust/tests/test_rust_unittests/main.rs
        M mojo/public/rust/lib.rs
        M testing/rust_gtest_interop/gtest_attribute.rs
        M testing/rust_gtest_interop/rust_gtest_interop_unittest.rs
        8 files changed, 36 insertions(+), 19 deletions(-)


        To view, visit change 3510293. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I9a95c13080657d737fa87c109de58ced4c9dd7d8
        Gerrit-Change-Number: 3510293
        Gerrit-PatchSet: 9
        Gerrit-Owner: danakj <dan...@chromium.org>
        Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: danakj <dan...@chromium.org>
        Gerrit-CC: Matthew Riley <mat...@chromium.org>
        Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages