Put gtest_rust_interop into a static library. [chromium/src : main]

danakj (Gerrit)

unread,

Mar 4, 2022, 6:33:13 PM3/4/22

to rust...@chromium.org, Łukasz Anforowicz, Adrian Taylor, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

View Change

To view, visit change 3504205. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Mar 4, 2022, 6:33:19 PM3/4/22

to rust...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

danakj uploaded patch set #2 to this change.

View Change

Put gtest_rust_interop into a static library.

This ensures it links in the unit tests .exe target, so that when
tests are registered with Gtest they go to the right place.

R=luk...@chromium.org

Bug: 1296156
Change-Id: I1c3750bb1c735e790569ce33093b2cc9f63d2b50
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel
---
M testing/rust_gtest_interop/BUILD.gn
1 file changed, 18 insertions(+), 4 deletions(-)

To view, visit change 3504205. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Mar 4, 2022, 6:33:33 PM3/4/22

to rust...@chromium.org, Łukasz Anforowicz, Adrian Taylor, chromium...@chromium.org

Attention is currently required from: Łukasz Anforowicz.

Patch set 2:Auto-Submit +1

View Change

To view, visit change 3504205. To unsubscribe, or for help writing mail filters, visit settings.

Łukasz Anforowicz (Gerrit)

unread,

Mar 4, 2022, 11:24:50 PM3/4/22

to danakj, rust...@chromium.org, Adrian Taylor, chromium...@chromium.org

Attention is currently required from: danakj.

Patch set 2:Code-Review +1Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #2:
  Thanks! LGTM!

To view, visit change 3504205. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Mar 4, 2022, 11:48:44 PM3/4/22

to danakj, rust...@chromium.org, Łukasz Anforowicz, Adrian Taylor, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Łukasz Anforowicz: Looks good to me; Commit
  danakj: Send CL to CQ automatically after approval

Put gtest_rust_interop into a static library.

This ensures it links in the unit tests .exe target, so that when
tests are registered with Gtest they go to the right place.

R=luk...@chromium.org

Bug: 1296156
Change-Id: I1c3750bb1c735e790569ce33093b2cc9f63d2b50
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3504205
Auto-Submit: danakj <dan...@chromium.org>
Reviewed-by: Łukasz Anforowicz <luk...@chromium.org>
Commit-Queue: Łukasz Anforowicz <luk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977946}
---
M testing/rust_gtest_interop/BUILD.gn
1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/testing/rust_gtest_interop/BUILD.gn b/testing/rust_gtest_interop/BUILD.gn
index c85a291..b5e27b3 100644
--- a/testing/rust_gtest_interop/BUILD.gn
+++ b/testing/rust_gtest_interop/BUILD.gn
@@ -2,14 +2,12 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import("//build/rust/mixed_component.gni")
+import("//build/rust/mixed_static_library.gni")
 import("//build/rust/rust_macro.gni")
 import("//testing/test.gni")
 
 if (enable_rust) {
-  # TODO(crbug.com/1297592): This should be a mixed_static_library, but we don't
-  # have that type of target right now.
-  mixed_component("rust_gtest_interop") {
+  mixed_static_library("rust_gtest_interop") {
     testonly = true
     sources = [
       "rust_gtest_interop.cc",

To view, visit change 3504205. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward