Leave a TODO breadcrumb to the GN bug about missing --extern proc_macro [chromium/src : main]
0 views
Skip to first unread message
danakj (Gerrit)
Feb 24, 2022, 3:28:42 PM2/24/22
to rust...@chromium.org, Chromium LUCI CQ, Adrian Taylor, chromium...@chromium.org
Attention is currently required from: Adrian Taylor.
To view, visit change 3488099. To unsubscribe, or for help writing mail filters, visit settings.
danakj (Gerrit)
Feb 24, 2022, 3:28:47 PM2/24/22
to rust...@chromium.org, Chromium LUCI CQ, Adrian Taylor, chromium...@chromium.org
Attention is currently required from: Adrian Taylor.
Patch set 1:Auto-Submit +1
Adrian Taylor (Gerrit)
Feb 24, 2022, 3:30:27 PM2/24/22
to danakj, rust...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org
Attention is currently required from: danakj.
Patch set 1:Code-Review +1Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Feb 24, 2022, 4:53:21 PM2/24/22
to danakj, rust...@chromium.org, Adrian Taylor, chromium...@chromium.org
Chromium LUCI CQ submitted this change.
Approvals:
Adrian Taylor: Looks good to me; Commit
danakj: Dry run; Send CL to CQ automatically after approval
Leave a TODO breadcrumb to the GN bug about missing --extern proc_macro
R=adet...@chromium.org
Change-Id: I02afb6a20077f33665aa44913c103b42d6cf2ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3488099
Commit-Queue: danakj <dan...@chromium.org>
Auto-Submit: danakj <dan...@chromium.org>
Reviewed-by: Adrian Taylor <adet...@chromium.org>
Commit-Queue: Adrian Taylor <adet...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#974849}
---
M build/rust/rust_target.gni
1 file changed, 20 insertions(+), 0 deletions(-)
diff --git a/build/rust/rust_target.gni b/build/rust/rust_target.gni
index 342eab5..988e3e0 100644
--- a/build/rust/rust_target.gni
+++ b/build/rust/rust_target.gni
@@ -77,6 +77,9 @@
}
_forward_to_host_toolchain = false
if (invoker.target_type == "rust_proc_macro") {
+ # TODO(crbug.com/gn/104): GN rust_proc_macro targets are missing this
+ # command line flag, for the proc_macro crate which is provided by rustc for
+ # compiling proc-macros.
_rustflags += [
"--extern",
"proc_macro",
To view, visit change 3488099. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages