Use -Zremap-cwd-prefix to remove the cwd from Rust outputs [chromium/src : main]

8 views
Skip to first unread message

danakj (Gerrit)

unread,
Mar 17, 2022, 3:55:02 PM3/17/22
to rust...@chromium.org, Nico Weber, chromium...@chromium.org

Attention is currently required from: Nico Weber.

View Change

1 comment:

  • Patchset:

To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
Gerrit-Change-Number: 3533899
Gerrit-PatchSet: 1
Gerrit-Owner: danakj <dan...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Thu, 17 Mar 2022 19:54:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Nico Weber (Gerrit)

unread,
Mar 17, 2022, 4:04:21 PM3/17/22
to danakj, rust...@chromium.org, Nico Weber, chromium...@chromium.org

Attention is currently required from: danakj.

Patch set 2:Code-Review +1

View Change

1 comment:

To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
Gerrit-Change-Number: 3533899
Gerrit-PatchSet: 2
Gerrit-Owner: danakj <dan...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Comment-Date: Thu, 17 Mar 2022 20:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

danakj (Gerrit)

unread,
Mar 17, 2022, 4:04:43 PM3/17/22
to rust...@chromium.org, Nico Weber, chromium...@chromium.org

Patch set 2:Commit-Queue +2

View Change

    To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
    Gerrit-Change-Number: 3533899
    Gerrit-PatchSet: 2
    Gerrit-Owner: danakj <dan...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: danakj <dan...@chromium.org>
    Gerrit-Comment-Date: Thu, 17 Mar 2022 20:04:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    danakj (Gerrit)

    unread,
    Mar 17, 2022, 4:05:07 PM3/17/22
    to rust...@chromium.org, Chromium LUCI CQ, Nico Weber, chromium...@chromium.org

    Patch set 2:-Commit-Queue

    View Change

      To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
      Gerrit-Change-Number: 3533899
      Gerrit-PatchSet: 2
      Gerrit-Owner: danakj <dan...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: danakj <dan...@chromium.org>
      Gerrit-Comment-Date: Thu, 17 Mar 2022 20:04:56 +0000

      danakj (Gerrit)

      unread,
      Mar 17, 2022, 4:05:16 PM3/17/22
      to rust...@chromium.org

      danakj uploaded patch set #3 to this change.

      View Change

      Use -Zremap-cwd-prefix to remove the cwd from Rust outputs

      This commandline argument removes the current working directory,
      replacing it with `.` in all build outputs.

      R=tha...@chromium.org

      Bug: 1292127
      Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
      Cq-Include-Trybots: luci.chromium.try:android-rust-arm-dbg,android-rust-arm-rel,linux-rust-x64-rel
      ---
      M build/config/compiler/BUILD.gn
      1 file changed, 22 insertions(+), 4 deletions(-)

      To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
      Gerrit-Change-Number: 3533899
      Gerrit-PatchSet: 3
      Gerrit-Owner: danakj <dan...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: danakj <dan...@chromium.org>
      Gerrit-MessageType: newpatchset

      danakj (Gerrit)

      unread,
      Mar 17, 2022, 4:05:28 PM3/17/22
      to rust...@chromium.org, Chromium LUCI CQ, Nico Weber, chromium...@chromium.org

      Patch set 3:Commit-Queue +2

      View Change

        To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
        Gerrit-Change-Number: 3533899
        Gerrit-PatchSet: 3
        Gerrit-Owner: danakj <dan...@chromium.org>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-Reviewer: danakj <dan...@chromium.org>
        Gerrit-Comment-Date: Thu, 17 Mar 2022 20:05:18 +0000

        Chromium LUCI CQ (Gerrit)

        unread,
        Mar 17, 2022, 6:10:42 PM3/17/22
        to danakj, rust...@chromium.org, Nico Weber, chromium...@chromium.org

        Chromium LUCI CQ submitted this change.

        View Change



        2 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Approvals: Nico Weber: Looks good to me danakj: Commit
        Use -Zremap-cwd-prefix to remove the cwd from Rust outputs

        This commandline argument removes the current working directory,
        replacing it with `.` in all build outputs.

        R=tha...@chromium.org

        Bug: 1292127
        Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
        Cq-Include-Trybots: luci.chromium.try:android-rust-arm-dbg,android-rust-arm-rel,linux-rust-x64-rel
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3533899
        Reviewed-by: Nico Weber <tha...@chromium.org>
        Commit-Queue: danakj <dan...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#982448}
        ---
        M build/config/compiler/BUILD.gn
        1 file changed, 26 insertions(+), 4 deletions(-)

        diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
        index 48aa424..60165f1 100644
        --- a/build/config/compiler/BUILD.gn
        +++ b/build/config/compiler/BUILD.gn
        @@ -820,13 +820,15 @@
        "-Coverflow-checks=on",

        # To make Rust .d files compatible with ninja
        - "-Z",
        - "dep-info-omit-d-target",
        + "-Zdep-info-omit-d-target",

        # If a macro panics during compilation, show which macro and where it is
        # defined.
        - "-Z",
        - "macro-backtrace",
        + "-Zmacro-backtrace",
        +
        + # For deterministic builds, keep the local machine's current working
        + # directory from appearing in build outputs.
        + "-Zremap-cwd-prefix=.",
        ]
        if (rust_abi_target != "") {
        rustflags += [ "--target=$rust_abi_target" ]

        To view, visit change 3533899. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I55e9be5fc6ac9badf05f92f044b26dd757d82017
        Gerrit-Change-Number: 3533899
        Gerrit-PatchSet: 4
        Gerrit-Owner: danakj <dan...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
        Gerrit-Reviewer: danakj <dan...@chromium.org>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages