Propagate rs_public_deps to the rust_target.gni's rlib. [chromium/src : main]

danakj (Gerrit)

unread,

Mar 30, 2022, 10:19:42 AM3/30/22

to rust...@chromium.org, Adrian Taylor, chromium...@chromium.org, Matthew Riley

Attention is currently required from: Adrian Taylor.

Patch set 2:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 3560900. To unsubscribe, or for help writing mail filters, visit settings.

Adrian Taylor (Gerrit)

unread,

Mar 30, 2022, 10:30:05 AM3/30/22

to danakj, rust...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Matthew Riley

Attention is currently required from: danakj.

Patch set 2:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3560900. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Mar 30, 2022, 11:28:53 AM3/30/22

to danakj, rust...@chromium.org, Adrian Taylor, chromium...@chromium.org, Matthew Riley

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Adrian Taylor: Looks good to me; Commit
  danakj: Dry run; Send CL to CQ automatically after approval

Propagate rs_public_deps to the rust_target.gni's rlib.

This accidentally broke in https://chromium-review.googlesource.com/c/chromium/src/+/3321897

R=adet...@chromium.org

Bug: 1296155
Change-Id: Ifaa265fe08bbb21af8a2b403ab45105192253eb4
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-dbg,linux-rust-x64-rel,android-rust-arm-rel,android-rust-arm-dbg
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3560900
Commit-Queue: danakj <dan...@chromium.org>
Auto-Submit: danakj <dan...@chromium.org>
Reviewed-by: Adrian Taylor <adet...@chromium.org>
Commit-Queue: Adrian Taylor <adet...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986996}
---
M build/rust/rust_target.gni
1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/build/rust/rust_target.gni b/build/rust/rust_target.gni
index fdc751f..63bae4c9 100644
--- a/build/rust/rust_target.gni
+++ b/build/rust/rust_target.gni
@@ -262,7 +262,7 @@
     }
 
     _rust_deps = _deps
-    _rust_public_deps = []
+    _rust_public_deps = _public_deps
     _autocxx_deps = _deps + _public_deps
 
     # In a mixed target, the C++ bindings may include headers from the C++

To view, visit change 3560900. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward