Add debug Rust trybots. [chromium/tools/build : main]

danakj (Gerrit)

unread,

Mar 10, 2022, 11:51:27 AM3/10/22

to rust...@chromium.org, LUCI CQ, Erik Staab, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab.

Patch set 3:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #3:
  It would be nice to test this, but I couldn't find any tests of the sort. Or do we test it by landing and running them?

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Erik Staab (Gerrit)

unread,

Mar 10, 2022, 12:49:04 PM3/10/22

to Garrett Beaty, rust...@chromium.org, danakj

Attention is currently required from: Garrett Beaty, danakj.

Erik Staab would like Garrett Beaty to review this change authored by danakj.

View Change

Add debug Rust trybots.

Debug builds use the component build, which can now link successfully
with mixed-C++/Rust components (bug 1296156).

To prevent breaking the build configuration add debug trybots for both
Linux and Android.

R=est...@chromium.org

Change-Id: Ie2f105f84cf87e75340a57a03f4d9387f31d7069
Bug: 1305205, 1296156
---
M recipes/recipe_modules/chromium_tests_builder_config/builders/chromium_rust.py
M recipes/recipe_modules/chromium_tests_builder_config/trybots.py
2 files changed, 69 insertions(+), 4 deletions(-)

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Erik Staab (Gerrit)

unread,

Mar 10, 2022, 12:49:11 PM3/10/22

to danakj, rust...@chromium.org, Garrett Beaty, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Garrett Beaty, danakj.

View Change

1 comment:

Patchset:
- Patch Set #3:
  +gbeaty, who knows this workflow best (and would know if his new src-side-only config system would work here).

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Beaty (Gerrit)

unread,

Mar 10, 2022, 1:03:37 PM3/10/22

to danakj, rust...@chromium.org, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: danakj.

View Change

1 comment:

File recipes/recipe_modules/chromium_tests_builder_config/builders/chromium_rust.py:
- Patch Set #3, Line 96: print(SPEC)
  This should be removed

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Beaty (Gerrit)

unread,

Mar 10, 2022, 1:05:29 PM3/10/22

to danakj, rust...@chromium.org, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab, danakj.

View Change

1 comment:

Patchset:
- Patch Set #3:
  +gbeaty, who knows this workflow best (and would know if his new src-side-only config system would w […]
  The src-side config would work here, if you're interested in using it, see https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/infra/new_builder.md. Eventually we will want everything on the src-side configs

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Mar 10, 2022, 1:32:09 PM3/10/22

to rust...@chromium.org, Garrett Beaty, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab, Garrett Beaty.

View Change

1 comment:

File recipes/recipe_modules/chromium_tests_builder_config/builders/chromium_rust.py:

- Patch Set #3, Line 96: print(SPEC)
  This should be removed

- OOPS thanks

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Mar 10, 2022, 1:32:50 PM3/10/22

to rust...@chromium.org, Erik Staab, Garrett Beaty, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab, Garrett Beaty.

View Change

1 comment:

Patchset:
- Patch Set #3:
  The src-side config would work here, if you're interested in using it, see https://chromium. […]
  We should maybe migrate all the rust bots instead of having some on one and some on the other. Could I do that in another CL?

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Beaty (Gerrit)

unread,

Mar 10, 2022, 1:39:32 PM3/10/22

to danakj, rust...@chromium.org, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab, danakj.

View Change

1 comment:

Patchset:
- Patch Set #3:
  We should maybe migrate all the rust bots instead of having some on one and some on the other. […]
  Yeah, no problem.

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Garrett Beaty (Gerrit)

unread,

Mar 10, 2022, 1:39:38 PM3/10/22

to danakj, rust...@chromium.org, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab, danakj.

Patch set 4:Code-Review +1

View Change

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Mar 10, 2022, 1:44:29 PM3/10/22

to rust...@chromium.org, Garrett Beaty, Erik Staab, LUCI CQ, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

Attention is currently required from: Erik Staab.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

LUCI CQ (Gerrit)

unread,

Mar 10, 2022, 1:52:39 PM3/10/22

to danakj, rust...@chromium.org, Garrett Beaty, Erik Staab, Adrian Taylor, chromium...@chromium.org, Collin Baker, Łukasz Anforowicz, Nico Weber

LUCI CQ submitted this change.

View Change

Approvals:
  Garrett Beaty: Looks good to me
  danakj: Commit

Add debug Rust trybots.

Debug builds use the component build, which can now link successfully
with mixed-C++/Rust components (bug 1296156).

To prevent breaking the build configuration add debug trybots for both
Linux and Android.

R=est...@chromium.org

Change-Id: Ie2f105f84cf87e75340a57a03f4d9387f31d7069
Bug: 1305205, 1296156

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/3516198
Reviewed-by: Garrett Beaty <gbe...@google.com>
Commit-Queue: danakj <dan...@chromium.org>


---
M recipes/recipe_modules/chromium_tests_builder_config/builders/chromium_rust.py
M recipes/recipe_modules/chromium_tests_builder_config/trybots.py

2 files changed, 70 insertions(+), 4 deletions(-)

To view, visit change 3516198. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward