Add BASE_EXPORT to all glue functions in base::rs_glue. [chromium/src : main]
danakj (Gerrit)
Attention is currently required from: Adrian Taylor.
To view, visit change 3530066. To unsubscribe, or for help writing mail filters, visit settings.
Adrian Taylor (Gerrit)
Attention is currently required from: danakj, Adrian Taylor.
Patch set 1:Code-Review +1
1 comment:
Patchset:
+1 modulo the discussion happening on chat about whether the split between libbase.so (C++ code) and libbase-some-kind-of-unit-tests.so (Rust code) is desirable long term
To view, visit change 3530066. To unsubscribe, or for help writing mail filters, visit settings.
danakj (Gerrit)
Attention is currently required from: Adrian Taylor.
Patch set 1:Commit-Queue +2
1 comment:
Patchset:
+1 modulo the discussion happening on chat about whether the split between libbase. […]
What's happening is
base includes Rust code, which has C++ bindings to it.
base exports the C++ bindings in public_deps.In release those symbols dont get used and get stripped. Debug keeps all the symbols.
base_unittests depends on base which means it depends on the C++ bindings. The header file for the bindings includes rs_glue.h. So the symbols are visible to base_unittests but not exported.
A release build would fail similarly if we had a Rust function with C++ bindings to it, and a C++ dependent tried to use it.
To view, visit change 3530066. To unsubscribe, or for help writing mail filters, visit settings.
danakj (Gerrit)
Attention is currently required from: Adrian Taylor.
danakj uploaded patch set #2 to this change.
Add BASE_EXPORT to all glue functions in base::rs_glue.
These functions are used across components (from the Rust library)
so they need to be exported for component builds.
R=adet...@chromium.org
Bug: 1296156
Change-Id: I154ec89ba6f9aa7cbe4053f6b7460fdd836bd90b
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel
---
M base/rs_glue/values_glue.h
1 file changed, 41 insertions(+), 21 deletions(-)
To view, visit change 3530066. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Add BASE_EXPORT to all glue functions in base::rs_glue.
These functions are used across components (from the Rust library)
so they need to be exported for component builds.
R=adet...@chromium.org
Bug: 1296156
Change-Id: I154ec89ba6f9aa7cbe4053f6b7460fdd836bd90b
Cq-Include-Trybots: luci.chromium.try:linux-rust-x64-rel,android-rust-arm-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3530066
Reviewed-by: Adrian Taylor <adet...@google.com>
Commit-Queue: danakj <dan...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981672}
---
M base/rs_glue/values_glue.h
1 file changed, 45 insertions(+), 21 deletions(-)