Remove ($host_toolchain) from proc-macro dependencies [chromium/src : main]

danakj (Gerrit)

unread,

Feb 25, 2022, 6:51:11 PM2/25/22

to rust...@chromium.org, Adrian Taylor, chromium...@chromium.org, Matthew Riley

Attention is currently required from: Adrian Taylor.

View Change

To view, visit change 3491581. To unsubscribe, or for help writing mail filters, visit settings.

Adrian Taylor (Gerrit)

unread,

Feb 25, 2022, 7:29:17 PM2/25/22

to danakj, rust...@chromium.org, chromium...@chromium.org, Matthew Riley

Attention is currently required from: danakj.

Patch set 2:Code-Review +1

View Change

To view, visit change 3491581. To unsubscribe, or for help writing mail filters, visit settings.

danakj (Gerrit)

unread,

Feb 28, 2022, 9:25:01 PM2/28/22

to rust...@chromium.org, Adrian Taylor, chromium...@chromium.org, Matthew Riley

Patch set 2:Commit-Queue +2

View Change

To view, visit change 3491581. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Feb 28, 2022, 10:02:40 PM2/28/22

to danakj, rust...@chromium.org, Adrian Taylor, chromium...@chromium.org, Matthew Riley

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Adrian Taylor: Looks good to me
  danakj: Commit

Remove ($host_toolchain) from proc-macro dependencies

In 98e07372d5b2306, we added forwarding to the host_toolchain through
a group for any proc-macro written with the rust_target GN template.

As cargo_crate uses rust_target, we now get the forwarding for free in
third_party/rust/ BUILD.gn files too, so remove support for generating
the ($host_toolchain) suffix in crates.py as well.

R=adet...@chromium.org

Bug: 1299883
Change-Id: I156d9f75fd092f0e3db8388b619c10a762c1096e
Cq-Include-Trybots: luci.chromium.try:android-rust-arm-rel,linux-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3491581
Reviewed-by: Adrian Taylor <adet...@chromium.org>
Commit-Queue: danakj <dan...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#976065}
---
M build/rust/rust_macro.gni
M third_party/rust/cxx/v1/BUILD.gn
M third_party/rust/serde/v1/BUILD.gn
M tools/crates/lib/common.py
M tools/crates/lib/common_test.py
M tools/crates/lib/gen.py
6 files changed, 34 insertions(+), 43 deletions(-)

To view, visit change 3491581. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward