Groups
Conversations
All groups and messages
Send feedback to Google
Help
Sign in
Groups
rust-dev
Conversations
About
rust-dev
1–30 of 48
Mark all as read
Report abusive group
0 selected
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
20
5/18/22
Add the most minimal possible ContentBrowserTest in Rust. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 12 is the latest approved patch-set. The change
unread,
Add the most minimal possible ContentBrowserTest in Rust. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 12 is the latest approved patch-set. The change
5/18/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
8
5/13/22
Support replacing the RustTest class and factory for Rust browser tests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 16 is the latest approved patch-set. The change
unread,
Support replacing the RustTest class and factory for Rust browser tests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 16 is the latest approved patch-set. The change
5/13/22
danakj (Gerrit)
6
5/13/22
Add the most basic possible ContentBrowserTest in Rust [chromium/src : main]
Attention is currently required from: Łukasz Anforowicz. View Change 1 comment: Patchset: Patch Set #
unread,
Add the most basic possible ContentBrowserTest in Rust [chromium/src : main]
Attention is currently required from: Łukasz Anforowicz. View Change 1 comment: Patchset: Patch Set #
5/13/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
17
5/12/22
Specify a Gtest factory by its typename, and give access to a wrapper [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 21 is the latest approved patch-set. The change
unread,
Specify a Gtest factory by its typename, and give access to a wrapper [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 21 is the latest approved patch-set. The change
5/12/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
7
4/1/22
Allow a #[gtest] test to specify a C++ class for its TestSuite. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Łukasz Anforowicz: Looks good to me
unread,
Allow a #[gtest] test to specify a C++ class for its TestSuite. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Łukasz Anforowicz: Looks good to me
4/1/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
4
3/31/22
Fix test generated crate roots when modules have `..` path components [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
unread,
Fix test generated crate roots when modules have `..` path components [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
3/31/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
3
3/30/22
Propagate rs_public_deps to the rust_target.gni's rlib. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
unread,
Propagate rs_public_deps to the rust_target.gni's rlib. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
3/30/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
7
3/17/22
Use -Zremap-cwd-prefix to remove the cwd from Rust outputs [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 2 is the latest approved patch-set. No files were
unread,
Use -Zremap-cwd-prefix to remove the cwd from Rust outputs [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 2 is the latest approved patch-set. No files were
3/17/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
5
3/16/22
Add BASE_EXPORT to all glue functions in base::rs_glue. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 1 is the latest approved patch-set. No files were
unread,
Add BASE_EXPORT to all glue functions in base::rs_glue. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 1 is the latest approved patch-set. No files were
3/16/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
16
3/15/22
Allow Rust to provide a different testing::Test subclass for a Gtest. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 7 is the latest approved patch-set. No files were
unread,
Allow Rust to provide a different testing::Test subclass for a Gtest. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 7 is the latest approved patch-set. No files were
3/15/22
danakj (Gerrit)
, …
LUCI CQ (Gerrit)
11
3/10/22
Add debug Rust trybots. [chromium/tools/build : main]
LUCI CQ submitted this change. View Change Approvals: Garrett Beaty: Looks good to me danakj: Commit
unread,
Add debug Rust trybots. [chromium/tools/build : main]
LUCI CQ submitted this change. View Change Approvals: Garrett Beaty: Looks good to me danakj: Commit
3/10/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
16
3/10/22
Generate Rust crate roots for test() targets. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 7 is the latest approved patch-set. The change
unread,
Generate Rust crate roots for test() targets. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 7 is the latest approved patch-set. The change
3/10/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
5
3/9/22
Remove extern crate linking workaround in mojo. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. No files were
unread,
Remove extern crate linking workaround in mojo. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. No files were
3/9/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
7
3/9/22
Rename and invert skip_unit_tests to build_native_rust_unit_tests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. The change
unread,
Rename and invert skip_unit_tests to build_native_rust_unit_tests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. The change
3/9/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
5
3/9/22
Remove _rs suffix from mixed target Rust crates. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 2 is the latest approved patch-set. The change
unread,
Remove _rs suffix from mixed target Rust crates. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 2 is the latest approved patch-set. The change
3/9/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
15
3/9/22
Move tests for the base crate into base_unittests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 17 is the latest approved patch-set. The change
unread,
Move tests for the base crate into base_unittests [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 17 is the latest approved patch-set. The change
3/9/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
6
3/8/22
Define a public API in the base (currently "base_rs") crate. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. The change
unread,
Define a public API in the base (currently "base_rs") crate. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 3 is the latest approved patch-set. The change
3/8/22
danakj (Gerrit)
, …
Łukasz Anforowicz (Gerrit)
11
3/8/22
Support GN public_deps for the Rust part of a mixed C++-Rust target [chromium/src : main]
View Change 1 comment: File build/rust/mixed_target.gni: Patch Set #5, Line 135: } Right - `
unread,
Support GN public_deps for the Rust part of a mixed C++-Rust target [chromium/src : main]
View Change 1 comment: File build/rust/mixed_target.gni: Patch Set #5, Line 135: } Right - `
3/8/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
6
3/7/22
Reorganize and simplify mixed_target and rust_target interactions. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 10 is the latest approved patch-set. The change
unread,
Reorganize and simplify mixed_target and rust_target interactions. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 10 is the latest approved patch-set. The change
3/7/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
7
3/7/22
Make the cxx_cppdeps target a static_library [chromium/src : main]
Patch set 3:Commit-Queue +2 View Change To view, visit change 3502673. To unsubscribe, or for help
unread,
Make the cxx_cppdeps target a static_library [chromium/src : main]
Patch set 3:Commit-Queue +2 View Change To view, visit change 3502673. To unsubscribe, or for help
3/7/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
5
3/4/22
Put gtest_rust_interop into a static library. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Łukasz Anforowicz: Looks good to me;
unread,
Put gtest_rust_interop into a static library. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Łukasz Anforowicz: Looks good to me;
3/4/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
12
3/4/22
Allow multiple Cargo build targets with different configurations [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me Adrian
unread,
Allow multiple Cargo build targets with different configurations [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me Adrian
3/4/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
9
3/4/22
Add //testing/rust_gtest_interop when //testing/gtest is in deps [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Ben Pastene: Looks good to me danakj:
unread,
Add //testing/rust_gtest_interop when //testing/gtest is in deps [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Ben Pastene: Looks good to me danakj:
3/4/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
6
3/1/22
Avoid generating LTO bitcode in rust objects when it's incompatible [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me danakj:
unread,
Avoid generating LTO bitcode in rust objects when it's incompatible [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me danakj:
3/1/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
10
3/1/22
Use codegen-units=1 in official builds. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me danakj:
unread,
Use codegen-units=1 in official builds. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Nico Weber: Looks good to me danakj:
3/1/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
6
3/1/22
Support all combination of static/shared libraries with Rust [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 14 is the latest approved patch-set. The change
unread,
Support all combination of static/shared libraries with Rust [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 14 is the latest approved patch-set. The change
3/1/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
4
2/28/22
Remove ($host_toolchain) from proc-macro dependencies [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me danakj
unread,
Remove ($host_toolchain) from proc-macro dependencies [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me danakj
2/28/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
4
2/24/22
Leave a TODO breadcrumb to the GN bug about missing --extern proc_macro [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
unread,
Leave a TODO breadcrumb to the GN bug about missing --extern proc_macro [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change Approvals: Adrian Taylor: Looks good to me;
2/24/22
danakj (Gerrit)
, …
Chromium LUCI CQ (Gerrit)
16
2/24/22
Add support for Android mixed-C++/Rust unit tests. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 8 is the latest approved patch-set. The change
unread,
Add support for Android mixed-C++/Rust unit tests. [chromium/src : main]
Chromium LUCI CQ submitted this change. View Change 8 is the latest approved patch-set. The change
2/24/22
Dana Jansens
2/24/22
URLs in Rust
An open design question here for the taking if anyone is interested: https://bugs.chromium.org/p/
unread,
URLs in Rust
An open design question here for the taking if anyone is interested: https://bugs.chromium.org/p/
2/24/22