Fail to run clang-tidy after switching to reclient

[Yeunjoo Choi]

Hi!

I run clang-tidy on Chromium [1] and the script for clang-tidy fails
with this error after switching to reclient from goma:


F1206 15:06:04.439743 893837 main.go:174] Command failed: dial_timeout of 10m0s expired before being able to connect to reproxy


This failure is fixed once I changed the script to use autoninja
instead of ninja as below.


diff --git
a/recipes/recipe_modules/tricium_clang_tidy/resources/tricium_clang_tid
y_script.py
b/recipes/recipe_modules/tricium_clang_tidy/resources/tricium_clang_tid
y_script.py
index 24440ca2b2..9b57a038b7 100755
---
a/recipes/recipe_modules/tricium_clang_tidy/resources/tricium_clang_tid
y_script.py
+++
b/recipes/recipe_modules/tricium_clang_tidy/resources/tricium_clang_tid
y_script.py
@@ -122,7 +122,7 @@ def _run_ninja(out_dir: str,
# 500 targets per invocation is arbitrary, but we start hitting OS
argv size
# limits around 1K in my experience.
def make_ninja_command(targets):
- ninja_cmd = ['ninja', '-k', '1000000']
+ ninja_cmd = ['autoninja', '-k', '1000000']
if jobs is not None:
ninja_cmd.append('-j%d' % jobs)


I think that it should be fixed.

Best regards,
Yeunjoo.

[1]
https://chromium.googlesource.com/chromium/src/+/main/docs/clang_tidy.md

[Takuto Ikuta (生田 拓人)]

Hi Yeunjoo,

We are not maintainers of the script.

But I think you can send a CL if that fixed the problem.

Also see https://chromium.googlesource.com/chromium/src/+/main/docs/clang_tidy.md#questions

--
You received this message because you are subscribed to the Google Groups "reclient-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reclient-user...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/reclient-users/fad54eb0f97fddfcd62d47492418e0199976a388.camel%40igalia.com.

--

Takuto Ikuta

Software Engineer in Tokyo

Chrome Ops (chrome browser build team)