Changing Auto-Formatters

[Andrew Grieve]

Google's just released a fork of Black, which looks like it would work well for us:

https://github.com/google/pyink

I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1377174 to look at switching to it in case anyone wants to take a crack at it.

[Nico Weber]

Seems like a bunch of churn. Are the benefits really big enough?

--
You received this message because you are subscribed to the Google Groups "python" group.
To unsubscribe from this group and stop receiving emails from it, send an email to python+un...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/python/CABiQX1XvJqZDVC2Qh7z-qyeD22SAGxvNS9G48XO02_51S1LF2w%40mail.gmail.com.

[Andrew Grieve]

I think it's at least worth investigating. If it normalizes quotes within a file, it will pay for itself.

[Mike Frysinger]

CrOS switched to black and just reformatted things.  it's a one-off churn, but there really isn't any reasonable alternative out there.  yapf is dead.

-mike

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/python/CABiQX1VQ%3DEg93Lk%3DaPEc7BYK_gJkiQw2s5%3DO6GiAg5NtujTq%3DQ%40mail.gmail.com.

[Philipp Wollermann]

I found this thread when I was frustrated with the behavior of the current YAPF autoformatter while contributing to the Python files in our infra repository.

I added a comment on Andrew's bug with some reasoning why I think we should move to Black, so that we can get fully deterministic auto-formatting for our Python code.

How can we reach consensus here? I'm willing to volunteer and invest time into whatever is necessary to make it happen.

Cheers,

Philipp

[Andrew Grieve]

Let's consolidate conversation on this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1377174

[Dirk Pranke]

On Tue, Oct 10, 2023 at 10:25 PM 'Philipp Wollermann' via python <pyt...@chromium.org> wrote:

I found this thread when I was frustrated with the behavior of the current YAPF autoformatter while contributing to the Python files in our infra repository.

I added a comment on Andrew's bug with some reasoning why I think we should move to Black, so that we can get fully deterministic auto-formatting for our Python code.

How can we reach consensus here? I'm willing to volunteer and invest time into whatever is necessary to make it happen.

Put together a proposal for it that'll include what sorts of formatting will change and how we might want to handle mass reformats and different parts of the codebase having different style guide settings, I think.

-- Dirk

Cheers,

Philipp

On Monday, November 28, 2022 at 9:58:38 PM UTC+9 vap...@chromium.org wrote:

CrOS switched to black and just reformatted things.  it's a one-off churn, but there really isn't any reasonable alternative out there.  yapf is dead.

-mike

On Fri, Oct 21, 2022 at 10:44 PM 'Andrew Grieve' via python <pyt...@chromium.org> wrote:

I think it's at least worth investigating. If it normalizes quotes within a file, it will pay for itself.

On Fri, Oct 21, 2022 at 8:24 AM Nico Weber <tha...@chromium.org> wrote:

Seems like a bunch of churn. Are the benefits really big enough?

On Thu, Oct 20, 2022 at 10:19 PM 'Andrew Grieve' via python <pyt...@chromium.org> wrote:

Google's just released a fork of Black, which looks like it would work well for us:

https://github.com/google/pyink

I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1377174 to look at switching to it in case anyone wants to take a crack at it.

--
You received this message because you are subscribed to the Google Groups "python" group.
To unsubscribe from this group and stop receiving emails from it, send an email to python+un...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/python/CABiQX1XvJqZDVC2Qh7z-qyeD22SAGxvNS9G48XO02_51S1LF2w%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "python" group.
To unsubscribe from this group and stop receiving emails from it, send an email to python+un...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/python/CABiQX1VQ%3DEg93Lk%3DaPEc7BYK_gJkiQw2s5%3DO6GiAg5NtujTq%3DQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "python" group.
To unsubscribe from this group and stop receiving emails from it, send an email to python+un...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/python/47f90598-f0be-48d3-b924-3b168469768en%40chromium.org.