EnqueueLaunchParams in navigation_capturing_redirection_throttle.cc

[Lu Huang]

I see EnqueueLaunchParams being used in navigation_capturing_redirection_throttle.cc. Is there any intersection between launches that have filepaths for file handling in launch params and navigations that are handled here and reach this condition? If so, would the filepaths get dropped?

Lu

[Daniel Murphy]

Hey Lu, this is a great question.

Right now there are two paths for web app navigation capturing and launch - you noticed them both, the navigation capturing / browser_navigator.cc pipeline, and the WebAppLaunchProcess (called from startup, file handling, intent picker icon pipelines). We really want to unify this code, and ideally unify it into the browser_navigator.cc call stack /pipeline. Now that navigation capturing is essentially code-complete, @Marijn Kruisselbrink  is owning the holistic look at code cleanup / refactorings / etc.

Umbrella bug: https://issues.chromium.org/380071069 Navigation Capturing V2: Code Cleanup Phase #keyresult

Relevant bug: https://issues.chromium.org/355503067 Unify browser_navigator and WebAppLaunchProcess code.

Currently we're in the 'poke around, prototype, and see what exactly the end state we want' phase, and depending on the work to get there, @Marijn Kruisselbrink may be splitting off tasks to help parallelize that work.

> Is there any intersection between launches that have filepaths for file handling in launch params and navigations that are handled here and reach this condition? If so, would the filepaths get dropped?

All file launches should currently go through the WebAppLaunchProcess, so there is no risk of files being dropped here. If we end up unifying, I imagine those file paths will be added to navigate_params.h

Dan

[Lu Huang]

Thanks for confirming that file paths won't be dropped as they're two completely separate launch flows. Unification does seem desirable here.