buildbot warning in chromium.fyi on Browser Side Navigation Linux, revision 3ca12c8595fbba80d9e2b6acd06e211243b62838

[buil...@chromium-build.appspotmail.com]

https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "bot_update" on "Browser Side Navigation Linux"

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/39564

Revision: 3ca12c8595fbba80d9e2b6acd06e211243b62838, 35b3464dccd14d07d154bd660adc9a608ed5bd5c
Blame list: mich...@chromium.org,w...@chromium.org

Build 39564

running steps via annotated script preamble stdio

update_scripts stdio gclient_json build: 70ac83b12e249bbb3903ee55b98ade45e75055fe..f17e559a60a58b9c18dee167777d97caf2cfc14e depot_tools: f438ff743a4b157b9be8cecefa7a170f9695d185

LUCI Migration stdio

LogDog Bootstrap stdio

setup_build<br>running recipe: "chromium" stdout run_recipe

makedirs checkout path stdout

bot_update stdout

Changed by: mich...@chromium.org
Changed at: Sat 24 Feb 2018 15:41:47
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 3ca12c8595fbba80d9e2b6acd06e211243b62838
Changed files:

• chrome/browser/ui/browser_list.cc
• chrome/browser/ui/browser_list.h
• chrome/browser/ui/cocoa/browser_window_controller.mm
• chrome/browser/ui/views/frame/browser_view.cc
• chrome/test/base/test_browser_window_aura.cc

Comments:

Don't set active browser until browser window exists

BrowserView should not call BrowserList::SetLastActive(Browser* browser)
before the Browser's |window_| is set. This can currently happen if a
BrowserView's widget receives an activation event before
CreateBrowserWindow() returns. This also means SetLastActive is called
before the Browser adds itself to the BrowserList.

Since Browser only calls BrowserList::AddBrowser() after the Browser and
BrowserWindow have been initialized, it's safe for BrowserList to check
whether the window is active for itself and, if so, call SetLastActive()
when the browser is added.

Bug: 811243,811191
Change-Id: I621238e942ab689fdbfe00b1776957477a7b0c4e
Reviewed-on: https://chromium-review.googlesource.com/915202
Reviewed-by: Scott Violet <s...@chromium.org>
Commit-Queue: Michael Giuffrida <mich...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539024}

Properties:

• git_revision: 3ca12c8595fbba80d9e2b6acd06e211243b62838
  

Changed by: w...@chromium.org
Changed at: Sat 24 Feb 2018 15:49:27
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 35b3464dccd14d07d154bd660adc9a608ed5bd5c
Changed files:

• testing/buildbot/filters/fuchsia.base_unittests.filter

Comments:

Broaden test filter for TaskSchedulerWorkerPoolHistogramTests.

These tests rely on thread sleeps for synchronization, which makes them
racey when run on heavily-loaded systems.

TBR: scottmg
Bug: 816170, 735701
Change-Id: I9cad471cf8bc88fd91dc33662489983f13f18786
Reviewed-on: https://chromium-review.googlesource.com/936446
Reviewed-by: Wez <w...@chromium.org>
Commit-Queue: Wez <w...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539025}

Properties:

• git_revision: 35b3464dccd14d07d154bd660adc9a608ed5bd5c