buildbot warning in chromium.fyi on Browser Side Navigation Linux, revision ebe81fb2176162e2dedb40b35c8436bdd374a2aa

0 views

Skip to first unread message

buil...@chromium-build.appspotmail.com

unread,

Feb 23, 2018, 6:11:15 PM2/23/18

to plzna...@chromium.org, gateke...@chromium-gatekeeper-sentry.appspotmail.com

https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "bot_update" on "Browser Side Navigation Linux"

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/39537

Revision: 6200d332518cd781f87ab86554bc71ff7a01ec4e, 014e076d250cf927f507e10b2b15aa74bf8d4d42, ebe81fb2176162e2dedb40b35c8436bdd374a2aa, b9cb2eefaa8f7bb0a16ebb3d0571591d514fadcc, cea91b394645b8fe0c178a348dcdcc69bf734566, c8f1c3ce109a1ac34f904e4c5a01664998a2d032, 1f60491ddacfe9d24edd2fe5204677af29dfb71c, 4a85b9e4ce04d6e3a86b208a79e27e84c1c96cff, 71cf88f883de16a76e184fb74c2923fdb724ac78, da0ed206f6490a5c63cefd74e440755fe33f7476, 68686b7484b91e04f132987f455943ca00339834, a721b029b31640e26db86b12f9e5fd149e19aefb, 5db6e915a8cdcdda4500934959bff3d77d56fff7, 008b4ee236811270f8d5d430dd5de9e79f978235
Blame list: ato...@chromium.org,dan...@chromium.org,eri...@chromium.org,hua...@chromium.org,jame...@chromium.org,jbud...@chromium.org,jon...@chromium.org,qin...@chromium.org,riaj...@chromium.org,s...@chromium.org,tdre...@chromium.org,tha...@chromium.org,twell...@chromium.org,zho...@chromium.org

Build 39537

running steps via annotated script
preamble
stdio

update_scripts
stdio
gclient_json
depot_tools: f9648b5c7cf801b45bbdc0bf2d7dc71e4f047584
build: 4080f7182d16839c2af69fb9b35c3c347a771e14

LUCI Migration
stdio

LogDog Bootstrap
stdio

setup_build<br>running recipe: "chromium"
stdout
run_recipe

makedirs checkout path
stdout

bot_update
stdout

Changed by: s...@chromium.org
Changed at: Fri 23 Feb 2018 13:29:23
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 6200d332518cd781f87ab86554bc71ff7a01ec4e
Changed files:

build/linux/unbundle/ffmpeg.gn
chrome/BUILD.gn
chrome/app/chrome_main.cc
chrome/app/chrome_main_delegate.cc
chrome/browser/about_flags.cc
chrome/browser/browser_process_impl.cc
chrome/browser/browser_process_impl.h
chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
chrome/browser/browsing_data/navigation_entry_remover.cc
chrome/browser/chrome_browser_main.cc
chrome/browser/chrome_content_browser_client.cc
chrome/browser/devtools/device/devtools_android_bridge.cc
chrome/browser/download/chrome_download_manager_delegate.cc
chrome/browser/download/chrome_download_manager_delegate_unittest.cc
chrome/browser/download/download_path_reservation_tracker.cc
chrome/browser/download/download_target_determiner_unittest.cc
chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
chrome/browser/extensions/browser_context_keyed_service_factories.cc
chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
chrome/browser/extensions/component_loader.cc
chrome/browser/extensions/extension_service.cc
chrome/browser/extensions/extension_service_sync_unittest.cc
chrome/browser/extensions/extension_sync_service.cc
chrome/browser/extensions/external_component_loader.cc
chrome/browser/flag_descriptions.h
chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
chrome/browser/interstitials/chrome_metrics_helper.cc
chrome/browser/interstitials/chrome_metrics_helper.h
chrome/browser/io_thread.h
chrome/browser/lifetime/application_lifetime.cc
chrome/browser/lifetime/browser_close_manager.cc
chrome/browser/lifetime/browser_close_manager_browsertest.cc
chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
chrome/browser/metrics/chrome_metrics_service_accessor.cc
chrome/browser/metrics/chrome_metrics_service_client.cc
chrome/browser/metrics/tab_stats_tracker.cc
chrome/browser/net/chrome_network_delegate.cc
chrome/browser/notifications/notification_display_service_factory.cc
chrome/browser/notifications/notification_platform_bridge_mac.mm
chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
chrome/browser/notifications/platform_notification_service_impl.cc
chrome/browser/notifications/platform_notification_service_impl.h
chrome/browser/permissions/permission_manager.cc
chrome/browser/platform_util.h
chrome/browser/plugins/plugin_info_host_impl.cc
chrome/browser/plugins/plugin_infobar_delegates.cc
chrome/browser/plugins/plugin_infobar_delegates.h
chrome/browser/plugins/plugin_observer.cc
chrome/browser/plugins/plugin_observer.h
chrome/browser/policy/configuration_policy_handler_list_factory.cc
chrome/browser/prefs/browser_prefs.cc
chrome/browser/prefs/chrome_pref_service_factory.cc
chrome/browser/profiles/avatar_menu.cc
chrome/browser/profiles/avatar_menu.h
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
chrome/browser/profiles/off_the_record_profile_impl.cc
chrome/browser/profiles/profile.cc
chrome/browser/profiles/profile_impl.cc
chrome/browser/profiles/profile_impl.h
chrome/browser/profiles/profile_info_cache.cc
chrome/browser/profiles/profile_io_data.cc
chrome/browser/profiles/profile_io_data.h
chrome/browser/profiles/profile_manager.cc
chrome/browser/profiles/profile_manager.h
chrome/browser/push_messaging/push_messaging_browsertest.cc
chrome/browser/push_messaging/push_messaging_service_impl.cc
chrome/browser/push_messaging/push_messaging_service_impl.h
chrome/browser/sessions/better_session_restore_browsertest.cc
chrome/browser/sessions/session_tab_helper.h
chrome/browser/shell_integration_linux.cc
chrome/browser/shell_integration_linux.h
chrome/browser/signin/chrome_signin_client.cc
chrome/browser/speech/tts_android.cc
chrome/browser/ssl/captive_portal_blocking_page.h
chrome/browser/ssl/ssl_error_assistant.cc
chrome/browser/ssl/ssl_error_handler.cc
chrome/browser/ssl/ssl_error_handler_unittest.cc
chrome/browser/supervised_user/supervised_users.h
chrome/browser/sync/chrome_sync_client.cc
chrome/browser/sync/profile_sync_service_factory_unittest.cc
chrome/browser/sync/supervised_user_signin_manager_wrapper.cc
chrome/browser/themes/theme_properties.h
chrome/browser/themes/theme_service.cc
chrome/browser/themes/theme_service.h
chrome/browser/themes/theme_service_unittest.cc
chrome/browser/ui/BUILD.gn
chrome/browser/ui/apps/app_info_dialog.h
chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
chrome/browser/ui/browser_browsertest.cc
chrome/browser/ui/browser_commands.cc
chrome/browser/ui/browser_window.h
chrome/browser/ui/cocoa/browser_window_cocoa.h
chrome/browser/ui/cocoa/browser_window_cocoa.mm
chrome/browser/ui/libgtkui/BUILD.gn
chrome/browser/ui/passwords/manage_passwords_ui_controller.h
chrome/browser/ui/startup/startup_browser_creator.cc
chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
chrome/browser/ui/tab_helpers.cc
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.h
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
chrome/browser/ui/views/frame/browser_view.h
chrome/browser/ui/webui/browsing_history_handler.cc
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
chrome/browser/ui/webui/extensions/extension_settings_handler.cc
chrome/browser/ui/webui/interstitials/interstitial_ui.cc
chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
chrome/browser/ui/webui/ntp/app_launcher_handler.cc
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
chrome/browser/ui/webui/print_preview/print_preview_handler.cc
chrome/browser/ui/webui/print_preview/print_preview_handler.h
chrome/browser/ui/webui/print_preview/printer_handler.cc
chrome/browser/ui/webui/print_preview/printer_handler.h
chrome/browser/ui/webui/signin/md_user_manager_ui.cc
chrome/browser/ui/webui/signin/md_user_manager_ui.h
chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
chrome/browser/ui/webui/signin/signin_create_profile_handler.h
chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
chrome/child/BUILD.gn
chrome/common/BUILD.gn
chrome/common/chrome_content_client.h
chrome/common/chrome_features.h
chrome/common/chrome_paths.cc
chrome/common/chrome_switches.h
chrome/common/pref_names.cc
chrome/common/pref_names.h
chrome/common/render_messages.h
chrome/common/url_constants.h
chrome/common/webui_url_constants.h
chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/plugins/chrome_plugin_placeholder.cc
chrome/renderer/plugins/chrome_plugin_placeholder.h
chrome/test/base/in_process_browser_test.cc
chrome/test/base/test_browser_window.h
chrome/test/base/testing_browser_process.cc
chrome/test/base/testing_profile.cc
chrome/utility/chrome_content_utility_client.cc
chromecast/BUILD.gn
chromecast/DEPS
chromecast/android/BUILD.gn
chromecast/app/BUILD.gn
chromecast/app/cast_main_delegate.cc
chromecast/base/BUILD.gn
chromecast/base/cast_paths.cc
chromecast/base/init_command_line_shlib.cc
chromecast/browser/BUILD.gn
chromecast/browser/cast_browser_main_parts.cc
chromecast/browser/cast_browser_main_parts.h
chromecast/browser/cast_content_browser_client.h
chromecast/browser/cast_media_blocker_browsertest.cc
chromecast/browser/cast_web_contents_manager.cc
chromecast/browser/cast_web_view_default.cc
chromecast/browser/cast_web_view_factory.cc
chromecast/browser/pref_service_helper.cc
chromecast/browser/test/cast_navigation_browsertest.cc
chromecast/browser/url_request_context_factory.cc
chromecast/common/BUILD.gn
chromecast/common/cast_content_client.cc
chromecast/media/cma/backend/BUILD.gn
chromecast/media/cma/backend/alsa/BUILD.gn
chromecast/media/cma/backend/alsa/alsa_wrapper.cc
chromecast/media/cma/backend/android/BUILD.gn
chromecast/media/cma/backend/android/cast_media_android.cc
chromecast/media/cma/backend/android/volume_control_android.cc
chromecast/media/cma/backend/audio_decoder_for_mixer.cc
chromecast/media/cma/backend/media_pipeline_backend_manager.cc
chromecast/media/cma/backend/volume_control.cc
chromecast/media/cma/pipeline/BUILD.gn
chromecast/media/cma/pipeline/media_pipeline_impl.cc
chromecast/net/BUILD.gn
chromecast/net/connectivity_checker_impl.cc
chromecast/renderer/BUILD.gn
chromecast/renderer/cast_content_renderer_client.h
chromecast/renderer/media/BUILD.gn
chromecast/renderer/media/key_systems_cast.cc
chromeos/assistant/BUILD.gn
ui/ozone/platform/cast/BUILD.gn
ui/ozone/platform/cast/DEPS
ui/ozone/platform/cast/ozone_platform_cast.cc

Comments:

reland: Rename buildflag_headers for consistency

This renames targets in chrome, chromecast and chromeos.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=tha...@chromium.org,dch...@chromium.org

Change-Id: I35f82bb244d2f8bd745d3157f266bae99f21f888
Reviewed-on: https://chromium-review.googlesource.com/935296
Reviewed-by: Scott Violet <s...@chromium.org>
Commit-Queue: Scott Violet <s...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538905}

Properties:

git_revision: 6200d332518cd781f87ab86554bc71ff7a01ec4e

Changed by: tha...@chromium.org
Changed at: Fri 23 Feb 2018 13:39:09
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 014e076d250cf927f507e10b2b15aa74bf8d4d42
Changed files:

DEPS

Comments:

Roll src/third_party/openmax_dl/ b611996df..63d8cf470 (2 commits)

https://webrtc.googlesource.com/deps/third_party/openmax.git/+log/b611996df3b8..63d8cf4708c9

$ git log b611996df..63d8cf470 --date=short --no-merges --format='%ad %ae %s'
63d8cf4 Remove gyp files from openmax_dl.
a661346 Make `git cl upload` work again in third_party/openmax_dl.

Created with:
  roll-dep src/third_party/openmax_dl

Bug: none
Change-Id: I73d42f9a2e50e60c259fffd7825f185ede924aa6
Reviewed-on: https://chromium-review.googlesource.com/934428
Commit-Queue: Nico Weber <tha...@chromium.org>
Reviewed-by: Raymond Toy <rt...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538906}

Properties:

git_revision: 014e076d250cf927f507e10b2b15aa74bf8d4d42

Changed by: jbud...@chromium.org
Changed at: Fri 23 Feb 2018 13:41:01
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: ebe81fb2176162e2dedb40b35c8436bdd374a2aa
Changed files:

testing/buildbot/chromium.fyi.json
testing/buildbot/waterfalls.pyl
tools/mb/mb_config.pyl

Comments:

Add build and test configuration for new Blink Heap Incremental Marking bot.

Bug: 812533
Change-Id: I117efbfa67d65995b21530a0aa5532fa60b42cf5
Reviewed-on: https://chromium-review.googlesource.com/934622
Reviewed-by: Stephen Martinis <mart...@chromium.org>
Commit-Queue: John Budorick <jbud...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538907}

Properties:

git_revision: ebe81fb2176162e2dedb40b35c8436bdd374a2aa

Changed by: jon...@chromium.org
Changed at: Fri 23 Feb 2018 13:48:27
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: b9cb2eefaa8f7bb0a16ebb3d0571591d514fadcc
Changed files:

testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Comments:

Re-enable fixed tests on FYI bot

Re-enable tests that were broken from FrameWatcher on Viz. They seem fine, but
checking on FYI first to confirm no flakes

TBR=kyle...@chromium.org
TEST=NonBlockingEventBrowserTest, TouchActionBrowserTest

Bug: 785013
Change-Id: Ie263e1cf41556ce1c606d1ef6ecc887d990b926c
Reviewed-on: https://chromium-review.googlesource.com/935495
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538908}

Properties:

git_revision: b9cb2eefaa8f7bb0a16ebb3d0571591d514fadcc

Changed by: ato...@chromium.org
Changed at: Fri 23 Feb 2018 13:49:02
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: cea91b394645b8fe0c178a348dcdcc69bf734566
Changed files:

third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Comments:

[LayoutNG] Renable DCHECK

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7f5f9420a4836606e0768e9ad12440e251294c19
Reviewed-on: https://chromium-review.googlesource.com/935283
Reviewed-by: Christian Biesinger <cbies...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Commit-Queue: Aleks Totic <ato...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538909}

Properties:

git_revision: cea91b394645b8fe0c178a348dcdcc69bf734566

Changed by: twell...@chromium.org
Changed at: Fri 23 Feb 2018 13:50:50
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: c8f1c3ce109a1ac34f904e4c5a01664998a2d032
Changed files:

chrome/android/java/res/layout/content_suggestions_action_card_modern.xml
chrome/android/java/res/layout/content_suggestions_all_dismissed_card_modern.xml
chrome/android/java/res/layout/personalized_signin_promo_view_modern_content_suggestions.xml
chrome/android/java/res/values/dimens.xml
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
chrome/android/java/strings/android_chrome_strings.grd

Comments:

[Modern] More NTP polish

 * Fix all dismissed item
 * Adjust margin above "More" button
 * Adjust margin above sign-in promo
 * Adjust padding at top of most likely tiles

 BUG=803095,814073

Change-Id: I85f1bc682bfe8f23ee52438d85e9ee98fcb7970f
Reviewed-on: https://chromium-review.googlesource.com/935151
Reviewed-by: Ted Choc <ted...@chromium.org>
Commit-Queue: Theresa <twell...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538910}

Properties:

git_revision: c8f1c3ce109a1ac34f904e4c5a01664998a2d032

Changed by: eri...@chromium.org
Changed at: Fri 23 Feb 2018 13:53:43
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 1f60491ddacfe9d24edd2fe5204677af29dfb71c
Changed files:

cc/trees/layer_tree_host_impl.h

Comments:

Remove unused LocalSurfaceId

Whle reading through the code, noticed this was entirely unused.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iacb86674e3003ee12b44b6261b1dfa01086f7ba2
Reviewed-on: https://chromium-review.googlesource.com/934961
Reviewed-by: Chris Blume <cbl...@chromium.org>
Commit-Queue: Eric Karl <eri...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538911}

Properties:

git_revision: 1f60491ddacfe9d24edd2fe5204677af29dfb71c

Changed by: tdre...@chromium.org
Changed at: Fri 23 Feb 2018 13:59:39
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 4a85b9e4ce04d6e3a86b208a79e27e84c1c96cff
Changed files:

third_party/WebKit/Source/core/timing/MemoryInfo.cpp
third_party/WebKit/Source/core/timing/MemoryInfo.h
third_party/WebKit/Source/core/timing/MemoryInfo.idl
third_party/WebKit/Source/core/timing/MemoryInfoTest.cpp

Comments:

Revert "Do not return heap size if there are multiple tabs in the same process"

This reverts commit 0edfddf21400c8b9b9de490f03f7fe018c5f3135.

Reason for revert: Postponing change to get additional feedback from folks who consume this API.

Original change's description:
> Do not return heap size if there are multiple tabs in the same process
> 
> This CL changes MemoryInfo so that, when the heap statistics are calculated, the
> values for totalJSHeapSize and usedJSHeapSize are not used if the number
...skip...
Commit-Position: refs/heads/master@{#536755}

TBR=har...@chromium.org,tdre...@chromium.org,n...@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 807651
Change-Id: I2897517db42c1c46af0ddeb16e190e4bb37d5884
Reviewed-on: https://chromium-review.googlesource.com/935501
Reviewed-by: Timothy Dresser <tdre...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Commit-Queue: Timothy Dresser <tdre...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538912}

Properties:

git_revision: 4a85b9e4ce04d6e3a86b208a79e27e84c1c96cff

Changed by: zho...@chromium.org
Changed at: Fri 23 Feb 2018 14:00:47
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 71cf88f883de16a76e184fb74c2923fdb724ac78
Changed files:

net/quic/core/quic_connection.cc
net/quic/core/quic_connection.h
net/quic/core/quic_connection_test.cc

Comments:

relnote: Separate out the connection probing detection logic into its own
function. Not flag protected.

Manually merge internal change: 185377552

Change-Id: I16b4c35e94d7fbeb257834c58aee7cd2e6316148
Reviewed-on: https://chromium-review.googlesource.com/933246
Commit-Queue: Zhongyi Shi <zho...@chromium.org>
Reviewed-by: Ryan Hamilton <r...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538913}

Properties:

git_revision: 71cf88f883de16a76e184fb74c2923fdb724ac78

Changed by: qin...@chromium.org
Changed at: Fri 23 Feb 2018 14:00:53
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: da0ed206f6490a5c63cefd74e440755fe33f7476
Changed files:

components/download/internal/common/BUILD.gn
components/download/internal/common/DEPS
components/download/internal/common/download_stats.cc
components/download/internal/common/download_stats_unittest.cc
components/download/internal/common/download_ukm_helper.cc
components/download/internal/common/download_ukm_helper_unittest.cc
components/download/public/common/BUILD.gn
components/download/public/common/download_stats.h
components/download/public/common/download_ukm_helper.h
content/browser/BUILD.gn
content/browser/download/base_file.cc
content/browser/download/base_file_win.cc
content/browser/download/download_file_impl.cc
content/browser/download/download_item_impl.cc
content/browser/download/download_job_factory.cc
content/browser/download/download_manager_impl.cc
content/browser/download/download_request_core.cc
content/browser/download/download_resource_handler.cc
content/browser/download/download_response_handler.cc
content/browser/download/download_utils.cc
content/browser/download/drag_download_file.cc
content/browser/download/parallel_download_job.cc
content/browser/download/save_package.cc
content/browser/download/url_download_handler.h
content/browser/frame_host/render_frame_message_filter.cc
content/browser/loader/mime_sniffing_resource_handler.cc
content/browser/loader/navigation_url_loader_network_service.cc
content/browser/renderer_host/render_message_filter.cc
content/browser/web_contents/web_contents_impl.cc
content/test/BUILD.gn
services/metrics/public/cpp/ukm_recorder.h

Comments:

move DownloadStats and DownloadUkmHelper to components/download

These 2 classes are needed for reporting UMA/UKM stats
And should be moved to the components/download

BUG=803135

Change-Id: I9ce2459a6bfd44c8c16ec0d31a5b06fba37b5f58
Reviewed-on: https://chromium-review.googlesource.com/924275
Commit-Queue: Min Qin <qin...@chromium.org>
Reviewed-by: John Abd-El-Malek <j...@chromium.org>
Reviewed-by: David Trainor <dtra...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538914}

Properties:

git_revision: da0ed206f6490a5c63cefd74e440755fe33f7476

Changed by: jame...@chromium.org
Changed at: Fri 23 Feb 2018 14:09:37
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 68686b7484b91e04f132987f455943ca00339834
Changed files:

ui/chromeos/OWNERS

Comments:

Fix bad path in //ui/chromeos/OWNERS

It refers to a missing file, which causes presubmit upload failures.

TBR=wu...@chromium.org

Bug: none
Change-Id: I18f9d94d233878c1ce130224859d58e175522e49
Reviewed-on: https://chromium-review.googlesource.com/935628
Reviewed-by: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538915}

Properties:

git_revision: 68686b7484b91e04f132987f455943ca00339834

Changed by: dan...@chromium.org
Changed at: Fri 23 Feb 2018 14:11:11
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: a721b029b31640e26db86b12f9e5fd149e19aefb
Changed files:

cc/resources/resource_pool.cc
cc/resources/resource_pool.h

Comments:

cc: Give ResourcePool a unique tracing id.

There may be more than one ResourcePool in a process, so a unique id
is needed to name each resource in memory dumps. Previously it used the
id on the ResourceProvider which is unique to each layer compositor
instance. But now there are more than one ResourcePool within the same
layer compositor, as the HUD layer can have its own ResourcePool, so
invent a tracing id specifically for ResourcePool.

This also handily removes another dependency on ResourceProvider that
isn't needed for exporting resources to the display compositor.

R=en...@chromium.org

Bug: 730660, 738190
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I09427437427eb2ec1df6a40aa73d9624c004d0a6
Reviewed-on: https://chromium-review.googlesource.com/935423
Reviewed-by: enne <en...@chromium.org>
Commit-Queue: danakj <dan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538916}

Properties:

git_revision: a721b029b31640e26db86b12f9e5fd149e19aefb

Changed by: riaj...@chromium.org
Changed at: Fri 23 Feb 2018 14:11:14
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 5db6e915a8cdcdda4500934959bff3d77d56fff7
Changed files:

content/browser/site_per_process_hit_test_browsertest.cc
testing/buildbot/filters/viz.content_browsertests.filter

Comments:

Hit-test related site-per-process-browsertests with Viz hit-test.

This CL runs SitePerProcessHitTestBrowserTest,
SitePerProcessHighDPIHitTestBrowserTest,
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest,
SitePerProcessInternalsHitTestBrowserTest,
SitePerProcessMouseWheelHitTestBrowserTest,
SitePerProcessGestureHitTestBrowserTest with
--use-viz-hit-test-draw-quad flag turned on.

1. Updated SetWebEventPositions and UpdateEventRootLocation to compute
the correct screen coordiantes.

2. Added two TODOs for Viz hit-test in
MouseClickWithNonIntegerScaleFactor.MouseClickWithNonIntegerScaleFactor
and SitePerProcessHitTestBrowserTest.SurfaceHitTestPointerEventsNone.

Bug: 810121
Change-Id: I8b4d470fe76a8cbb489151fe4c113462b8982243
Reviewed-on: https://chromium-review.googlesource.com/919260
Reviewed-by: Sadrul Chowdhury <sad...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Commit-Queue: Ria Jiang <riaj...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538917}

Properties:

git_revision: 5db6e915a8cdcdda4500934959bff3d77d56fff7

Changed by: hua...@chromium.org
Changed at: Fri 23 Feb 2018 14:13:52
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 008b4ee236811270f8d5d430dd5de9e79f978235
Changed files:

chrome/android/java/src/org/chromium/chrome/browser/jsdialog/JavascriptModalDialogView.java
chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogView.java

Comments:

[TabModal] Move custom view initialization in JavascriptModalDialogView

Moved the initialization for params to be only in the static create()
method.
Discussed here: https://chromium-review.googlesource.com/915105

Bug: 687010
Change-Id: I1b8da988ab9879d3d4fe9f4567ef2d809a32c4ee
Reviewed-on: https://chromium-review.googlesource.com/917624
Reviewed-by: Joy Ming <jm...@chromium.org>
Reviewed-by: David Trainor <dtra...@chromium.org>
Commit-Queue: Becky Zhou <hua...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538918}

Properties:

git_revision: 008b4ee236811270f8d5d430dd5de9e79f978235

Reply all

Reply to author

Forward

0 new messages