buildbot failure in chromium.fyi on Browser Side Navigation Linux, revision e57f4da7e1317d96495b2a7b2438f2f8740d27d2

[buil...@chromium-build.appspotmail.com]

https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "Failure reason,generate_build_files,steps" on "Browser Side Navigation Linux"

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/40492

Revision: 13e55a33207c004ade4a43d3e177ed026d7a64bb, 613ba3311438407d2356193b8881759f0125dced, e57f4da7e1317d96495b2a7b2438f2f8740d27d2
Blame list: karan...@chromium.org,k...@chromium.org,roc...@chromium.org

Build 40492

running steps via annotated script preamble stdio

update_scripts stdio gclient_json depot_tools: 44048672dcd7f444eec5449388078ffd43e397a7 build: 9984a8b5d819791c9ac78012d25b9adb91961198

LUCI Migration stdio

LogDog Bootstrap stdio

setup_build<br>running recipe: "chromium" stdout run_recipe

makedirs checkout path stdout

bot_update<br>[44GB/245GB used (17%)] stdout json.output

ensure_goma stdio

ensure_goma.ensure_installed stdout json.output

swarming.py --version<br>0.10.2 stdout

gclient runhooks stdout

get compile targets for scripts stdout json.output

read test spec (chromium.fyi.json)<br>path: /mnt/data/b/c/builder/Browser_Side_Navigation_Linux/src/testing/buildbot/chromium.fyi.json stdout json.output

generate_build_files stdout

Failure reason stdio reason

Changed by: roc...@chromium.org
Changed at: Thu 08 Mar 2018 16:11:19
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 13e55a33207c004ade4a43d3e177ed026d7a64bb
Changed files:

• mojo/edk/embedder/entrypoints.cc
• mojo/edk/system/BUILD.gn
• mojo/edk/system/core.cc
• mojo/edk/system/core.h
• mojo/edk/system/dispatcher.cc
• mojo/edk/system/dispatcher.h
• mojo/edk/system/request_context.cc
• mojo/edk/system/signals_unittest.cc
• mojo/edk/system/trap_unittest.cc
• mojo/edk/system/watch.cc
• mojo/edk/system/watch.h
• mojo/edk/system/watcher_dispatcher.cc
• mojo/edk/system/watcher_dispatcher.h
• mojo/edk/test/mojo_test_base.cc
• mojo/edk/test/mojo_test_base.h
• mojo/public/c/system/BUILD.gn
• mojo/public/c/system/core.h
• mojo/public/c/system/functions.h
• mojo/public/c/system/thunks.cc
• mojo/public/c/system/thunks.h
• mojo/public/c/system/trap.h
• mojo/public/c/system/types.h
• mojo/public/c/system/watcher.h
• mojo/public/cpp/system/BUILD.gn
• mojo/public/cpp/system/handle_signal_tracker.cc
• mojo/public/cpp/system/simple_watcher.cc
• mojo/public/cpp/system/simple_watcher.h
• mojo/public/cpp/system/trap.cc
• mojo/public/cpp/system/trap.h
• mojo/public/cpp/system/wait.cc
• mojo/public/cpp/system/wait.h
• mojo/public/cpp/system/wait_set.cc
• mojo/public/cpp/system/wait_set.h
• mojo/public/cpp/system/watcher.cc
• mojo/public/cpp/system/watcher.h
• third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
• third_party/WebKit/Source/core/mojo/MojoWatcher.h

Comments:

Mojo: Watchers -> Traps

Refactors the watcher APIs a bit to support some exensibility. Also
renames them in the process because "trap" seems like a better analogy.

Some remnants of the watcher concept are left intact to keep the CL size
small.

TBR=dch...@chromium.org

Bug: 819046
Change-Id: Ie469f715c32080824d99b3a4f85834c030cbd181
Reviewed-on: https://chromium-review.googlesource.com/952081
Reviewed-by: Ken Rockot <roc...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Jay Civelli <jciv...@chromium.org>
Commit-Queue: Ken Rockot <roc...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541949}

Properties:

• git_revision: 13e55a33207c004ade4a43d3e177ed026d7a64bb
  

Changed by: karan...@chromium.org
Changed at: Thu 08 Mar 2018 16:13:57
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 613ba3311438407d2356193b8881759f0125dced
Changed files:

• chrome/test/BUILD.gn
• chrome/test/base/in_process_browser_test.cc
• extensions/browser/extension_api_frame_id_map.cc
• extensions/browser/extension_api_frame_id_map.h

Comments:

Extensions: Fix memory leak in ExtensionApiFrameIdMap.

Currently in ExtensionApiFrameIdMap::UpdateTabAndWindowId and
ExtensionApiFrameIdMap::LookupFrameDataOnUI we don't check whether a
RenderFrameHost is alive, before storing it's frame data. It's possible that
such a RenderFrameHost never becomes alive, and hence we don't get any
OnRenderFrameDeleted notification for it. Since ExtensionApiFrameIdMap is a
singleton, this causes a memory leak. To fix, ensure that only live
RenderFrameHosts are tracked.

Also ensure in InProcessBrowserTest::TearDown that ExtensionApiFrameIdMap is not
leaking memory for any browser test.

BUG=817205

Change-Id: I78bf06cee7e10465f9eb5973ee8e59f525a74d93
Reviewed-on: https://chromium-review.googlesource.com/951975
Reviewed-by: Scott Violet <s...@chromium.org>
Reviewed-by: Devlin <rdevlin...@chromium.org>
Commit-Queue: Karan Bhatia <karan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541950}

Properties:

• git_revision: 613ba3311438407d2356193b8881759f0125dced
  

Changed by: k...@chromium.org
Changed at: Thu 08 Mar 2018 16:15:36
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: e57f4da7e1317d96495b2a7b2438f2f8740d27d2
Changed files:

• infra/config/global/cr-buildbucket.cfg

Comments:

Add LUCI Linux and Mac ANGLE, and optional GPU, trybots to cr-buildbucket.cfg.

These need a different service account than some of the other trybots
for some of the tests they check out and run.

Bug: 815092
Change-Id: Ieb4eb45971c5b057642722eb615f586e8e212d6b
Reviewed-on: https://chromium-review.googlesource.com/955681
Reviewed-by: Andrii Shyshkalov <tan...@chromium.org>
Reviewed-by: Nodir Turakulov <no...@chromium.org>
Commit-Queue: Kenneth Russell <k...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541951}

Properties:

• git_revision: e57f4da7e1317d96495b2a7b2438f2f8740d27d2