buildbot warning in chromium.fyi on Browser Side Navigation Linux, revision 63aa462662be59fab990c69502283e7270fc1a0a

2 views
Skip to first unread message

buil...@chromium-build.appspotmail.com

unread,
Feb 25, 2018, 6:15:12 PM2/25/18
to plzna...@chromium.org, gateke...@chromium-gatekeeper-sentry.appspotmail.com
https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "bot_update" on "Browser Side Navigation Linux"

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/39582

Revision: 63aa462662be59fab990c69502283e7270fc1a0a, 550cb548914d5fc99258ced55c94f3348ad5a55a
Blame list: dtap...@chromium.org,g...@chromium.org

Build 39582
running steps via annotated script
preamble
stdio
update_scripts
stdio
gclient_json
depot_tools: f438ff743a4b157b9be8cecefa7a170f9695d185
build: f17e559a60a58b9c18dee167777d97caf2cfc14e
LUCI Migration
stdio
LogDog Bootstrap
stdio
setup_build<br>running recipe: "chromium"
stdout
run_recipe
makedirs checkout path
stdout
bot_update
stdout

Changed by: dtap...@chromium.org
Changed at: Sun 25 Feb 2018 13:42:56
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 63aa462662be59fab990c69502283e7270fc1a0a
Changed files:

  • base/threading/thread_restrictions.h
  • content/browser/android/synchronous_compositor_browser_filter.cc
  • content/browser/android/synchronous_compositor_host.cc
  • content/browser/android/synchronous_compositor_host.h
  • content/browser/android/synchronous_compositor_sync_call_bridge.cc
  • content/browser/android/synchronous_compositor_sync_call_bridge.h
  • content/browser/bad_message.h
  • content/browser/renderer_host/input/legacy_ipc_widget_input_handler.cc
  • content/browser/renderer_host/input/legacy_ipc_widget_input_handler.h
  • content/browser/renderer_host/render_process_host_impl.cc
  • content/browser/renderer_host/render_widget_host_impl.cc
  • content/browser/renderer_host/render_widget_host_view_android.cc
  • content/browser/renderer_host/render_widget_host_view_android.h
  • content/browser/renderer_host/render_widget_host_view_base.h
  • content/common/BUILD.gn
  • content/common/input/OWNERS
  • content/common/input/input_handler.mojom
  • content/common/input/synchronous_compositor.mojom
  • content/common/input/synchronous_compositor.typemap
  • content/common/typemaps.gni
  • content/public/browser/android/synchronous_compositor.cc
  • content/renderer/BUILD.gn
  • content/renderer/android/synchronous_compositor_filter.cc
  • content/renderer/android/synchronous_compositor_filter.h
  • content/renderer/android/synchronous_compositor_proxy.cc
  • content/renderer/android/synchronous_compositor_proxy.h
  • content/renderer/android/synchronous_compositor_proxy_chrome_ipc.cc
  • content/renderer/android/synchronous_compositor_proxy_chrome_ipc.h
  • content/renderer/android/synchronous_compositor_proxy_mojo.cc
  • content/renderer/android/synchronous_compositor_proxy_mojo.h
  • content/renderer/android/synchronous_layer_tree_frame_sink.cc
  • content/renderer/android/synchronous_layer_tree_frame_sink.h
  • content/renderer/input/widget_input_handler_impl.cc
  • content/renderer/input/widget_input_handler_impl.h
  • content/renderer/input/widget_input_handler_manager.cc
  • content/renderer/input/widget_input_handler_manager.h
  • content/renderer/render_thread_impl.cc
  • content/test/mock_widget_input_handler.cc
  • content/test/mock_widget_input_handler.h
  • mojo/public/cpp/bindings/sync_call_restrictions.h
  • tools/metrics/histograms/enums.xml
Comments:
Add mojo based synchronous compositor for Android.

This change restructures some chrome IPC code into a subclasses. On the
renderer side the Chrome IPC is moved into the
SynchronousCompositorProxyChromeIPC subclass and the base class is
generalized to use callbacks that Mojo can use directly.

On the browser side an impl of the mojo SynchronousCompositor interface
is made to send Chrome IPC to the renderer.

There are two Hosts for the Synchronous Compositor. The control host
which is hosted by the S
...skip...

All mojo channels are associated channels with the widget_input_handler
so input is handled in order.

BUG=722928

Change-Id: I517ab8b391433fa6b5e4b4fe2f9440dcfed29c05
Reviewed-on: https://chromium-review.googlesource.com/830928
Commit-Queue: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Charlie Reis <cr...@chromium.org>
Reviewed-by: Ken Rockot <roc...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Bo <bo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539051}
Properties:
  • git_revision: 63aa462662be59fab990c69502283e7270fc1a0a

Changed by: g...@chromium.org
Changed at: Sun 25 Feb 2018 13:57:00
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 550cb548914d5fc99258ced55c94f3348ad5a55a
Changed files:

  • base/task_scheduler/scheduler_worker_pool_impl.cc
Comments:
[SchedulerWorkerDelegateImpl] Add THREAD_CHECKER checks to document and enforce existing behaviour.

After just doing a full pass of this code for issue 810464, I think
leaving these CHECKs behind will help a future reader as well as
enforce required calling semantics.

R=fdo...@chromium.org

Bug: 810464
Change-Id: I48bd2c3c0308be3b856ef518ed41382497ca5cf8
Reviewed-on: https://chromium-review.googlesource.com/934081
Commit-Queue: Gabriel Charette <g...@chromium.org>
Reviewed-by: Robert Liao <rob...@chromium.org>
Reviewed-by: François Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539052}
Properties:
  • git_revision: 550cb548914d5fc99258ced55c94f3348ad5a55a

Reply all
Reply to author
Forward
0 new messages