buildbot warning in chromium.fyi on Browser Side Navigation Linux, revision b52b27c5fb1aa4de54e86d7d763cd39d70a2413b

[buil...@chromium-build.appspotmail.com]

https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "Failure reason" on "Browser Side Navigation Linux"

https://ci.chromium.org/buildbot/chromium.fyi/Browser%20Side%20Navigation%20Linux/50513

Revision: b52b27c5fb1aa4de54e86d7d763cd39d70a2413b, 47070f751ee3d0533b474242e862983e1949237f
Blame list: a...@chromium.org,bs...@chromium.org

Build 50513

running steps via annotated script preamble stdio

update_scripts stdio gclient_json build: c19aa859725ef3e5e6b634ab4a2fd89848f4c2df..b73ba84089e116b1f7fb9adbb94e6a6b13040e1a depot_tools: a32f98e652d5e151f70d571cf046c3d83ae2f486

LUCI Migration stdio

LogDog Bootstrap stdio

setup_build<br>running recipe: "chromium" stdout run_recipe

makedirs checkout path stdout

bot_update stdout json.output

Uncaught Exception<br>Uncaught Exception: KeyError('root',) stdio exception

Failure reason stdio reason

Changed by: bs...@chromium.org
Changed at: Mon 04 Jun 2018 17:41:17
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: b52b27c5fb1aa4de54e86d7d763cd39d70a2413b
Changed files:

• chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
• chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
• chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
• chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
• chrome/browser/ui/views/tabs/tab_strip.cc
• chrome/browser/ui/views/tabs/tab_strip.h
• chrome/browser/ui/views/tabs/tab_strip_controller.h
• chrome/browser/ui/views/tabs/tab_strip_types.h

Comments:

Fix crash in TabStripTest when Refresh is enabled.

The tab strip's parent Widget doesn't have a NonClientFrameView in unit
tests. This patch moves the logic for determining where the new tab
button should go to TabController, which has a fake version for tests.

Bug: 846410
Change-Id: I572b3b9aa6f4e4213ea9c203198b6f7bb98746c2
Reviewed-on: https://chromium-review.googlesource.com/1081891
Commit-Queue: Bret Sepulveda <bs...@chromium.org>
Reviewed-by: Peter Kasting <pkas...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564317}

Properties:

• git_revision: b52b27c5fb1aa4de54e86d7d763cd39d70a2413b
  

Changed by: a...@chromium.org
Changed at: Mon 04 Jun 2018 17:41:21
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 47070f751ee3d0533b474242e862983e1949237f
Changed files:

• chrome/browser/resources/md_bookmarks/edit_dialog.html

Comments:

Bookmarks: fix the input style in the edit dialog

Bug: 849180
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I71a8dbc6a17383f21bd58ff3c9d918444930f715
Reviewed-on: https://chromium-review.googlesource.com/1086040
Reviewed-by: Scott Chen <scot...@chromium.org>
Commit-Queue: Esmael El-Moslimany <a...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564318}

Properties:

• git_revision: 47070f751ee3d0533b474242e862983e1949237f