buildbot failure in chromium.fyi on Browser Side Navigation Linux, revision eef1642efc2494c74ae177de5d858e0ddc3e72f2

0 views
Skip to first unread message

buil...@chromium-build.appspotmail.com

unread,
May 31, 2018, 11:50:55 AM5/31/18
to plzna...@chromium.org, gateke...@chromium-gatekeeper-sentry.appspotmail.com
https://build.chromium.org/p/chromium.fyi/waterfall

Automatically closing tree for "Failure reason,compile,steps" on "Browser Side Navigation Linux"

https://ci.chromium.org/buildbot/chromium.fyi/Browser%20Side%20Navigation%20Linux/50023

Revision: 1c01a8d4e41312e1a7c0c7d7e67d6d65f8d86f1a, eef1642efc2494c74ae177de5d858e0ddc3e72f2, 15f067b9397284907bed914aaf97f85e1cceaf48, 5f7c9e1cd61f41c441e084e6119ba8fedc795969
Blame list: b...@chromium.org,chao...@chromium.org,dan...@chromium.org

Build 50023
running steps via annotated script
preamble
stdio
update_scripts
stdio
gclient_json
build: 1174cae19a3ff2f3db6c50f87bfd852a6762543b
depot_tools: cf4aced37e993525b9e21856c0d1acec682edab1
LUCI Migration
stdio
LogDog Bootstrap
stdio
setup_build<br>running recipe: "chromium"
stdout
run_recipe
makedirs checkout path
stdout
bot_update<br>[45GB/245GB used (18%)]
stdout
json.output
ensure_goma
stdio
ensure_goma.ensure_installed
stdout
json.output
swarming.py --version<br>0.12
stdout
gclient runhooks
stdout
get compile targets for scripts
stdout
json.output
read test spec (chromium.fyi.json)<br>path: /mnt/data/b/c/builder/Browser_Side_Navigation_Linux/src/testing/buildbot/chromium.fyi.json
stdout
json.output
generate_build_files
stdout
preprocess_for_goma
stdio
preprocess_for_goma.goma cache directory
stdout
preprocess_for_goma.start_goma
stdout
cloudtail
preprocess_for_goma.start cloudtail
stdout
compile
stdout
json.output[ninja_info]
raw_io.output[failure_summary]
postprocess_for_goma
stdio
postprocess_for_goma.goma_jsonstatus
stdout
json.output
postprocess_for_goma.goma_stat
stdout
postprocess_for_goma.stop_goma
stdout
postprocess_for_goma.upload_log
stdout
json.output
ninja_log
compiler_proxy_log
postprocess_for_goma.stop cloudtail
stdout
Failure reason
stdio
reason

Changed by: chao...@chromium.org
Changed at: Thu 31 May 2018 08:32:47
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 1c01a8d4e41312e1a7c0c7d7e67d6d65f8d86f1a
Changed files:

  • content/browser/renderer_host/legacy_render_widget_host_win.cc
  • ui/base/win/direct_manipulation.cc
  • ui/base/win/direct_manipulation.h
Comments:
Fix snap fling by tap and unable to scroll for new page on Windows touchpad

The user reported 2 issues in this issue:

1. should stop fling when user tap on touchpad when fling
2. not able to scroll when user click on link to load a slow page then scroll

The first issue is caused by we don't setup the real window size for viewport.
The second issue is caused by we don't stop the viewport before activate
or deactivate the window that may turns the direct manipulation to a unknown
state and stop sending events to chrome.

Bug: 847611
Change-Id: I646caf9aa70460741cedc1fea7804d8afe14d437
Reviewed-on: https://chromium-review.googlesource.com/1079460
Reviewed-by: Scott Violet <s...@chromium.org>
Commit-Queue: Jianpeng Chao <chao...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563247}
Properties:
  • git_revision: 1c01a8d4e41312e1a7c0c7d7e67d6d65f8d86f1a

Changed by: dan...@chromium.org
Changed at: Thu 31 May 2018 08:32:51
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: eef1642efc2494c74ae177de5d858e0ddc3e72f2
Changed files:

  • components/viz/service/display_embedder/server_shared_bitmap_manager.cc
  • components/viz/service/display_embedder/server_shared_bitmap_manager.h
  • content/browser/browser_main_loop.cc
Comments:
viz: Remove thread-safety from ServerSharedBitmapManager

Auditing ServerSharedBitmapManager thread usage:

GetSharedBitmapFromId() called by:
- DisplayResourceProvider::LockForRead
  - GLRenderer, SkiaRenderer, SoftwareRenderer (non-viz: UI, viz:
    Compositor)

ChildAllocatedSharedBitmap() called by:
- CompositorFrameSinkSupport::DidAllocateSharedBitmap (non-viz: UI,
  viz: Compositor)
- RenderWidgetHostImpl::DidAllocateSharedBitmap (non-viz: UI, viz:
  Compositor)

ChildDeletedSharedBitmap() calle
...skip...
cate them.

R=pi...@chromium.org

Bug: 730660
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I360e7868edf6f79990c56918a78321440fd3ee36
Reviewed-on: https://chromium-review.googlesource.com/1077671
Commit-Queue: danakj <dan...@chromium.org>
Reviewed-by: Antoine Labour <pi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563248}
Properties:
  • git_revision: eef1642efc2494c74ae177de5d858e0ddc3e72f2

Changed by: dan...@chromium.org
Changed at: Thu 31 May 2018 08:34:06
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 15f067b9397284907bed914aaf97f85e1cceaf48
Changed files:

  • components/viz/common/quads/shared_bitmap.cc
  • components/viz/common/quads/shared_bitmap.h
  • components/viz/common/resources/resource.cc
  • components/viz/common/resources/resource.h
  • components/viz/common/resources/shared_bitmap_manager.h
  • components/viz/service/display/display_resource_provider.cc
  • components/viz/service/display_embedder/server_shared_bitmap_manager.cc
  • components/viz/service/display_embedder/server_shared_bitmap_manager.h
  • components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
  • components/viz/test/test_shared_bitmap_manager.cc
  • components/viz/test/test_shared_bitmap_manager.h
Comments:
Cleanup bitmap resource complexity in DisplayResourceProvider.

1. The SharedBitmap class does not need a sequence number.
2. The |shared_bitmap| in internal::Resource is always owned so
redundant with |owned_shared_bitmap|.
3. The |shared_bitmap_id| is always set when the Resource is a bitmap
type, so |has_shared_bitmap_id| is redundant with |type|.
4. We don't need virtual APIs on SharedBitmap if we can grab the
tracing GUID from the SharedBitmapManager, move the API there, and
store the GUID on the
...skip...

R=kyle...@chromium.org
NOTRY=true

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4472105b6d5788d5539a0499598cb6c0611e3463
Reviewed-on: https://chromium-review.googlesource.com/1077079
Commit-Queue: danakj <dan...@chromium.org>
Reviewed-by: kylechar <kyle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563249}
Properties:
  • git_revision: 15f067b9397284907bed914aaf97f85e1cceaf48

Changed by: b...@chromium.org
Changed at: Thu 31 May 2018 08:35:01
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 5f7c9e1cd61f41c441e084e6119ba8fedc795969
Changed files:

  • net/http/http_server_properties_impl_unittest.cc
  • net/spdy/spdy_session_unittest.cc
Comments:
Remove TestMockTimeTaskRunner from some net_unittests.

Remove TestMockTimeTaskRunner from all net_unittests where a
ScopedTaskEnvironment is already created, and changes the type of that
ScopedTaskEnvironment to MOCK_TIME (which will internally create a
TestMockTimeTaskRunner instance).  However, do not create a
ScopedTaskEnvironment instead of a TestMockTimeTaskRunner in tests where
there is no need for a ScopedTaskEnvironment otherwise.

Change-Id: I5fcd368ae2d0eedbc38c229a6d5255d9c64f092a
Reviewed-on: https://chromium-review.googlesource.com/1079772
Reviewed-by: Helen Li <xunj...@chromium.org>
Commit-Queue: Bence Béky <b...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563250}
Properties:
  • git_revision: 5f7c9e1cd61f41c441e084e6119ba8fedc795969

Reply all
Reply to author
Forward
0 new messages