Web Exposed Layout Test with dynamic property

[Dave Tapuska]

So I'm working on the hrefTranslte attribute and the attribute on the IDL is supported when Google API keys are present in the build. So basically the hrefTranslate appears as a property only on Official Google builds (because that is where the translation engine would appear)

How should I do this for the Layout Tests for the web exposed tests? I thought about adding my own virtual test suite but that seems like overkill. Do we have other attributes on the DOM that do similar things that I can take as an example?

dave.

[Philip Jägenstedt]

I can't find hrefTranslate or hrefTranslte in cs.chromium.org, so I take it no code has landed. Will it be controlled as a runtime_enabled_feature? If so, I think a virtual test suite is the way to go. If it's part of a group of features all controlled by a single --official-google-chrome flag or similar, than having a virtual test suite for that configuration as a whole is probably best.

--
You received this message because you are subscribed to the Google Groups "platform-predictability" group.
To unsubscribe from this group and stop receiving emails from it, send an email to platform-predicta...@chromium.org.
To post to this group, send email to platform-pr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-predictability/CAHgVhZUWnmFE6hJCGa_H2P2cb%3DDMYVuV1ymstWZU6%3D-eNWCkfQ%40mail.gmail.com.

[Dave Tapuska]

I believe I was able to figure this out. What I've done (in CL 1175031) is make the content_shell indicate it has a translation service. This would test about the presence of the field.  For now since it is an experimental feature the stable webexposed virtual test suite tests that it doesn't exist. But when I goto ship this attribute I'll need to add a virtual test suite (and indicate the service isn't available) and ensure the attribute doesn't exist.

dave.

[Philip Jägenstedt]

Alright, [RuntimeEnabled=HrefTranslate] it is, then a virtual suite will do the trick later.