Issue 1061503 in chromium: App store payment support for TWAs

10 views
Skip to first unread message

danyao via monorail

unread,
Mar 13, 2020, 2:11:37 PM3/13/20
to paymen...@chromium.org
Updates:
Cc: paymen...@chromium.org

Comment #6 on issue 1061503 by dan...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c6

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

bugdroid via monorail

unread,
May 20, 2020, 11:09:53 PM5/20/20
to paymen...@chromium.org

Comment #7 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c7

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/b91fdb792ae13b68ff887f0ac28e314d117f4c1a

commit b91fdb792ae13b68ff887f0ac28e314d117f4c1a
Author: Glen Robertson <gle...@chromium.org>
Date: Thu May 21 03:05:45 2020

Add experimental stub idl for digital goods API, which never resolve.

Once the browser side implementation lands the stubs can be replaced
with calls to a mojo service, as described in the design doc for this
feature go/cros-skus (Google only). Modified from
crrev.com/c/1959237 based on drafted changes proposed in Explainer
(see below).

Discourse post:
https://discourse.wicg.io/t/proposal-web-payments-digital-product-management-api/4350
Intent to prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/vkS3k30lWNs/m/Gt4sKECQEgAJ
Explainer:
https://github.com/WICG/digital-goods/blob/master/explainer.md
Chrome Status:
https://chromestatus.com/feature/5339955595313152

A followup CL will add the mojo structs/enums and type converters.

Note: This is behind a runtime enabled feature flag, and so, does not
expose any new APIs to the web. This is a very early prototype, and
will likely not ship in its current form.

Bug: 1061503
Change-Id: Ic7a1a5b2866e40eef466f6e1d29436ba144c90ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183770
Commit-Queue: Glen Robertson <gle...@chromium.org>
Reviewed-by: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770901}

[modify] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/modules_idl_files.gni
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/BUILD.gn
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/OWNERS
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/digital_goods_service.cc
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/digital_goods_service.h
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/digital_goods_service.idl
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.cc
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.h
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.idl
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/idls.gni
[add] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/goods/item_details.idl
[modify] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/modules/payments/idls.gni
[modify] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/b91fdb792ae13b68ff887f0ac28e314d117f4c1a/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

bugdroid via monorail

unread,
Jun 4, 2020, 10:12:50 PM6/4/20
to paymen...@chromium.org

Comment #8 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c8


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1a5207e2aa2797573a91fea3d6f9aca4263f88a6

commit 1a5207e2aa2797573a91fea3d6f9aca4263f88a6
Author: Glen Robertson <gle...@chromium.org>
Date: Fri Jun 05 02:10:33 2020

Add mojo structs for Digital Goods API, and type converters to WebIDL.

Once the browser side implementation of Digital Goods lands, these type
converters can be used to forward the API calls to the browser process.

Modified from Jay's CL: crrev.com/c/1960094.
Previous CL added stub IDL: crrev.com/c/2183770.
Subsequent CL will add the mojo service interface: crrev.com/c/2215865.
Bug: 1032423, 1061503
Change-Id: Ifa386f6ad11ce1e80198691b07de607e162890aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208880
Reviewed-by: Dominick Ng <domi...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Rouslan Solomakhin <rou...@chromium.org>
Commit-Queue: Glen Robertson <gle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775399}

[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/public/mojom/digital_goods/OWNERS
[add] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/public/mojom/digital_goods/digital_goods.mojom
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/BUILD.gn
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/OWNERS
[add] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/digital_goods_type_converters.cc
[add] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/digital_goods_type_converters.h
[add] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/digital_goods_type_converters_unittest.cc
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.cc
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/payment_event_data_conversion.cc
[modify] https://crrev.com/1a5207e2aa2797573a91fea3d6f9aca4263f88a6/third_party/blink/renderer/modules/payments/payment_event_data_conversion.h

nburris via monorail

unread,
Jun 11, 2020, 9:47:14 AM6/11/20
to paymen...@chromium.org
Updates:
Cc: nbu...@chromium.org

Comment #9 on issue 1061503 by nbu...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c9


(No comment was entered for this change.)

bugdroid via monorail

unread,
Jun 26, 2020, 10:55:56 AM6/26/20
to paymen...@chromium.org

Comment #10 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c10


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee

commit 17e11a8215e3d05a649f87a7c4eb7ebf210c9aee
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Jun 26 14:55:03 2020

[Web Payment] Testing Trusted Web Activity.

Before this patch, Web Payment would enable Trusted Web Activity (TWA)
features only in production TWAs.

This patch adds a test controller method to set the TWA package name.

After this patch, the cross-platform tests for Web Payment can simulate
being in a Trusted Web Activity be calling
test_controller()->SetTwaPackageName("com.example.app").

Bug: 1061503
Change-Id: I5abb67c0a0ca514b8ed739ecd5cf85fdc05ef27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270338
Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782981}

[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestFactory.java
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/android/test_support/src/org/chromium/chrome/test_support/PaymentRequestTestBridge.java
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/payments/android/payment_request_test_bridge.cc
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/payments/android/payment_request_test_bridge.h
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/payments/payment_request_test_controller.h
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/payments/payment_request_test_controller_android.cc
[modify] https://crrev.com/17e11a8215e3d05a649f87a7c4eb7ebf210c9aee/chrome/test/payments/payment_request_test_controller_desktop.cc

bugdroid via monorail

unread,
Jun 26, 2020, 3:49:32 PM6/26/20
to paymen...@chromium.org

Comment #11 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c11


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/aa2dd036ace2b0022a76efebd7c35f67bc34b81a

commit aa2dd036ace2b0022a76efebd7c35f67bc34b81a
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Jun 26 19:48:46 2020

[Web Payment] Correct OS check.

Before this patch, GetTwaPackageName() method for Web Payment checked
for Chrome OS with CHROME_OS #define, which is never defined. Therefore,
some of the Web Payment code for Chrome OS code never compiled or
executed.

This patch changes CHROME_OS check to OS_CHROMEOS in
GetTwaPackageName().

After this patch, Web Payment has Chrome OS specific version of
GetTwaPackageName().

Bug: 1061503
Change-Id: I9b9fcb9c0a01c5b809800404464bec1d95a18b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269881

Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>

bugdroid via monorail

unread,
Jul 2, 2020, 3:19:01 AM7/2/20
to paymen...@chromium.org

Comment #12 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c12


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1242b33d0d137f6db62908c3c9008d7ba891bccd

commit 1242b33d0d137f6db62908c3c9008d7ba891bccd
Author: Glen Robertson <gle...@chromium.org>
Date: Thu Jul 02 07:18:30 2020

Add the Digital Goods mojo service and connect it to blink.

Note the browser side of the mojo interface will be implemented by a
different author. We will need to wait for that implementation to
submit this one.

Modified from Jay's CL: crrev.com/c/2032660
Previous CL added mojo structs and type converters: crrev.com/c/2208880
Update CL to bring in line with explainer: crrev.com/c/2241403
Bug: 1017947, 1032423, 1061503
Change-Id: I2217457e3fb12fb5b2e20529237d07cee22bf3fe
Fixed: 1032423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215865
Reviewed-by: Dominick Ng <domi...@chromium.org>
Commit-Queue: Glen Robertson <gle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784712}

[modify] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/public/mojom/digital_goods/digital_goods.mojom
[modify] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/renderer/modules/payments/goods/digital_goods_service.cc
[modify] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/renderer/modules/payments/goods/digital_goods_service.h
[modify] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.cc
[add] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/web_tests/digital-goods/digital-goods-interface.html
[add] https://crrev.com/1242b33d0d137f6db62908c3c9008d7ba891bccd/third_party/blink/web_tests/digital-goods/resources/mock-digital-goods-service.js

bugdroid via monorail

unread,
Jul 30, 2020, 8:24:52 PM7/30/20
to paymen...@chromium.org

Comment #14 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c14


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/fc95e95f11380759c54a9a8a0f210060876c212b

commit fc95e95f11380759c54a9a8a0f210060876c212b
Author: Jeevan Shikaram <jshi...@chromium.org>
Date: Fri Jul 31 00:23:40 2020

[Play Billing] TWA payment app service.

This patch adds a Mojo connection from the browser to the Android
subsystem on Chrome OS for interfacing with the TWA that invoked the
Chrome browser and is acting as a payment app.

Implements the ARC bridge between chromium and ARC++ to allow the
querying of the payment app on ARC++.

Bug: 1061503
Change-Id: I495c6c586ec5c5d579de3bdfa32bbc7689219d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319518
Commit-Queue: Jeevan Shikaram <jshi...@chromium.org>
Auto-Submit: Jeevan Shikaram <jshi...@chromium.org>
Reviewed-by: Yusuke Sato <yus...@chromium.org>
Reviewed-by: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Dominick Ng <domi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793446}

[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/chrome/browser/chromeos/arc/session/arc_service_launcher.cc
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/BUILD.gn
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/mojom/BUILD.gn
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/mojom/arc_bridge.mojom
[add] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/mojom/payment_app.mojom
[add] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/pay/OWNERS
[add] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/pay/arc_payment_app_bridge.cc
[add] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/pay/arc_payment_app_bridge.h
[add] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/pay/arc_payment_app_bridge_unittest.cc
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/session/arc_bridge_host_impl.cc
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/session/arc_bridge_host_impl.h
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/session/arc_bridge_service.cc
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/session/arc_bridge_service.h
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/test/fake_arc_bridge_host.cc
[modify] https://crrev.com/fc95e95f11380759c54a9a8a0f210060876c212b/components/arc/test/fake_arc_bridge_host.h

bugdroid via monorail

unread,
Aug 1, 2020, 12:46:59 PM8/1/20
to paymen...@chromium.org

Comment #15 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c15


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/88e86dc5ccccc802ed0e299883b488e4d057596a

commit 88e86dc5ccccc802ed0e299883b488e4d057596a
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sat Aug 01 16:45:10 2020

[Web Payment][Chrome OS] TWA payment app - IsReadyToPay

This patch adds a Mojo IPC method to query the TWA payment app whether
it is able to perform a payment. As opposed to IsImplemented(), this
method may invoke the payment app via an Android service connection, so
it should not be invoked when off the record, e.g., in incognito mode or
guest mode.

Bug: 1061503
Change-Id: I0aa16413c5e58709dcde378e8ef38ce5fde196a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245033
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Dominick Ng <domi...@chromium.org>
Reviewed-by: Jeevan Shikaram <jshi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793909}

[modify] https://crrev.com/88e86dc5ccccc802ed0e299883b488e4d057596a/components/arc/mojom/payment_app.mojom
[modify] https://crrev.com/88e86dc5ccccc802ed0e299883b488e4d057596a/components/arc/pay/arc_payment_app_bridge.cc
[modify] https://crrev.com/88e86dc5ccccc802ed0e299883b488e4d057596a/components/arc/pay/arc_payment_app_bridge.h
[modify] https://crrev.com/88e86dc5ccccc802ed0e299883b488e4d057596a/components/arc/pay/arc_payment_app_bridge_unittest.cc

bugdroid via monorail

unread,
Aug 13, 2020, 10:10:01 AM8/13/20
to paymen...@chromium.org

Comment #16 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c16


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1e94e55081b72f3f7b1298fe580a4528be90e79c

commit 1e94e55081b72f3f7b1298fe580a4528be90e79c
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Thu Aug 13 14:09:00 2020

[Web Payment][Chrome OS] TWA payment app - InvokePaymentApp

This patch adds a Mojo IPC method to invoke the TWA payment app in ARC.

Bug: 1061503
Change-Id: I617460dc1313de5c9968c215eac7022f64d6108d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245644

Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Dominick Ng <domi...@chromium.org>

bugdroid via monorail

unread,
Aug 13, 2020, 1:52:33 PM8/13/20
to paymen...@chromium.org

Comment #17 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c17


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef

commit fdf6ef1239d4653c4d3b31560d9f05a1d39981ef
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Thu Aug 13 17:50:47 2020

[Web Payment][Chrome OS] Test support for PaymentAppService.

Before this patch, the test environment for an ARC PaymentAppService
unit test was being setup inside of the only PaymentAppService unit
test, which prevented sharing this environment among multiple unit test
files.

This patch separates the ARC PaymentAppService test environment into its
own test support file.

After this patch, it's possible to share the setup code for ARC
PaymentAppService test environment among multiple unit test files;

Bug: 1061503
Change-Id: If8271d7d277823dc53630bcdc4f6097bc9a6a2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248749
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Scott Violet <s...@chromium.org>
Reviewed-by: Yusuke Sato <yus...@chromium.org>
Reviewed-by: Dominick Ng <domi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797746}

[modify] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/BUILD.gn
[modify] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/pay/arc_payment_app_bridge_unittest.cc
[modify] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/test/DEPS
[modify] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/test/OWNERS
[add] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/test/arc_payment_app_bridge_test_support.cc
[add] https://crrev.com/fdf6ef1239d4653c4d3b31560d9f05a1d39981ef/components/arc/test/arc_payment_app_bridge_test_support.h

bugdroid via monorail

unread,
Aug 13, 2020, 3:34:05 PM8/13/20
to paymen...@chromium.org

Comment #18 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c18


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/033583478b2c03593a9c5386690d39321758d8c2

commit 033583478b2c03593a9c5386690d39321758d8c2
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Thu Aug 13 19:33:44 2020

[Web Payment][Chrome OS] Android app communication test support.

This patch adds a helper for setting up the environment necessary to
unit test communication with Android apps. At this time, only the
Android subsystem on Chrome OS has a concrete implementation.

Bug: 1061503
Change-Id: I6900aa13cd111d14adeaab6a0116a623c4ace817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250351
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Yusuke Sato <yus...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797802}

[modify] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/BUILD.gn
[modify] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/DEPS
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/android_app_communication_test_support.h
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/android_app_communication_test_support_chrome_os.cc
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/android_app_communication_test_support_stub.cc
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/content/android_app_communication_unittest.cc
[modify] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/core/BUILD.gn
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/core/android_app_description.cc
[add] https://crrev.com/033583478b2c03593a9c5386690d39321758d8c2/components/payments/core/android_app_description.h

bugdroid via monorail

unread,
Aug 13, 2020, 6:16:05 PM8/13/20
to paymen...@chromium.org

Comment #19 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c19


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/15c22fa89b747c5014cd480d4bfc021c2789164f

commit 15c22fa89b747c5014cd480d4bfc021c2789164f
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Thu Aug 13 22:14:48 2020

[Web Payment][Chrome OS] Android app communication - GetAppDescriptions.

Before this patch, Android payment app implementation lived exclusively
in Java, so sharing any of its logic across platforms was difficult.

This patch adds a cross-platform way for Web Payment feature to query a
list of installed Android apps. As a first step, only information about
Trusted Web Activities installed in the Android subsystem of Chrome OS
would be returned.

After this patch, it's possible to start creating a cross-platform
implementation of an Android payment app.

Bug: 1061503
Change-Id: Ic8320a902eec537d5aa37b3a6cf9b79b8c579c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242639
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Sahel Sharify <sa...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797883}

[modify] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/BUILD.gn
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/android_app_communication.cc
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/android_app_communication.h
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/android_app_communication_chrome_os.cc
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/android_app_communication_stub.cc
[modify] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/content/android_app_communication_unittest.cc
[modify] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/core/BUILD.gn
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/core/chrome_os_error_strings.cc
[add] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/core/chrome_os_error_strings.h
[modify] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/core/native_error_strings.cc
[modify] https://crrev.com/15c22fa89b747c5014cd480d4bfc021c2789164f/components/payments/core/native_error_strings.h

bugdroid via monorail

unread,
Aug 13, 2020, 9:18:41 PM8/13/20
to paymen...@chromium.org

Comment #20 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c20


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1043cf8e525c99827e9842c7ba7614726d3fa501

commit 1043cf8e525c99827e9842c7ba7614726d3fa501
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Aug 14 01:17:43 2020

[Web Payment][Chrome OS] Android app communication - IsReadyToPay.


This patch adds a cross-platform way for Web Payment feature to query
the IS_READY_TO_PAY intent of an Android app. As a first step, only the
Android apps installed on the Android subsystem of Chrome OS are
supported.

Bug: 1061503
Change-Id: I3055874e96e046a233c5bb223c9e4422d7e8e966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248427
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797954}

[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/content/android_app_communication.h
[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/content/android_app_communication_chrome_os.cc
[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/content/android_app_communication_stub.cc
[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/content/android_app_communication_unittest.cc
[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/core/chrome_os_error_strings.cc
[modify] https://crrev.com/1043cf8e525c99827e9842c7ba7614726d3fa501/components/payments/core/chrome_os_error_strings.h

bugdroid via monorail

unread,
Aug 14, 2020, 12:32:56 PM8/14/20
to paymen...@chromium.org

Comment #21 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c21


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/496b5dd60cc56928afdc6360bebfeff408be4f9f

commit 496b5dd60cc56928afdc6360bebfeff408be4f9f
Author: Glen Robertson <gle...@chromium.org>
Date: Fri Aug 14 16:29:17 2020

DigitalGoods: Add MeasureAs for UMA metrics tracking feature usage.

Also ran update_use_counter_feature_enum.py to update enums.xml.

Bug: 1061503
Change-Id: Ic476333cad72038ed84ea0c80940c2e159bf77c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352303
Commit-Queue: Glen Robertson <gle...@chromium.org>
Auto-Submit: Glen Robertson <gle...@chromium.org>
Reviewed-by: Matt Giuca <mgi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798100}

[modify] https://crrev.com/496b5dd60cc56928afdc6360bebfeff408be4f9f/third_party/blink/public/mojom/web_feature/web_feature.mojom
[modify] https://crrev.com/496b5dd60cc56928afdc6360bebfeff408be4f9f/third_party/blink/renderer/modules/payments/goods/digital_goods_service.idl
[modify] https://crrev.com/496b5dd60cc56928afdc6360bebfeff408be4f9f/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.idl
[modify] https://crrev.com/496b5dd60cc56928afdc6360bebfeff408be4f9f/tools/metrics/histograms/enums.xml

bugdroid via monorail

unread,
Aug 14, 2020, 12:35:44 PM8/14/20
to paymen...@chromium.org

Comment #22 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c22


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/888a0b923e26eb927c99084fc48fa2fc261d952b

commit 888a0b923e26eb927c99084fc48fa2fc261d952b
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Aug 14 16:34:31 2020

[Web Payment][Chrome OS] Android app communication - InvokePaymentApp.

This patch adds a cross-platform way for Web Payment feature to invoke
the PAY intent of an Android app. As a first step, only the Android apps

installed on the Android subsystem of Chrome OS are supported.

Bug: 1061503

bugdroid via monorail

unread,
Aug 14, 2020, 4:47:27 PM8/14/20
to paymen...@chromium.org

Comment #23 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c23


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/a714a88a160796a58dcfc8e271fdcb37884dc878

commit a714a88a160796a58dcfc8e271fdcb37884dc878
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Aug 14 20:41:25 2020

[Web Payment][Chrome OS] Cross-platform Android payment app.

This patch adds a C++ payment app object that communicates to Android
payment apps. At this time, only Chrome OS has concrete implementation
that connects to a Trusted Web Activity in the Android subsystem.

Design: https://bit.ly/cross-platform-pay-app-factory

Bug: 1061503
Change-Id: Ice5918967493e34cfa5ad4a4ccc25ce2602d204a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255112
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798238}

[modify] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/content/BUILD.gn
[add] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/content/android_payment_app.cc
[add] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/content/android_payment_app.h
[add] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/content/android_payment_app_unittest.cc
[modify] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/core/native_error_strings.cc
[modify] https://crrev.com/a714a88a160796a58dcfc8e271fdcb37884dc878/components/payments/core/native_error_strings.h

bugdroid via monorail

unread,
Aug 14, 2020, 7:09:50 PM8/14/20
to paymen...@chromium.org

Comment #24 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c24


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/3c6ead957995f42440d3385e34d6e7f57a30b6cb

commit 3c6ead957995f42440d3385e34d6e7f57a30b6cb
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Fri Aug 14 23:05:23 2020

[Web Payment] TWA package name in PaymentAppFactoryParams.

Before this patch, Android payment app finder would determine the TWA
package name directly through the package manager, which prevented the
C++ browser tests from mocking the TWA package name through the test
delegate.

This patch changes Android payment app finder to look up the TWA package
name through PaymentAppFactoryParams. The PaymentRequestImpl implements
the Params interface through the test delegate, which the C++ tests can
modify.

After this patch, android browser tests can simulate running inside of a
TWA.

Bug: 1061503
Change-Id: I4d5df8d10f80fbb81678e877496285bc8cedf8b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300179
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>

Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>

bugdroid via monorail

unread,
Aug 15, 2020, 8:41:33 AM8/15/20
to paymen...@chromium.org

Comment #25 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c25


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/cbdeef954dfc34e94c8ca9cf72ad326b4a121158

commit cbdeef954dfc34e94c8ca9cf72ad326b4a121158
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sat Aug 15 12:39:30 2020

[Web Payment] TWA package name in PaymentAppFactory::Delegate.

Before this patch, the TWA package name was available only on desktop
through ChromePaymentRequestDelegate object, which prevented TWA payment
app logic from being cross-platform.

This patch adds the TWA package name to PaymentAppFactory::Delegate,
which is implemented on both desktop and Android.

After this patch, the logic for handling TWA payment apps can be
cross-platform.

Bug: 1061503
Change-Id: I01ac3c2e3a01e31f17a9e8e963671302f92c091a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300002
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Sahel Sharify <sa...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798442}

[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppServiceBridge.java
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/chrome/browser/payments/android/payment_app_service_bridge.cc
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/chrome/browser/payments/android/payment_app_service_bridge.h
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/chrome/browser/payments/android/payment_app_service_bridge_unittest.cc
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/components/payments/content/android/java/src/org/chromium/components/payments/PaymentAppFactoryParams.java
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/components/payments/content/payment_app_factory.h
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/cbdeef954dfc34e94c8ca9cf72ad326b4a121158/components/payments/content/payment_request_state.h

bugdroid via monorail

unread,
Aug 15, 2020, 6:26:23 PM8/15/20
to paymen...@chromium.org

Comment #26 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c26


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/0c3c73f64248fef14db300a21f9775b5f8fbf258

commit 0c3c73f64248fef14db300a21f9775b5f8fbf258
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sat Aug 15 22:25:06 2020

[Web Payment] Requested method data filter.

This patch adds a utility function (and corresponding unit test) for
filtering the requested payment method data according to the payment
method names supported by an app. This prevents a payment app from
receiving method-specific information about methods that it does not
support.

Bug: 1061503
Change-Id: I901a2fd6166ddc031f8910816a0e3f8fdc5a7b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300344
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798465}

[modify] https://crrev.com/0c3c73f64248fef14db300a21f9775b5f8fbf258/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/0c3c73f64248fef14db300a21f9775b5f8fbf258/components/payments/core/payment_request_data_util.h
[modify] https://crrev.com/0c3c73f64248fef14db300a21f9775b5f8fbf258/components/payments/core/payment_request_data_util_unittest.cc

bugdroid via monorail

unread,
Aug 15, 2020, 8:04:28 PM8/15/20
to paymen...@chromium.org

Comment #27 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c27


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/29289e6c059b44e45475564d3f2b499a2a0510fa

commit 29289e6c059b44e45475564d3f2b499a2a0510fa
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sun Aug 16 00:03:08 2020

[Web Payment] Android activity to app splitter.


This patch adds a utility function (and corresponding unit test) for
separating a single Android payment app into multiple Android payment
apps that have exactly one payment activity per app. This enables
treating each PAY intent filter as its own payment app, including when
one app declares multiple PAY intent filter targets.

Bug: 1061503
Change-Id: Ieecd43607b282295667108f70f94b276997fe25c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300276
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>

Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>

bugdroid via monorail

unread,
Aug 15, 2020, 9:47:31 PM8/15/20
to paymen...@chromium.org

Comment #28 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c28


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/2e363d050c301e05bed5fbedcaf314ea32f6c0a2

commit 2e363d050c301e05bed5fbedcaf314ea32f6c0a2
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sun Aug 16 01:43:48 2020

[Web Payment] Empty cross-platform Android payment app factory.

This patch adds the skeleton code for a payment app factory for Android
payment apps. The new factory is disabled by default, but can be enabled
via chrome://flags/#enable-web-payments-experimental-features drop-down
or --enable-features=CrossPlatformAndroidPaymentAppFactory command line
flag. When enabled, the new factory does not return any payment apps in
this patch.

Bug: 1061503
Change-Id: Iea19c68889be77d5083f86d2b9063db64de38cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299855
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Sahel Sharify <sa...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798471}

[modify] https://crrev.com/2e363d050c301e05bed5fbedcaf314ea32f6c0a2/components/payments/content/BUILD.gn
[add] https://crrev.com/2e363d050c301e05bed5fbedcaf314ea32f6c0a2/components/payments/content/android_payment_app_factory.cc
[add] https://crrev.com/2e363d050c301e05bed5fbedcaf314ea32f6c0a2/components/payments/content/android_payment_app_factory.h
[modify] https://crrev.com/2e363d050c301e05bed5fbedcaf314ea32f6c0a2/components/payments/content/payment_app_service.cc

bugdroid via monorail

unread,
Aug 16, 2020, 9:46:18 AM8/16/20
to paymen...@chromium.org

Comment #29 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c29


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/85beea0aa81479cbfa5d398055f93bafea247ed2

commit 85beea0aa81479cbfa5d398055f93bafea247ed2
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sun Aug 16 13:45:31 2020

[Web Payment] Simple Android payment app factory.

Before this patch, the Android payment apps installed on Chrome OS would
not be available in Web Payment.

This patch queries the list of installed Android payment apps and
returns all of them to Web Payment, if
chrome://flags/#enable-web-payments-experimental-features is enabled.

After this patch, the Android payment apps installed on Chrome OS are
available in Web Payment.

Bug: 1061503
Change-Id: Ifb11741377a0a21166d77c547dbbad21b6daffeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302269
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798488}

[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/chrome/browser/payments/BUILD.gn
[add] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/chrome/browser/payments/android_payment_app_factory_browsertest.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/BUILD.gn
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/android_payment_app_factory.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/android_payment_app_factory.h
[add] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/android_payment_app_factory_unittest.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/payment_app_service.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/payment_app_service.h
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/payment_app_service_factory.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/85beea0aa81479cbfa5d398055f93bafea247ed2/components/test/data/payments/app_store_billing_tests/index.js

bugdroid via monorail

unread,
Aug 16, 2020, 1:32:34 PM8/16/20
to paymen...@chromium.org

Comment #30 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c30


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/64e73b7b75fa344eaee037be9e47adeb7a248d74

commit 64e73b7b75fa344eaee037be9e47adeb7a248d74
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Sun Aug 16 17:30:37 2020

[Web Payment] TWA-specific payment method identifiers.

Before this patch, any Android payment app could be used on Chrome OS
(when chrome://flags/#enable-web-payments-experimental-features flag was
enabled).

This patch adds a check that Chrome is running in TWA mode and one of
the requested payment methods is supported by TWAs.

After this patch, only TWA-specific payment method identifiers can be
used with TWA payment apps on Chrome OS.

Bug: 1061503
Change-Id: I48573e142d099546b93577e432346674932b3f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302310
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>

Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>

bugdroid via monorail

unread,
Aug 17, 2020, 7:19:39 AM8/17/20
to paymen...@chromium.org

Comment #31 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c31


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1f85bba70e332b4c9981a12a043da7ee1b6089bf

commit 1f85bba70e332b4c9981a12a043da7ee1b6089bf
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Mon Aug 17 11:18:16 2020

[Web Payment] At most one IS_READY_TO_PAY service

Before this patch, the platform-specific Chrome OS Android app
communication code was checking the number of IS_READY_TO_PAY services
in an Android app, which could cause duplication of logic between Chrome
OS and Android.

This patch moves the check for number of IS_READY_TO_PAY services from
the platform specific Chrome OS Android app communication to the

cross-platform Android payment app factory.

After this patch, the logic for checking the number of IS_READY_TO_PAY
services is cross-platform.

Bug: 1061503
Change-Id: I72f3b3040771174d61e72bd71afe5665c5a30865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302369
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Sahel Sharify <sa...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798584}

[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/content/android_app_communication_chrome_os.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/content/android_app_communication_unittest.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/content/android_payment_app_factory.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/content/android_payment_app_factory_unittest.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/core/chrome_os_error_strings.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/core/chrome_os_error_strings.h
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/core/native_error_strings.cc
[modify] https://crrev.com/1f85bba70e332b4c9981a12a043da7ee1b6089bf/components/payments/core/native_error_strings.h

bugdroid via monorail

unread,
Aug 17, 2020, 8:47:29 AM8/17/20
to paymen...@chromium.org

Comment #32 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c32


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d

commit 289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Mon Aug 17 12:45:35 2020

[Web Payment] Query IS_READY_TO_PAY service.

Before this patch, all TWA payment apps on Chrome OS were available for
payment, even if they implemented an IS_READY_TO_PAY service that
replied "false" to the query (when

chrome://flags/#enable-web-payments-experimental-features flag was
enabled).

This patch queries the IS_READY_TO_PAY service of the TWA payment app on
Chrome OS and enables payments only if the service is absent or returns
"true".

After this patch, the TWA payment app can control at runtime whether
it's able to handle payments.

Bug: 1061503
Change-Id: Idb267c0bbe2d8bb9173bcfde1b9a25e47a7fc505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269744
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Danyao Wang <dan...@chromium.org>

Reviewed-by: Liquan (Max) Gu <ma...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798600}

[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/content/android_payment_app.cc
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/content/android_payment_app.h
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/content/android_payment_app_factory.cc
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/content/android_payment_app_factory_unittest.cc
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/content/android_payment_app_unittest.cc
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/core/payment_request_data_util.h
[modify] https://crrev.com/289daef6c1cb7c6ee6ea73b08e9e669bb261ec5d/components/payments/core/payment_request_data_util_unittest.cc

bugdroid via monorail

unread,
Aug 17, 2020, 10:24:31 AM8/17/20
to paymen...@chromium.org

Comment #33 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c33


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d

commit 72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Mon Aug 17 14:23:40 2020

[Web Pay][Chrome OS] Test for ignoring non-TWA payment apps.

This patch adds a browser test for ignoring non-TWA payment apps when
running inside of a TWA that provides app store payment capability to
Chrome. The test is for Chrome OS only, which is using the
cross-platform Android payment app factory. When this factory is ported
to Android, then the same test will work on Android as well.

Bug: 1061503
Change-Id: I8f366c0feca7604000e8efc5e47d57047ab68a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347400
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: Nick Burris <nbu...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798622}

[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/chrome/browser/payments/android_payment_app_factory_browsertest.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/chrome/test/payments/payment_request_test_controller.h
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/chrome/test/payments/payment_request_test_controller_android.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/chrome/test/payments/payment_request_test_controller_desktop.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/android_app_communication.h
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/android_app_communication_chrome_os.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/android_app_communication_stub.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/android_payment_app.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/android_payment_app.h
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/payment_app.h
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/payments/content/payment_request.cc
[modify] https://crrev.com/72fd06dad4ba9866ff35cdc3f3ff3b8eb152825d/components/test/data/payments/payment_handler_status.js

rouslan via monorail

unread,
Aug 17, 2020, 10:45:58 AM8/17/20
to paymen...@chromium.org
Updates:
Status: Fixed

Comment #34 on issue 1061503 by rou...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c34


(No comment was entered for this change.)

glenrob via monorail

unread,
Nov 3, 2020, 7:50:45 PM11/3/20
to paymen...@chromium.org
Updates:
Blockedon: 1017947
Blocking: -1017947
Owner: gle...@chromium.org
Status: Started

Comment #35 on issue 1061503 by gle...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c35

Reopening this bug for tracking launch progress publicly.
Please mark fixed once the feature has launched to OT.

bugdroid via monorail

unread,
Nov 12, 2020, 2:04:36 AM11/12/20
to paymen...@chromium.org

Comment #38 on issue 1061503 by bugdroid: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c38


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/fd63def9cbd915d7c9ad61b4bd5b9c0f85ad8572

commit fd63def9cbd915d7c9ad61b4bd5b9c0f85ad8572
Author: Glen Robertson <gle...@chromium.org>
Date: Thu Nov 12 06:59:39 2020

digitalgoods:Ensure "payments" feature is enabled to use DG.

Trying to match the restrictions in the Payment Request API spec [1]
(DG isn't spec'd yet).

We require that the "payment" feature policy is enabled. Secure context
is already ensured by the IDL.
Also add some logging of errors so developers can figure out what is
going wrong.

[1]: https://w3c.github.io/payment-request/#dfn-payment-relevant-browsing-context

Bug: 1061503
Change-Id: I2c13663148ad8736a4d9ab3ea124d96038d8e878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526872
Reviewed-by: Dominick Ng <domi...@chromium.org>
Commit-Queue: Glen Robertson <gle...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826681}

[modify] https://crrev.com/fd63def9cbd915d7c9ad61b4bd5b9c0f85ad8572/third_party/blink/renderer/modules/payments/goods/dom_window_digital_goods.cc

glenrob via monorail

unread,
Dec 2, 2020, 10:57:57 PM12/2/20
to paymen...@chromium.org
Updates:
Status: Fixed

Comment #39 on issue 1061503 by gle...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c39

Is there anything left to do on this? If so, feel free to reopen.

mgiuca via monorail

unread,
Jan 31, 2021, 9:53:03 PM1/31/21
to paymen...@chromium.org
Updates:
Labels: Proj-Fugu OriginTrial-88

Comment #40 on issue 1061503 by mgi...@chromium.org: App store payment support for TWAs
https://bugs.chromium.org/p/chromium/issues/detail?id=1061503#c40


(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages