Can we drop a Web IDL dictionary AndroidPayTokenization?

[Hitoshi Yoshida]

Hi payments-team,

I'm Hitoshi working in Blink bindings team.

Now we are re-creating our IDL compiler system, and have a problem in Android payment's IDLs.

I sent this mail to Rouslan, but I think it better to share this with the team and send this again.

AndroidPayTokenization dictionary has a Dictionary type member |parameters|, and I'd like to clean up this Dictionary type.

As far as I searched, AndroidParyTokenization is only used in another IDL dictionary AndroidPayMethodData.

And AndroidPayMethodData is referred only in SetAndroidPayMethodData().

In this function, the instance of AndroidPayMethodData is used to refer three members, |environment|, |minGooglePlayServiceVersion|, and |apiVersion|.  It means, the other 4 members including |paymentMethodTokenizationParameters| are never accessed.

So I wonder if we can drop these 4 unused members of AndroidPayMethodData from the IDL file. Dropping only |paymentMethodTokenizationParameters| is enough for us, though.  This CL is the proposal.  Then we can also drop support of AndroidPayTokenization dictionary.

If you'd like to keep them, I'd like to change the type of AndroidPayTokenization.parameters to "any".

--

Hitoshi Yoshida (Peria)

email: pe...@chromium.org

[Danyao Wang]

Hi Hitoshi,

Thanks for reaching out. It's safe to remove the these fields (their usage was deleted in crrev.com/c/1592067 but we forgot to clean up the IDL). Thanks for sending the cleanup CL!

Cheers,

Danyao

--
You received this message because you are subscribed to the Google Groups "Public Payment Request Announcements" group.
To unsubscribe from this group and stop receiving emails from it, send an email to paymentreques...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/paymentrequest/CAJnxdXBLmxDvkA8sd_cNjZn-MAkC0KA5pWM9FQc8SG8T1F6Afg%40mail.gmail.com.

[Hitoshi Yoshida]

Hi Danyao,

Thank you for the confirmation!

I updated the CL (dropped comment-out members), and landed it.

2020年2月11日(火) 9:09 Danyao Wang <dan...@chromium.org>: