Issue 1490800 in chromium: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/4916626

[wpt-autoroller via monorail]

Status: Untriaged
Owner: ----
CC: pain...@chromium.org
Labels: Test-WebTest
Components: Blink>SVG
Pri: 3
Type: Bug

New issue 1490800 by wpt-aut...@chops-service-accounts.iam.gserviceaccount.com: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/4916626
https://bugs.chromium.org/p/chromium/issues/detail?id=1490800

WPT import https://crrev.com/c/4916626 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/types/scripted/SVGLength-px-with-context.html new failing tests: https://crrev.com/c/4916626/4/third_party/blink/web_tests/external/wpt/svg/types/scripted/SVGLength-px-with-context-expected.txt

Expectations or baseline files [0] have been automatically added for the failing results to keep the bots green. Please investigate the new failures and triage as appropriate.

Upstream changes imported:
https://github.com/web-platform-tests/wpt/compare/bb3f58fe4c568d7c08dee71972274bcf0377b720...3d46548c5fbeb3c1b5f6bc5ae0854e0a1a0462ff
flush layout when working with percentage units: https://github.com/web-platform-tests/wpt/commit/3d46548c5fbeb3c1b5f6bc5ae0854e0a1a0462ff [affecting this directory]
change test setup to rely on promises that the child iframe will resolve and also use a supported and playable video source so that source selection sticks.: https://github.com/web-platform-tests/wpt/commit/ba48034aae064a8288b7747ebcf3679a7069c4c3
Very minor adjustment to delay-load-event-* tests: https://github.com/web-platform-tests/wpt/commit/8930eba4609ddec6f7a0f5a9943132bdc1786df9
Don't sort order against children of different flex or grid containers.: https://github.com/web-platform-tests/wpt/commit/8ea650a3844249418dada3989c3031c8e6d5b23d
sensors: Make Blink Mojo requests go through a new WebSensorProvider interface: https://github.com/web-platform-tests/wpt/commit/5b5d10521e4a317236ba8da175c1b0c1a8136fb8
FSA: Relax file name checks in the BucketFS: https://github.com/web-platform-tests/wpt/commit/e4c1bdf27a01716a605a70e171be797f560952bf
[web-tests] Fix incorrect fuzziness parameter minimums: https://github.com/web-platform-tests/wpt/commit/8a68da27f807555f912c7862307d1f907fbe7620
Start dbus for Chrome (#42241): https://github.com/web-platform-tests/wpt/commit/8c76a955371d179cbab41f6d0038e7c90e558508
[anchor-position] Implement per-axis scroll adjustment: https://github.com/web-platform-tests/wpt/commit/2562b459eb0189a79329e56a1530fa0972cb0533
Add WPT for permissions policy report-only mode: https://github.com/web-platform-tests/wpt/commit/0a366a4aa0d18fcb055a5b75c898cc7ad39aae1a
[anchor-position] Add a new `anchor-center` alignment keyword: https://github.com/web-platform-tests/wpt/commit/2e73f4115b1799e06f325c6bfde642442bdcc719

[0]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/web_test_expectations.md

This bug was filed automatically due to a new WPT test failure for which you are marked an OWNER. If you do not want to receive these reports, please add "wpt { notify: NO }" to the relevant DIR_METADATA file.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[fs via monorail]

Updates:
Owner: f...@opera.com
Status: Started

Comment #1 on issue 1490800 by f...@opera.com: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/4916626
https://bugs.chromium.org/p/chromium/issues/detail?id=1490800#c1

(No comment was entered for this change.)

[Git Watcher via monorail]

Updates:
Status: Fixed

Comment #2 on issue 1490800 by Git Watcher: [WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/4916626
https://bugs.chromium.org/p/chromium/issues/detail?id=1490800#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/33855b1049d64d236ffbde7e7279bbf0ae9b341c

commit 33855b1049d64d236ffbde7e7279bbf0ae9b341c
Author: Fredrik Söderquist <f...@opera.com>
Date: Wed Oct 11 10:13:04 2023

Ensure style and layout is up-to-date before resolving SVGLengths

Certain units depend on style being up-to-date and others depend on
layout being up-to-date. Expand the current can-resolve infrastructure
in SVGLengthTearOff to also ensure that the lifecycle is advanced
(forced) before attempting to resolve the value of the associated
SVGLength.

Fixed: 1490800
Change-Id: I0b363490eb037319dbcf06c3360a1350f7572d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916089
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1208168}

[delete] https://crrev.com/3647a650acf1eeb448f923682fef110ccc2d8219/third_party/blink/web_tests/external/wpt/svg/types/scripted/SVGLength-px-with-context.html.ini
[delete] https://crrev.com/3647a650acf1eeb448f923682fef110ccc2d8219/third_party/blink/web_tests/external/wpt/svg/types/scripted/SVGLength-px-with-context-expected.txt
[modify] https://crrev.com/33855b1049d64d236ffbde7e7279bbf0ae9b341c/third_party/blink/renderer/core/svg/svg_length_tear_off.cc