Remove obsolete IS_CAST_AUDIO_ONLY buildflag and core usages [chromium/src : main]

0 views
Skip to first unread message

Kenneth Russell (Gerrit)

unread,
May 20, 2026, 5:08:39 PM (4 days ago) May 20
to Luke Halliwell, Simeon Anfinrud, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, ozone-...@chromium.org
Attention needed from Luke Halliwell and Simeon Anfinrud

Kenneth Russell voted and added 1 comment

Votes added by Kenneth Russell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Kenneth Russell . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Luke Halliwell
  • Simeon Anfinrud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I182d47c0d102b7967d4de6a19f56a4e2f7423805
Gerrit-Change-Number: 7853879
Gerrit-PatchSet: 13
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Luke Halliwell <hall...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 21:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simeon Anfinrud (Gerrit)

unread,
May 20, 2026, 5:43:49 PM (4 days ago) May 20
to Luke Halliwell, Kenneth Russell, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, ozone-...@chromium.org
Attention needed from Luke Halliwell

Simeon Anfinrud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Luke Halliwell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I182d47c0d102b7967d4de6a19f56a4e2f7423805
Gerrit-Change-Number: 7853879
Gerrit-PatchSet: 13
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Luke Halliwell <hall...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 21:43:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Luke Halliwell (Gerrit)

unread,
May 20, 2026, 5:49:46 PM (4 days ago) May 20
to Simeon Anfinrud, Kenneth Russell, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, ozone-...@chromium.org

Luke Halliwell voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I182d47c0d102b7967d4de6a19f56a4e2f7423805
Gerrit-Change-Number: 7853879
Gerrit-PatchSet: 13
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 21:49:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 20, 2026, 6:10:47 PM (4 days ago) May 20
to Luke Halliwell, Simeon Anfinrud, Kenneth Russell, chromium...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove obsolete IS_CAST_AUDIO_ONLY buildflag and core usages

Following the deprecation of audio-only builds, IS_CAST_AUDIO_ONLY
evaluates exclusively to 0. This CL removes the obsolete buildflag
from `chromecast/BUILD.gn` and cleans up remaining cross-component
usages across content/ and ui/ozone/.
Bug: 41489655
Test: content_unittests
Change-Id: I182d47c0d102b7967d4de6a19f56a4e2f7423805
Reviewed-by: Kenneth Russell <k...@chromium.org>
Commit-Queue: Luke Halliwell <hall...@chromium.org>
Reviewed-by: Simeon Anfinrud <san...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633857}
Files:
  • M chromecast/BUILD.gn
  • M content/browser/gpu/gpu_data_manager_impl_private.cc
  • M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
  • M ui/ozone/platform/cast/ozone_platform_cast.cc
Change size: S
Delta: 4 files changed, 7 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kenneth Russell, +1 by Simeon Anfinrud
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I182d47c0d102b7967d4de6a19f56a4e2f7423805
Gerrit-Change-Number: 7853879
Gerrit-PatchSet: 14
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kenneth Russell <k...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages