wayland: add VLOGs to data drag controller functions [chromium/src : main]

Nick Yamane (Gerrit)

unread,

Sep 20, 2023, 2:41:46 AM9/20/23

to ozone-...@chromium.org, Chromium LUCI CQ, Mitsuru Oshima, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Mitsuru Oshima.

Patch set 2:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  oshima PTAL. thanks

To view, visit change 4876187. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Sep 22, 2023, 2:02:01 AM9/22/23

to Nick Yamane, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Nick Yamane.

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  currently both touch and mouse event updates the pointer location, which may

To view, visit change 4876187. To unsubscribe, or for help writing mail filters, visit settings.

Nick Yamane (Gerrit)

unread,

Sep 22, 2023, 12:28:42 PM9/22/23

to ozone-...@chromium.org, Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng

Attention is currently required from: Mitsuru Oshima.

Patch set 2:Commit-Queue +2

View Change

1 comment:

Patchset:

- Patch Set #2:
  currently both touch and mouse event updates the pointer location, which may

- Have you hit ENTER before finishing your comment?

To view, visit change 4876187. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Sep 22, 2023, 1:33:47 PM9/22/23

to Nick Yamane, ozone-...@chromium.org, Mitsuru Oshima, chromium...@chromium.org, Daniel Cheng

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Nick Yamane: Commit
  Mitsuru Oshima: Looks good to me

wayland: add VLOGs to data drag controller functions

This will hopefully help us on better understanding subtle and
hard-to-repro issues observed in the wild, such as, the linked crbug.
A similar approach has been in place for window drag controller.

R=oshima

Bug: 1472682
Change-Id: I38ea9fc876cd45a55e333a3d1dc774e44644a0dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876187
Commit-Queue: Nick Yamane <nick...@igalia.com>
Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200325}
---
M chrome/browser/ash/crosapi/browser_manager.cc
M ui/ozone/platform/wayland/host/wayland_data_drag_controller.cc
2 files changed, 28 insertions(+), 4 deletions(-)

To view, visit change 4876187. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward