[gfx] Remove color space legacy IPC [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Jan 27, 2026, 3:20:26 PM (5 days ago) Jan 27
to Colin Blundell, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Chromium IPC Reviews and Colin Blundell
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 27, 2026, 3:21:15 PM (5 days ago) Jan 27
to Dave Tapuska, Colin Blundell, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Chromium IPC Reviews, Colin Blundell and Dave Tapuska
Saifuddin Hitawala added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Colin Blundell
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jan 27, 2026, 3:27:23 PM (5 days ago) Jan 27
to Saifuddin Hitawala, Chromium IPC Reviews, Dave Tapuska, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell, Dave Tapuska and Joe Mason
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): joenot...@google.com
Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Colin Blundell
- Dave Tapuska
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jan 27, 2026, 3:28:01 PM (5 days ago) Jan 27
to Saifuddin Hitawala, Chromium IPC Reviews, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell, Joe Mason and Saifuddin Hitawala
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Colin Blundell
- Joe Mason
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 28, 2026, 3:11:49 AM (5 days ago) Jan 28
to Saifuddin Hitawala, Colin Blundell, Dave Tapuska, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Joe Mason and Saifuddin Hitawala
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Joe Mason
- Saifuddin Hitawala
Joe Mason (Gerrit)
Jan 28, 2026, 11:38:16 AM (5 days ago) Jan 28
to Saifuddin Hitawala, Colin Blundell, Dave Tapuska, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Attention needed from Saifuddin Hitawala
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 28, 2026, 12:36:02 PM (5 days ago) Jan 28
to Colin Blundell, Dave Tapuska, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 28, 2026, 12:39:36 PM (5 days ago) Jan 28
to Saifuddin Hitawala, Colin Blundell, Dave Tapuska, Chromium IPC Reviews, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gfx] Remove color space legacy IPC
Remove gfx::ColorSpace legacy IPCs and param traits for RangeID.
Update the only usage in VideoColorSpace to use from
gfx.mojom.ColorSpace and clean up unnecessary includes/deps.
Change-Id: I3a16a39f209961a80941e0e82fec64027c342b7a
Reviewed-by: Colin Blundell <blun...@chromium.org>
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1576019}
Files:
- M content/common/BUILD.gn
- M content/public/common/BUILD.gn
- M gpu/command_buffer/client/BUILD.gn
- M gpu/command_buffer/client/gles2_implementation.cc
- M gpu/command_buffer/client/raster_implementation.cc
- M gpu/command_buffer/service/BUILD.gn
- M gpu/command_buffer/service/common_decoder.cc
- M gpu/ipc/common/BUILD.gn
- M media/base/ipc/BUILD.gn
- M media/gpu/ipc/common/BUILD.gn
- M media/gpu/ipc/service/BUILD.gn
- M media/mojo/mojom/BUILD.gn
- M media/mojo/mojom/media_types.mojom
- M media/mojo/mojom/video_frame_mojom_traits.h
- M services/viz/public/cpp/compositing/copy_output_result_mojom_traits.h
- M services/viz/public/cpp/compositing/transferable_resource_mojom_traits.h
- M ui/display/mojom/display_snapshot_mojom_traits.h
- D ui/gfx/ipc/color/BUILD.gn
- D ui/gfx/ipc/color/OWNERS
- D ui/gfx/ipc/color/gfx_ipc_color_export.h
- D ui/gfx/ipc/color/gfx_param_traits.cc
- D ui/gfx/ipc/color/gfx_param_traits.h
- D ui/gfx/ipc/color/gfx_param_traits_macros.h
- M ui/ozone/common/BUILD.gn
Change size: M
Delta: 24 files changed, 1 insertion(+), 136 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Dave Tapuska, +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages