[wayland] Explicitly request initial preferred image description [chromium/src : main]

0 views
Skip to first unread message

Christopher Snowhill (kode54) (Gerrit)

unread,
May 20, 2026, 7:46:43 AM (4 days ago) May 20
to Eliot Courtney, Antonio Gomes Netto, Orko Garai, Thomas Lukaszewicz, Nick Yamane, Alexander Dunaev, Thomas Anderson, Mitsuru Oshima, Hidehiko Abe, Maksim Sisov, Michael Spang, Peter McNeeley, Avi Drissman, Nico Weber, ccameron chromium, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alexander Dunaev and Thomas Anderson

Christopher Snowhill (kode54) added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Christopher Snowhill (kode54) . resolved

I'm not sure if I should be firing this off at the entire ownership list for the file, but I figure everyone in charge of it should have a fair shake at it.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Dunaev
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I85382b296e01bdbf682002d919ffc735ae9b301f
Gerrit-Change-Number: 7863231
Gerrit-PatchSet: 1
Gerrit-Owner: Christopher Snowhill (kode54) <kod...@gmail.com>
Gerrit-Reviewer: Alexander Dunaev <adu...@igalia.com>
Gerrit-Reviewer: Antonio Gomes Netto <toni...@igalia.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Maksim Sisov <msi...@igalia.com>
Gerrit-Reviewer: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: Alexander Dunaev <adu...@igalia.com>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 11:46:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Christopher Snowhill (kode54) (Gerrit)

unread,
May 20, 2026, 7:49:30 AM (4 days ago) May 20
to Eliot Courtney, Antonio Gomes Netto, Orko Garai, Thomas Lukaszewicz, Nick Yamane, Alexander Dunaev, Thomas Anderson, Mitsuru Oshima, Hidehiko Abe, Maksim Sisov, Michael Spang, Peter McNeeley, Avi Drissman, Nico Weber, ccameron chromium, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alexander Dunaev and Thomas Anderson

Christopher Snowhill (kode54) added 1 comment

Patchset-level comments
Christopher Snowhill (kode54) . unresolved

Someone who can fire off runners should probably verify that at least the Mutter runner does what it's supposed to, assuming it has a simulated HDR output. Which it probably doesn't.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Dunaev
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Gerrit-Comment-Date: Wed, 20 May 2026 11:49:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Max Ihlenfeldt (Gerrit)

    unread,
    May 20, 2026, 7:58:40 AM (4 days ago) May 20
    to Christopher Snowhill (kode54), Chromium LUCI CQ, Maksim Sisov, Eliot Courtney, Antonio Gomes Netto, Orko Garai, Thomas Lukaszewicz, Nick Yamane, Alexander Dunaev, Thomas Anderson, Mitsuru Oshima, Hidehiko Abe, Michael Spang, Peter McNeeley, Avi Drissman, Nico Weber, ccameron chromium, Colin Blundell, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Alexander Dunaev, Christopher Snowhill (kode54) and Thomas Anderson

    Max Ihlenfeldt added 1 comment

    Patchset-level comments
    Max Ihlenfeldt . resolved

    Please don't add 18 reviewers for a CL that touches two files in the same directory.

    Tom Anderson and Kramer Ge are the last two to edit these files, please remove all other reviewers.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Dunaev
    • Christopher Snowhill (kode54)
    • Thomas Anderson
    Gerrit-Attention: Alexander Dunaev <adu...@igalia.com>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Christopher Snowhill (kode54) <kod...@gmail.com>
    Gerrit-Comment-Date: Wed, 20 May 2026 11:58:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    May 20, 2026, 8:04:43 AM (4 days ago) May 20
    to Christopher Snowhill (kode54), Chromium LUCI CQ, Peter McNeeley, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, Colin Blundell
    Attention needed from Christopher Snowhill (kode54)

    Colin Blundell added 1 comment

    Patchset-level comments
    Colin Blundell . resolved

    Thanks! Trimming the reviewer list.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christopher Snowhill (kode54)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I85382b296e01bdbf682002d919ffc735ae9b301f
    Gerrit-Change-Number: 7863231
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Snowhill (kode54) <kod...@gmail.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-Attention: Christopher Snowhill (kode54) <kod...@gmail.com>
    Gerrit-Comment-Date: Wed, 20 May 2026 12:04:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christopher Snowhill (kode54) (Gerrit)

    unread,
    May 20, 2026, 11:39:19 PM (4 days ago) May 20
    to Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Christopher Snowhill (kode54) added 1 comment

    Patchset-level comments
    Christopher Snowhill (kode54) . resolved

    Sorry about that, everyone. I wish I'd thought to read the log for the files. I was kind of out of it last night. Hope my bad night didn't turn into your bad day.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I85382b296e01bdbf682002d919ffc735ae9b301f
    Gerrit-Change-Number: 7863231
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christopher Snowhill (kode54) <kod...@gmail.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
    Gerrit-CC: Peter McNeeley <peterm...@google.com>
    Gerrit-Comment-Date: Thu, 21 May 2026 03:39:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christopher Snowhill (kode54) (Gerrit)

    unread,
    May 21, 2026, 9:04:40 PM (3 days ago) May 21
    to Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Christopher Snowhill (kode54) added 1 comment

    Patchset-level comments
    Christopher Snowhill (kode54) . resolved

    Someone who can fire off runners should probably verify that at least the Mutter runner does what it's supposed to, assuming it has a simulated HDR output. Which it probably doesn't.

    Christopher Snowhill (kode54)

    It looks like someone already did this.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I85382b296e01bdbf682002d919ffc735ae9b301f
      Gerrit-Change-Number: 7863231
      Gerrit-PatchSet: 1
      Gerrit-Owner: Christopher Snowhill (kode54) <kod...@gmail.com>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
      Gerrit-CC: Peter McNeeley <peterm...@google.com>
      Gerrit-Comment-Date: Fri, 22 May 2026 01:04:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Christopher Snowhill (kode54) <kod...@gmail.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages