Reland "Move Dawn Ozone Image Representation over to Shared Texture Memory" [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Feb 25, 2026, 9:26:06 AMFeb 25
to Peter McNeeley, AyeAye, Chromium LUCI CQ, Michael Spang, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Michael Spang and Peter McNeeley
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Spang
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Feb 25, 2026, 4:46:20 PMFeb 25
to Peter McNeeley, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Peter McNeeley
Michael Spang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Spang
| Code-Review | +1 |
1 comment
File ui/gfx/BUILD.gn
Line 639, Patchset 3 (Latest):
if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {Michael Spang . unresolved
Revert this if possible as it was more correct before: linux is always a sufficient condition to compile dmabuf. dmabuf does not depend on ozone, it's improper to add such conditions.
Related details
Attention is currently required from:
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Mar 2, 2026, 1:05:10 PMMar 2
to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Michael Spang and Vasiliy Telezhnikov
Peter McNeeley added 1 comment![]( "Open in Gerrit")
File ui/gfx/BUILD.gn
Line 639, Patchset 3:
if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {Michael Spang . resolved
Revert this if possible as it was more correct before: linux is always a sufficient condition to compile dmabuf. dmabuf does not depend on ozone, it's improper to add such conditions.
Peter McNeeley
As discussed. I am exploring a better simpler way to do this
Related details
Attention is currently required from:
- Michael Spang
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Mar 3, 2026, 4:07:15 PMMar 3
to Peter McNeeley, Michael Spang, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Michael Spang and Peter McNeeley
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
File gpu/command_buffer/service/BUILD.gn
Line 483, Patchset 4 (Latest):
if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {Vasiliy Telezhnikov . unresolved
would `if (is_chromeos || is_linux)` work?
Related details
Attention is currently required from:
- Michael Spang
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Mar 3, 2026, 7:09:57 PMMar 3
to Peter McNeeley, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Peter McNeeley
Michael Spang added 1 comment![]( "Open in Gerrit")
File gpu/command_buffer/service/BUILD.gn
Line 483, Patchset 4 (Latest):
if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {Vasiliy Telezhnikov . unresolved
would `if (is_chromeos || is_linux)` work?
Attention is currently required from:
- Peter McNeeley
Peter McNeeley (Gerrit)
Mar 9, 2026, 2:29:54 PMMar 9
to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Peter McNeeley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter McNeeley
| Commit-Queue | +1 |
1 comment
File ui/gfx/linux/BUILD.gn
Line 9, Patchset 5 (Latest):
ozone_platform_headless)Peter McNeeley . unresolved
So dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Mar 10, 2026, 3:56:44 PMMar 10
to Peter McNeeley, Michael Spang, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Peter McNeeley
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
Vasiliy Telezhnikov . resolved
lgtm, thanks.
File ui/gfx/linux/BUILD.gn
Line 9, Patchset 5 (Latest):
ozone_platform_headless)Peter McNeeley . unresolved
So dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation
Vasiliy Telezhnikov
(optional) Maybe we should change this to check for is_linux || is_chromeos.
File is in ui/gfx/linux, so it's not obvious why it wants to check check ozone platform to me.
Related details
Attention is currently required from:
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Mar 13, 2026, 11:04:13 AMMar 13
to Peter McNeeley, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Peter McNeeley
Michael Spang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Spang
| Code-Review | +1 |
1 comment
File ui/gfx/linux/BUILD.gn
Line 9, Patchset 5 (Latest):
ozone_platform_headless)Peter McNeeley . unresolved
Vasiliy TelezhnikovSo dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation
(optional) Maybe we should change this to check for is_linux || is_chromeos.
File is in ui/gfx/linux, so it's not obvious why it wants to check check ozone platform to me.
Michael Spang
+1 for is_linux || is_chromeos.
Related details
Attention is currently required from:
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Mar 13, 2026, 12:31:18 PMMar 13
to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Peter McNeeley added 2 comments![]( "Open in Gerrit")
File gpu/command_buffer/service/BUILD.gn
Line 483, Patchset 4:
if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {Vasiliy Telezhnikov . resolved
Michael Spangwould `if (is_chromeos || is_linux)` work?
Yes.
Peter McNeeley
Done
File ui/gfx/linux/BUILD.gn
Vasiliy TelezhnikovSo dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation
Michael Spang(optional) Maybe we should change this to check for is_linux || is_chromeos.
File is in ui/gfx/linux, so it's not obvious why it wants to check check ozone platform to me.
+1 for is_linux || is_chromeos.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Mar 13, 2026, 1:45:52 PMMar 13
to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Peter McNeeley voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Mar 13, 2026, 1:51:32 PMMar 13
to Peter McNeeley, Michael Spang, Vasiliy Telezhnikov, AyeAye, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/gfx/linux/BUILD.gn
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Reland "Move Dawn Ozone Image Representation over to Shared Texture Memory"
Attempt #4. Resolving Cast build failures.
This is a reland of commit e36bb082f72c0049cc8a54af29e70e0f756434e1
Original change's description:
> Move Dawn Ozone Image Representation over to Shared Texture Memory
>
> (Attempt #3)
>
> TESTED again on chromeos device using webgpu meets.
>
> This is done as far as ozone is concerned but the issue with opaque fences still remains. Basically ozone backing works with sync fences
> and the external_vk_image_backing doesnt not.
>
> We are able to make this change only because webGPU for LINUX is not
> enabled and will not be for the foreseeable future. WebGPU on linux
> will work with this change if it uses the external_vk_image_backing
> and associated representations.
>
> This is dependent on:
> https://dawn-review.googlesource.com/c/dawn/+/194440
>
> This means that we must use single copy for linux video import as we
> cannot use zero copy through ozone image backing (again due to
> the fence sync vs opaque issue)
>
> See: 'CanImportNativePixmapToWebGPU' function
>
> Bug: 330385376
> Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173060
> Reviewed-by: Michael Spang <sp...@chromium.org>
> Commit-Queue: Peter McNeeley <peterm...@google.com>
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1589395}
Bug: 330385376
Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Michael Spang <sp...@chromium.org>
Commit-Queue: Peter McNeeley <peterm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1599166}
Files:
- M gpu/command_buffer/service/BUILD.gn
- M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc
- M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.h
- M gpu/command_buffer/service/webgpu_decoder_impl.cc
- M ui/gfx/linux/BUILD.gn
Change size: M
Delta: 5 files changed, 160 insertions(+), 59 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Michael Spang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Mar 22, 2026, 7:15:32 PM (11 days ago) Mar 22
to Chromium LUCI CQ, Michael Spang, Vasiliy Telezhnikov, AyeAye, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Peter McNeeley has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages