Reland "Move Dawn Ozone Image Representation over to Shared Texture Memory" [chromium/src : main]

0 views
Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,
Feb 25, 2026, 9:26:06 AMFeb 25
to Peter McNeeley, AyeAye, Chromium LUCI CQ, Michael Spang, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Michael Spang and Peter McNeeley

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Spang
  • Peter McNeeley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
Gerrit-Change-Number: 7603194
Gerrit-PatchSet: 3
Gerrit-Owner: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Feb 2026 14:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Spang (Gerrit)

unread,
Feb 25, 2026, 4:46:20 PMFeb 25
to Peter McNeeley, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Peter McNeeley

Michael Spang voted and added 1 comment

Votes added by Michael Spang

Code-Review+1

1 comment

File ui/gfx/BUILD.gn
Line 639, Patchset 3 (Latest): if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {
Michael Spang . unresolved

Revert this if possible as it was more correct before: linux is always a sufficient condition to compile dmabuf. dmabuf does not depend on ozone, it's improper to add such conditions.

Open in Gerrit

Related details

Attention is currently required from:
  • Peter McNeeley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
Gerrit-Change-Number: 7603194
Gerrit-PatchSet: 3
Gerrit-Owner: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Comment-Date: Wed, 25 Feb 2026 21:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter McNeeley (Gerrit)

unread,
Mar 2, 2026, 1:05:10 PM (11 days ago) Mar 2
to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
Attention needed from Michael Spang and Vasiliy Telezhnikov

Peter McNeeley added 1 comment

File ui/gfx/BUILD.gn
Line 639, Patchset 3: if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {
Michael Spang . resolved

Revert this if possible as it was more correct before: linux is always a sufficient condition to compile dmabuf. dmabuf does not depend on ozone, it's improper to add such conditions.

Peter McNeeley

As discussed. I am exploring a better simpler way to do this

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Spang
  • Vasiliy Telezhnikov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
    Gerrit-Change-Number: 7603194
    Gerrit-PatchSet: 4
    Gerrit-Owner: Peter McNeeley <peterm...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: David Worsham <dwor...@google.com>
    Gerrit-CC: Michael Spang <sp...@chromium.org>
    Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
    Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Michael Spang <sp...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 18:05:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Michael Spang <sp...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vasiliy Telezhnikov (Gerrit)

    unread,
    Mar 3, 2026, 4:07:15 PM (10 days ago) Mar 3
    to Peter McNeeley, Michael Spang, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
    Attention needed from Michael Spang and Peter McNeeley

    Vasiliy Telezhnikov added 1 comment

    File gpu/command_buffer/service/BUILD.gn
    Line 483, Patchset 4 (Latest): if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {
    Vasiliy Telezhnikov . unresolved

    would `if (is_chromeos || is_linux)` work?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Spang
    • Peter McNeeley
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
      Gerrit-Change-Number: 7603194
      Gerrit-PatchSet: 4
      Gerrit-Owner: Peter McNeeley <peterm...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: David Worsham <dwor...@google.com>
      Gerrit-CC: Michael Spang <sp...@chromium.org>
      Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
      Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
      Gerrit-Attention: Peter McNeeley <peterm...@google.com>
      Gerrit-Attention: Michael Spang <sp...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 21:07:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Michael Spang (Gerrit)

      unread,
      Mar 3, 2026, 7:09:57 PM (9 days ago) Mar 3
      to Peter McNeeley, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
      Attention needed from Peter McNeeley

      Michael Spang added 1 comment

      File gpu/command_buffer/service/BUILD.gn
      Line 483, Patchset 4 (Latest): if (ozone_platform_drm || ozone_platform_wayland || ozone_platform_x11) {
      Vasiliy Telezhnikov . unresolved

      would `if (is_chromeos || is_linux)` work?

      Michael Spang

      Yes.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Peter McNeeley
      Gerrit-Comment-Date: Wed, 04 Mar 2026 00:09:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Peter McNeeley (Gerrit)

      unread,
      Mar 9, 2026, 2:29:54 PM (4 days ago) Mar 9
      to Michael Spang, Vasiliy Telezhnikov, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org

      Peter McNeeley voted and added 1 comment

      Votes added by Peter McNeeley

      Commit-Queue+1

      1 comment

      File ui/gfx/linux/BUILD.gn
      Line 9, Patchset 5 (Latest): ozone_platform_headless)
      Peter McNeeley . unresolved

      So dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
      Gerrit-Change-Number: 7603194
      Gerrit-PatchSet: 5
      Gerrit-Owner: Peter McNeeley <peterm...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: David Worsham <dwor...@google.com>
      Gerrit-CC: Michael Spang <sp...@chromium.org>
      Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
      Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
      Gerrit-Comment-Date: Mon, 09 Mar 2026 18:29:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vasiliy Telezhnikov (Gerrit)

      unread,
      Mar 10, 2026, 3:56:44 PM (3 days ago) Mar 10
      to Peter McNeeley, Michael Spang, AyeAye, Chromium LUCI CQ, David Worsham, Sasha Kunitskaya, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, headless...@chromium.org, cc-...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, emi...@google.com, penghu...@chromium.org, spang...@chromium.org, fuchsia...@chromium.org
      Attention needed from Peter McNeeley

      Vasiliy Telezhnikov voted and added 2 comments

      Votes added by Vasiliy Telezhnikov

      Code-Review+1

      2 comments

      Patchset-level comments
      Vasiliy Telezhnikov . resolved

      lgtm, thanks.

      File ui/gfx/linux/BUILD.gn
      Line 9, Patchset 5 (Latest): ozone_platform_headless)
      Peter McNeeley . unresolved

      So dawn_ozone_image_representation is enabled for headless. So it will end up needing these files. The other way we could do this is try to get headless not to use DawnOzoneImageRepresentation

      Vasiliy Telezhnikov

      (optional) Maybe we should change this to check for is_linux || is_chromeos.

      File is in ui/gfx/linux, so it's not obvious why it wants to check check ozone platform to me.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Peter McNeeley
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I240b8d2c46b36b38e13f7e0f65044dd48b13e568
        Gerrit-Change-Number: 7603194
        Gerrit-PatchSet: 5
        Gerrit-Owner: Peter McNeeley <peterm...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
        Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: David Worsham <dwor...@google.com>
        Gerrit-CC: Michael Spang <sp...@chromium.org>
        Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
        Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
        Gerrit-Attention: Peter McNeeley <peterm...@google.com>
        Gerrit-Comment-Date: Tue, 10 Mar 2026 19:56:37 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Peter McNeeley <peterm...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages