[M144-LTS][Ozone/Wayland]Guard all delegate() calls with weak_this [chromium/src : refs/branch-heads/7559]

0 views
Skip to first unread message

Gyuyoung Kim (xWF) (Gerrit)

unread,
Jul 9, 2026, 11:04:28 PM (13 days ago) Jul 9
to Kramer Ge, Thomas Anderson, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Fahad Mansoor, Kramer Ge and Thomas Anderson

Gyuyoung Kim (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Gyuyoung Kim (xWF) . resolved

The bug was approved for M144 LTS. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Fahad Mansoor
  • Kramer Ge
  • Thomas Anderson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Gerrit-Change-Number: 8068557
Gerrit-PatchSet: 2
Gerrit-Owner: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Fahad Mansoor <fahadm...@google.com>
Gerrit-Reviewer: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Fahad Mansoor <fahadm...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 03:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Jul 10, 2026, 1:32:02 AM (13 days ago) Jul 10
to Gyuyoung Kim (xWF), Kramer Ge, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Fahad Mansoor, Gyuyoung Kim (xWF) and Kramer Ge

Thomas Anderson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fahad Mansoor
  • Gyuyoung Kim (xWF)
  • Kramer Ge
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Gerrit-Change-Number: 8068557
Gerrit-PatchSet: 2
Gerrit-Owner: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Fahad Mansoor <fahadm...@google.com>
Gerrit-Reviewer: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Attention: Fahad Mansoor <fahadm...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 05:31:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fahad Mansoor (Gerrit)

unread,
Jul 10, 2026, 6:16:06 AM (13 days ago) Jul 10
to Gyuyoung Kim (xWF), Kramer Ge, Thomas Anderson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Gyuyoung Kim (xWF) and Kramer Ge

Fahad Mansoor added 1 comment

Patchset-level comments
Fahad Mansoor . resolved

LTS Sheriff LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Gyuyoung Kim (xWF)
  • Kramer Ge
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Gerrit-Change-Number: 8068557
Gerrit-PatchSet: 2
Gerrit-Owner: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Fahad Mansoor <fahadm...@google.com>
Gerrit-Reviewer: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 10:15:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Jul 13, 2026, 1:22:50 PM (10 days ago) Jul 13
to Gyuyoung Kim (xWF), Thomas Anderson, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Gyuyoung Kim (xWF)

Kramer Ge voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gyuyoung Kim (xWF)
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Gerrit-Change-Number: 8068557
Gerrit-PatchSet: 2
Gerrit-Owner: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Fahad Mansoor <fahadm...@google.com>
Gerrit-Reviewer: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Comment-Date: Mon, 13 Jul 2026 17:22:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Jul 13, 2026, 1:22:57 PM (10 days ago) Jul 13
to Gyuyoung Kim (xWF), Thomas Anderson, Fahad Mansoor, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com
Attention needed from Gyuyoung Kim (xWF)

Kramer Ge voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Mon, 13 Jul 2026 17:22:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 13, 2026, 1:49:05 PM (10 days ago) Jul 13
to Gyuyoung Kim (xWF), Kramer Ge, Thomas Anderson, Fahad Mansoor, android-bu...@system.gserviceaccount.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, max+watc...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M144-LTS][Ozone/Wayland]Guard all delegate() calls with weak_this

delegate() calls may implicitly destroy WaylandWindow. Guard direct and
indirect calls to delegate() state changes with weak_this if such calls
are followed by potential deref of WaylandWindow members.

(cherry picked from commit 87abcfa5b16b689587f94f40e6e7de88db11313a)
Fixed: 518007484
Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1657588}
Reviewed-by: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7559@{#5086}
Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
Files:
  • M ui/ozone/platform/wayland/host/wayland_bubble.cc
  • M ui/ozone/platform/wayland/host/wayland_frame_manager.cc
  • M ui/ozone/platform/wayland/host/wayland_popup.cc
  • M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
  • M ui/ozone/platform/wayland/host/wayland_window.cc
  • M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
Change size: M
Delta: 6 files changed, 145 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7559
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Thomas Anderson, +1 by Kramer Ge
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I9fe00496ee807f3416c9a9a2dedeef352e4a63e6
Gerrit-Change-Number: 8068557
Gerrit-PatchSet: 3
Gerrit-Owner: Gyuyoung Kim (xWF) <qk...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages