Move Dawn Ozone Image Representation over to Shared Texture Memory [chromium/src : main]

[Peter McNeeley (Gerrit)]

Peter McNeeley added 1 comment

File ui/ozone/platform/drm/gpu/gbm_pixmap.cc

Line 70, Patchset 3 (Latest): return ui::GetFourCCFormatFromBufferFormat(buffer_->GetBufferFormat());

Peter McNeeley . unresolved

we should use 'GetFourCCFormatFromSharedImageFormat' now
aka use the shared image format above.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 3

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 05 Feb 2026 15:20:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Peter McNeeley (Gerrit)]

Peter McNeeley added 1 comment

File ui/ozone/platform/drm/gpu/gbm_pixmap.cc

Line 70, Patchset 3: return ui::GetFourCCFormatFromBufferFormat(buffer_->GetBufferFormat());

Peter McNeeley . resolved

we should use 'GetFourCCFormatFromSharedImageFormat' now
aka use the shared image format above.

Peter McNeeley

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 7

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 06 Feb 2026 19:29:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Peter McNeeley <peterm...@google.com>

[Vasiliy Telezhnikov (Gerrit)]

Attention needed from Peter McNeeley

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Vasiliy Telezhnikov . resolved

lgtm % nit, thanks.

File gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc

Line 144, Patchset 10 (Latest): dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();

Vasiliy Telezhnikov . unresolved

nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?

Open in Gerrit

Related details

Attention is currently required from:

• Peter McNeeley

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 10

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Peter McNeeley <peterm...@google.com>

Gerrit-Comment-Date: Wed, 18 Feb 2026 17:49:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Peter McNeeley (Gerrit)]

Attention needed from Vasiliy Telezhnikov

Peter McNeeley added 1 comment

File gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc

Line 144, Patchset 10 (Latest): dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();

Vasiliy Telezhnikov . unresolved

nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?

Peter McNeeley

I used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such

Open in Gerrit

Related details

Attention is currently required from:

• Vasiliy Telezhnikov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 10

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 02:57:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>

[Vasiliy Telezhnikov (Gerrit)]

Attention needed from Michael Spang and Peter McNeeley

Vasiliy Telezhnikov added 1 comment

File gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc

Line 144, Patchset 10 (Latest): dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();

Vasiliy Telezhnikov . unresolved

nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?

Peter McNeeley

I used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such

Vasiliy Telezhnikov

I believe you can now, we changed it [here](https://chromium-review.googlesource.com/c/chromium/src/+/7545452). You probably will need to move [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/BUILD.gn;drc=3628a05592a7424a20692d6874f81c7d4e959adc;l=432) to deps above.

I don't have strong feelings about it though, it's more to keep change smaller and maintain illusion that NativePixmap is not posix-only.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Spang
• Peter McNeeley

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 10

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Peter McNeeley <peterm...@google.com>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 18:59:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Peter McNeeley <peterm...@google.com>

Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>

[Peter McNeeley (Gerrit)]

Attention needed from Michael Spang and Vasiliy Telezhnikov

Peter McNeeley added 1 comment

File gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc

Line 144, Patchset 10 (Latest): dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();

Vasiliy Telezhnikov . unresolved

nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?

Peter McNeeley

I used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such

Vasiliy Telezhnikov

I believe you can now, we changed it [here](https://chromium-review.googlesource.com/c/chromium/src/+/7545452). You probably will need to move [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/BUILD.gn;drc=3628a05592a7424a20692d6874f81c7d4e959adc;l=432) to deps above.

I don't have strong feelings about it though, it's more to keep change smaller and maintain illusion that NativePixmap is not posix-only.

Peter McNeeley

If you dont mind I will leave this as is. I had some issues with this particular aspect of the CL and this was the best that I came up with.

Perhaps another adventurer will come along and tackle this.

Open in Gerrit

Related details

Attention is currently required from:

• Michael Spang
• Vasiliy Telezhnikov

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6

Gerrit-Change-Number: 6173060

Gerrit-PatchSet: 10

Gerrit-Owner: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>

Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: David Worsham <dwor...@google.com>

Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 04:46:57 +0000