Move Dawn Ozone Image Representation over to Shared Texture Memory [chromium/src : main]
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
return ui::GetFourCCFormatFromBufferFormat(buffer_->GetBufferFormat());we should use 'GetFourCCFormatFromSharedImageFormat' now
aka use the shared image format above.
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
return ui::GetFourCCFormatFromBufferFormat(buffer_->GetBufferFormat());we should use 'GetFourCCFormatFromSharedImageFormat' now
aka use the shared image format above.
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?
Related details
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();nit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?
I used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such
Related details
- Vasiliy Telezhnikov
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();Peter McNeeleynit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?
I used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such
I believe you can now, we changed it [here](https://chromium-review.googlesource.com/c/chromium/src/+/7545452). You probably will need to move [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/BUILD.gn;drc=3628a05592a7424a20692d6874f81c7d4e959adc;l=432) to deps above.
I don't have strong feelings about it though, it's more to keep change smaller and maintain illusion that NativePixmap is not posix-only.
Related details
- Michael Spang
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley added 1 comment![]( "Open in Gerrit")
dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();Peter McNeeleynit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?
Vasiliy TelezhnikovI used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such
I believe you can now, we changed it [here](https://chromium-review.googlesource.com/c/chromium/src/+/7545452). You probably will need to move [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/BUILD.gn;drc=3628a05592a7424a20692d6874f81c7d4e959adc;l=432) to deps above.
I don't have strong feelings about it though, it's more to keep change smaller and maintain illusion that NativePixmap is not posix-only.
If you dont mind I will leave this as is. I had some issues with this particular aspect of the CL and this was the best that I came up with.
Perhaps another adventurer will come along and tackle this.
Related details
- Michael Spang
- Vasiliy Telezhnikov
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
dmaBufDesc.drmFormat = pixmap_->GetFourCCBufferFormat();Peter McNeeleynit: Get we call `GetFourCCFormatFromSharedImageFormat` here instead of adding the method?
Vasiliy TelezhnikovI used the method because i couldnt call GetFourCCFormatFromBufferFormat because it was somewhere in linux drm. I dont think this changed for GetFourCCFormatFromSharedImageFormat. So i think we should leave it as such
Peter McNeeleyI believe you can now, we changed it [here](https://chromium-review.googlesource.com/c/chromium/src/+/7545452). You probably will need to move [this](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/BUILD.gn;drc=3628a05592a7424a20692d6874f81c7d4e959adc;l=432) to deps above.
I don't have strong feelings about it though, it's more to keep change smaller and maintain illusion that NativePixmap is not posix-only.
If you dont mind I will leave this as is. I had some issues with this particular aspect of the CL and this was the best that I came up with.
Perhaps another adventurer will come along and tackle this.
- Michael Spang
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Spang (Gerrit)
Michael Spang voted Code-Review+1![]( "Open in Gerrit")
- Peter McNeeley
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Peter McNeeley voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Move Dawn Ozone Image Representation over to Shared Texture Memory
(Attempt #3)
TESTED again on chromeos device using webgpu meets.
This is done as far as ozone is concerned but the issue with opaque fences still remains. Basically ozone backing works with sync fences
and the external_vk_image_backing doesnt not.
We are able to make this change only because webGPU for LINUX is not
enabled and will not be for the foreseeable future. WebGPU on linux
will work with this change if it uses the external_vk_image_backing
and associated representations.
This is dependent on:
https://dawn-review.googlesource.com/c/dawn/+/194440
This means that we must use single copy for linux video import as we
cannot use zero copy through ozone image backing (again due to
the fence sync vs opaque issue)
See: 'CanImportNativePixmapToWebGPU' function
- M components/viz/service/display/overlay_processor_ozone_unittest.cc
- M gpu/command_buffer/service/BUILD.gn
- M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc
- M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.h
- M gpu/command_buffer/service/webgpu_decoder_impl.cc
- M ui/gfx/BUILD.gn
- M ui/gfx/linux/native_pixmap_dmabuf.cc
- M ui/gfx/linux/native_pixmap_dmabuf.h
- M ui/gfx/native_pixmap.h
- M ui/ozone/platform/drm/gpu/gbm_pixmap.cc
- M ui/ozone/platform/drm/gpu/gbm_pixmap.h
- M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.cc
- M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.h
- M ui/ozone/platform/headless/headless_surface_factory.cc
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
- M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.h
Code-Review: +1 by Michael Spang, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sasha Kunitskaya (Gerrit)
Sasha Kunitskaya added 1 comment![]( "Open in Gerrit")
Hi! Looks like implementation of virtual method 'GetFourCCBufferFormat' is missed in this class: https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/platform/cast/surface_factory_cast.cc;l=48
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |