chromecast: Remove dead force_use_cma_backend_for_output flag [chromium/src : main]

0 views
Skip to first unread message

SLSA Policy Verification Service (Gerrit)

unread,
May 19, 2026, 11:38:05 AM (5 days ago) May 19
to Luke Halliwell, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87fa7ac5cee8fc36f6ae9e7b5814ce1b08f55ed7
Gerrit-Change-Number: 7858958
Gerrit-PatchSet: 2
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Comment-Date: Tue, 19 May 2026 15:37:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Luke Halliwell (Gerrit)

unread,
May 20, 2026, 3:31:00 PM (4 days ago) May 20
to Simeon Anfinrud, Chromium LUCI CQ, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org
Attention needed from Simeon Anfinrud

Luke Halliwell voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simeon Anfinrud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87fa7ac5cee8fc36f6ae9e7b5814ce1b08f55ed7
Gerrit-Change-Number: 7858958
Gerrit-PatchSet: 11
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Simeon Anfinrud <san...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 19:30:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simeon Anfinrud (Gerrit)

unread,
May 20, 2026, 3:39:01 PM (4 days ago) May 20
to Luke Halliwell, Chromium LUCI CQ, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org
Attention needed from Luke Halliwell

Simeon Anfinrud voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Luke Halliwell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87fa7ac5cee8fc36f6ae9e7b5814ce1b08f55ed7
Gerrit-Change-Number: 7858958
Gerrit-PatchSet: 11
Gerrit-Owner: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: Luke Halliwell <hall...@chromium.org>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-Reviewer: Simeon Anfinrud <san...@chromium.org>
Gerrit-Attention: Luke Halliwell <hall...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 19:38:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Luke Halliwell (Gerrit)

unread,
May 20, 2026, 3:48:32 PM (4 days ago) May 20
to Simeon Anfinrud, Chromium LUCI CQ, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, halliwe...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Luke Halliwell submitted the change

Change information

Commit message:
chromecast: Remove dead force_use_cma_backend_for_output flag

Following the permanent deprecation of the mixer service, the
`force_use_cma_backend_for_output` flag in `CastAudioManager` is
obsolete and dead code (initialized but never read). This CL removes
the flag, simplifies `CastAudioManager` constructors, and updates
unittests.

Bug: 41489655
Test: cast_media_unittests

TAG=agy
CONV=1604dde5-a61e-4d45-944f-137744023a1b
Change-Id: I87fa7ac5cee8fc36f6ae9e7b5814ce1b08f55ed7
Auto-Submit: Luke Halliwell <hall...@chromium.org>
Reviewed-by: Simeon Anfinrud <san...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633770}
Files:
  • M chromecast/media/audio/cast_audio_manager.cc
  • M chromecast/media/audio/cast_audio_manager.h
  • M chromecast/media/audio/cast_audio_manager_unittest.cc
  • M chromecast/media/audio/cast_audio_output_stream_unittest.cc
Change size: S
Delta: 4 files changed, 4 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Simeon Anfinrud
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87fa7ac5cee8fc36f6ae9e7b5814ce1b08f55ed7
Gerrit-Change-Number: 7858958
Gerrit-PatchSet: 12
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages