Remove superfluous base/feature_list.h includes from various headers [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Nov 24, 2025, 5:28:56 PM (8 days ago) Nov 24

to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, Dirk Schulze, Andrew Rayskiy, Kentaro Hara, Hirokazu Honda, Nate Chapin, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Ian Vollick, AyeAye Python Dispatcher, Chromium LUCI CQ, jmedle...@chromium.org, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, bartek...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, cros-ed...@google.com, csharrison+...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, emircan+watch...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jbauma...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb+watch...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mcasas+med...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Nov 24, 2025, 7:19:18 PM (8 days ago) Nov 24

Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 25, 2025, 5:09:45 PM (7 days ago) Nov 25

Lei Zhang voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 25, 2025, 5:14:29 PM (7 days ago) Nov 25

to Lei Zhang, Daniel Cheng, AyeAye, Akihiro Ota, chromium...@chromium.org, Dirk Schulze, Andrew Rayskiy, Kentaro Hara, Hirokazu Honda, Nate Chapin, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Ian Vollick, AyeAye Python Dispatcher, jmedle...@chromium.org, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, bartek...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, cros-ed...@google.com, csharrison+...@chromium.org, csharris...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtapuska+...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, emircan+watch...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jbauma...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, jessemcke...@google.com, jophba...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb+watch...@chromium.org, lizeb...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, mcasas+med...@chromium.org, mdjone...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ozone-...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, rayanka...@chromium.org, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tbansal+...@chromium.org, tbarzi...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, translat...@chromium.org, vakh+safe_br...@chromium.org, video-networking...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Remove superfluous base/feature_list.h includes from various headers

Remove base/feature_list.h includes from headers that do not reference
base::FeatureList, BASE_DECLARE_FEATURE, etc. Then do IWYU to fix the
build.

Bug: 40318405

Change-Id: Ic3246984e47519b41ee33b54805dcabe42782b87

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7190133

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1550068}

Files:

M android_webview/browser/aw_browser_process.h
M base/allocator/partition_alloc_support.h
M base/apple/mach_port_rendezvous.h
M base/task/sequence_manager/sequence_manager_impl.h
M base/task/thread_pool/environment_config.h
M cc/tiles/gpu_image_decode_cache.h
M chrome/browser/accessibility/live_caption/live_caption_test_util.h
M chrome/browser/android/customtabs/custom_tab_session_state_tracker.h
M chrome/browser/apps/app_discovery_service/app_discovery_service.h
M chrome/browser/ash/login/oobe_apps_service/oobe_apps_discovery_service.h
M chrome/browser/component_updater/recovery_improved_component_installer.h
M chrome/browser/enterprise/data_protection/data_protection_clipboard_utils.h
M chrome/browser/extensions/api/experimental_ai_data/experimental_ai_data_api.h
M chrome/browser/extensions/api/identity/identity_api.h
M chrome/browser/extensions/api/identity/identity_get_auth_token_function.h
M chrome/browser/extensions/api/identity/web_auth_flow.h
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
M chrome/browser/flags/android/chrome_session_state.h
M chrome/browser/media/router/discovery/mdns/cast_media_sink_service.h
M chrome/browser/metrics/chromeos_metrics_provider.h
M chrome/browser/metrics/chromeos_system_profile_provider.h
M chrome/browser/metrics/usertype_by_devicetype_metrics_provider.h
M chrome/browser/notifications/mac/notification_platform_bridge_mac.h
M chrome/browser/notifications/notification_common.h
M chrome/browser/performance_manager/public/dll_pre_read_policy_win.h
M chrome/browser/profiles/profile_attributes_entry.h
M chrome/browser/safe_browsing/cloud_content_scanning/file_analysis_request.h
M chrome/browser/signin/account_consistency_mode_manager.h
M chrome/browser/signin/dice_web_signin_interceptor.h
M chrome/browser/signin/web_signin_interceptor.h
M chrome/browser/site_isolation/chrome_site_per_process_test.h
M chrome/browser/translate/chrome_translate_client.h
M chrome/browser/ui/blocked_content/tab_under_navigation_throttle.h
M chrome/browser/ui/browser_window.h
M chrome/browser/ui/profiles/profile_picker.h
M chrome/browser/ui/tabs/tab_group_home/constants.h
M chrome/browser/ui/views/frame/layout/browser_view_layout_delegate_impl.h
M chrome/browser/ui/views/location_bar/intent_chip_button_test_base.h
M chrome/browser/ui/webui/user_education_internals/user_education_internals_page_handler_impl.h
M chrome/browser/unexpire_flags.cc
M chrome/browser/unexpire_flags.h
M chrome/browser/v8_compile_hints/v8_compile_hints_tab_helper.h
M chrome/browser/web_applications/isolated_web_apps/window_management/isolated_web_apps_opened_tabs_counter_service_factory.h
M chrome/test/base/scoped_metrics_service_for_synthetic_trials.h
M chrome/test/base/test_browser_window.h
M components/autofill/content/renderer/autofill_agent.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address.h
M components/autofill/core/browser/geo/autofill_country.h
M components/blocklist/opt_out_blocklist/sql/opt_out_store_sql.h
M components/bookmarks/browser/titled_url_index.h
M components/browser_sync/sync_to_signin_migration.h
M components/commerce/core/commerce_utils.h
M components/commerce/core/shopping_service.h
M components/content_capture/common/content_capture_features.h
M components/content_settings/core/browser/cookie_settings.h
M components/embedder_support/android/util/cdn_utils.h
M components/enterprise/connectors/core/reporting_service_settings.h
M components/error_page/common/alt_game_image_data.h
M components/favicon/core/favicon_database.h
M components/history/core/browser/history_service.h
M components/metrics/metrics_upload_scheduler.h
M components/omnibox/browser/document_provider.h
M components/page_load_metrics/browser/observers/back_forward_cache_page_load_metrics_observer.h
M components/page_load_metrics/browser/observers/click_input_tracker.h
M components/performance_manager/embedder/graph_features.h
M components/reporting/compression/decompression.h
M components/safe_browsing/content/browser/safe_browsing_navigation_observer_manager.h
M components/safe_browsing/content/renderer/phishing_classifier/features.h
M components/safe_browsing/content/renderer/threat_dom_details.h
M components/safe_browsing/core/browser/password_protection/password_protection_service_base.h
M components/safe_browsing/core/common/safe_browsing_prefs.h
M components/security_state/core/security_state.h
M components/segmentation_platform/embedder/default_model/android_home_module_ranker.h
M components/segmentation_platform/embedder/default_model/compose_promotion.h
M components/segmentation_platform/embedder/default_model/ios_default_browser_promo.h
M components/segmentation_platform/embedder/default_model/ios_module_ranker.h
M components/segmentation_platform/embedder/default_model/metrics_clustering.h
M components/segmentation_platform/embedder/default_model/tips_notifications_ranker.h
M components/segmentation_platform/embedder/home_modules/ephemeral_home_module_backend.h
M components/services/heap_profiling/public/cpp/settings.h
M components/services/storage/service_worker/service_worker_storage.h
M components/signin/ios/browser/features.h
M components/signin/public/base/persistent_repeating_timer.h
M components/subresource_filter/content/browser/safe_browsing_page_activation_throttle.h
M components/supervised_user/core/browser/child_account_service.h
M components/tracing/common/background_tracing_utils.h
M components/translate/content/android/translate_message.h
M components/translate/core/browser/translate_manager.h
M components/translate/core/language_detection/language_detection_model.h
M components/ukm/observers/ukm_consent_state_observer.h
M components/user_education/common/ntp_promo/ntp_promo_controller.h
M components/viz/common/switches.h
M components/viz/service/frame_sinks/external_begin_frame_source_mac.cc
M components/viz/service/frame_sinks/external_begin_frame_source_mac.h
M components/viz/service/surfaces/surface_manager.h
M components/webauthn/core/browser/passkey_sync_bridge.h
M components/webrtc/thread_wrapper.h
M content/browser/background_sync/background_sync_op_scheduler.h
M content/browser/browsing_instance.h
M content/browser/browsing_topics/browsing_topics_site_data_storage.h
M content/browser/first_party_sets/database/first_party_sets_database.h
M content/browser/indexed_db/instance/bucket_context.h
M content/browser/indexed_db/instance/leveldb/tombstone_sweeper.h
M content/browser/interest_group/interest_group_auction.h
M content/browser/interest_group/interest_group_auction_reporter.h
M content/browser/preloading/preloading_config.h
M content/browser/renderer_host/page_lifecycle_state_manager.h
M content/common/content_navigation_policy.h
M content/public/test/back_forward_cache_util.h
M content/renderer/discardable_memory_utils.h
M crypto/process_bound_string.h
M device/fido/mac/credential_metadata.h
M extensions/browser/api/declarative_net_request/constants.h
M extensions/browser/api/web_request/web_request_api.h
M google_apis/api_key_cache.h
M ios/chrome/browser/content_suggestions/ui_bundled/default_browser/public/features.h
M ios/chrome/browser/crash_report/model/crash_helper.h
M ios/chrome/browser/feature_engagement/model/ios_tracker_session_controller.h
M ios/chrome/browser/page_info/ui_bundled/features.h
M ios/chrome/browser/popup_menu/ui_bundled/overflow_menu/feature_flags.h
M ios/chrome/browser/profile/model/profile_manager_ios_impl.h
M ios/chrome/browser/shared/public/commands/contextual_panel_entrypoint_iph_commands.h
M ios/chrome/browser/tabs/model/inactive_tabs/features.h
M ios/chrome/browser/text_selection/model/text_selection_util.h
M ios/chrome/browser/whats_new/coordinator/whats_new_util.h
M media/capture/video/apple/sample_buffer_transformer.h
M media/capture/video/apple/video_capture_device_avfoundation_utils.h
M media/cdm/cdm_wrapper.h
M media/gpu/android/ndk_video_encode_accelerator.h
M net/cert/cert_verify_proc.h
M net/http/transport_security_state.h
M net/nqe/network_quality_estimator.h
M services/network/network_service.h
M services/network/resource_scheduler/resource_scheduler.h
M services/video_capture/video_capture_service_impl.h
M storage/browser/blob/blob_memory_controller.h
M third_party/blink/renderer/core/frame/ad_tracker.h
M third_party/blink/renderer/core/lcp_critical_path_predictor/lcp_script_observer.h
M third_party/blink/renderer/modules/ai/ai_writing_assistance_create_client.h
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_2d_recorder_context.h
M third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.h
M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.h
M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.h
M third_party/blink/renderer/modules/webcodecs/reclaimable_codec.h
M third_party/blink/renderer/modules/webcodecs/video_frame.h
M third_party/blink/renderer/platform/bindings/parkable_string_manager.h
M third_party/blink/renderer/platform/graphics/parkable_image_manager.h
M third_party/blink/renderer/platform/loader/fetch/resource_loader.h
M third_party/blink/renderer/platform/peerconnection/rtc_stats.h
M third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.h
M third_party/blink/renderer/platform/peerconnection/webrtc_video_track_source.h
M third_party/blink/renderer/platform/video_capture/video_capture_impl.h
M third_party/blink/renderer/platform/webrtc/webrtc_video_frame_adapter.h
M third_party/blink/renderer/platform/widget/input/main_thread_event_queue.h
M ui/android/resources/etc1_utils.h
M ui/android/resources/ui_resource_provider.h
M ui/compositor/compositor_switches.h
M ui/display/display_switches.h
M ui/events/ozone/evdev/touch_filter/palm_detection_filter_factory.h
M ui/gfx/color_transform.h

Change size: M

Delta: 160 files changed, 17 insertions(+), 173 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages