[Wayland] Request XDG activation on window show [chromium/src : main]
Thomas Anderson (Gerrit)
Thomas Anderson added 1 comment![]( "Open in Gerrit")
I believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
Related details
- Kai Uwe Broulik
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Uwe Broulik (Gerrit)
Kai Uwe Broulik added 1 comment![]( "Open in Gerrit")
I believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
At KDE we want to move away from unconditionally activating windows to allow for proper focus stealing prevention. I am pretty sure Gnome’s Mutter also has strict(er) activation policies nowadays.
We have rolled out a similar change to Qt to make it consistent with its other platforms and haven’t noticed any issue with it. If the window was activated automatically by the compositor, this new code will effectively no-op, so it does no harm.
Unfortunately, the whole activation scheme was somewhat underspecified, it wasn’t clear whether activation should be done on show, and it cannot really be changed now but we can at least improve client behavior where we see it.
Related details
- Thomas Anderson
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Kai Uwe BroulikI believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
At KDE we want to move away from unconditionally activating windows to allow for proper focus stealing prevention. I am pretty sure Gnome’s Mutter also has strict(er) activation policies nowadays.
We have rolled out a similar change to Qt to make it consistent with its other platforms and haven’t noticed any issue with it. If the window was activated automatically by the compositor, this new code will effectively no-op, so it does no harm.
Unfortunately, the whole activation scheme was somewhat underspecified, it wasn’t clear whether activation should be done on show, and it cannot really be changed now but we can at least improve client behavior where we see it.
- Kai Uwe Broulik
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Zahorodnii (Gerrit)
Vlad Zahorodnii added 1 comment![]( "Open in Gerrit")
Kai Uwe BroulikI believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
Thomas AndersonAt KDE we want to move away from unconditionally activating windows to allow for proper focus stealing prevention. I am pretty sure Gnome’s Mutter also has strict(er) activation policies nowadays.
We have rolled out a similar change to Qt to make it consistent with its other platforms and haven’t noticed any issue with it. If the window was activated automatically by the compositor, this new code will effectively no-op, so it does no harm.
Unfortunately, the whole activation scheme was somewhat underspecified, it wasn’t clear whether activation should be done on show, and it cannot really be changed now but we can at least improve client behavior where we see it.
what is the GTK behavior?
I believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
A kwin maintainer here. As Kai said, we want to implement a more stricter window activation policy where the compositor doesn't activate new windows unconditionally. For example, if a user is typing in a password, we don't want some random window popping up and "stealing" the key presses. In order to achieve that, when a window is mapped, the app needs to provide a proof that it maps the window in response to user input so it can be activated. On wayland, it's xdg activation tokens.
In other words, at the compositor side, we want to trace every new mapped window to a particular button press or a key press that triggered it.
As far as I know, both GNOME and KDE are moving in this direction. For example, GNOME people proposed adding activation tokens to the global shortcuts portal, which we also really want.
Related details
- Kai Uwe Broulik
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Uwe Broulik (Gerrit)
Kai Uwe Broulik added 1 comment![]( "Open in Gerrit")
Kai Uwe BroulikI believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
Thomas AndersonAt KDE we want to move away from unconditionally activating windows to allow for proper focus stealing prevention. I am pretty sure Gnome’s Mutter also has strict(er) activation policies nowadays.
We have rolled out a similar change to Qt to make it consistent with its other platforms and haven’t noticed any issue with it. If the window was activated automatically by the compositor, this new code will effectively no-op, so it does no harm.
Unfortunately, the whole activation scheme was somewhat underspecified, it wasn’t clear whether activation should be done on show, and it cannot really be changed now but we can at least improve client behavior where we see it.
what is the GTK behavior?
I believe GTK4 also requests activation on show. When I launch Gnome Text Editor I can see it using xdg_activation right away.
Related details
- Thomas Anderson
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Orko Garai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Orko Garai
| Code-Review | +1 |
1 comment
- Kai Uwe Broulik
- Thomas Anderson
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Kai Uwe BroulikI believe it is compositor policy whether windows should be active when they're created. If this is an issue for you, it should be fixed in the compositor.
Thomas AndersonAt KDE we want to move away from unconditionally activating windows to allow for proper focus stealing prevention. I am pretty sure Gnome’s Mutter also has strict(er) activation policies nowadays.
We have rolled out a similar change to Qt to make it consistent with its other platforms and haven’t noticed any issue with it. If the window was activated automatically by the compositor, this new code will effectively no-op, so it does no harm.
Unfortunately, the whole activation scheme was somewhat underspecified, it wasn’t clear whether activation should be done on show, and it cannot really be changed now but we can at least improve client behavior where we see it.
Kai Uwe Broulikwhat is the GTK behavior?
I believe GTK4 also requests activation on show. When I launch Gnome Text Editor I can see it using xdg_activation right away.
- Kai Uwe Broulik
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nick Yamane (Gerrit)
Nick Yamane voted Code-Review+1![]( "Open in Gerrit")
- Kai Uwe Broulik
- Thomas Anderson
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Uwe Broulik (Gerrit)
Kai Uwe Broulik added 1 comment![]( "Open in Gerrit")
I have now adjusted the existing test to create the window inactive to ensure the explicit activation it tests for works, and I have added a new test for activate on show.
Related details
- Nick Yamane
- Orko Garai
- Thomas Anderson
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
1 comment
For simplicitly, a Wayland compositor typically activates a windowPlease fix this WARNING reported by Spellchecker: "simplicitly" is a possible misspelling of "simplicity" or "implicitly".
To byp...
"simplicitly" is a possible misspelling of "simplicity" or "implicitly".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Related details
- Kai Uwe Broulik
- Nick Yamane
- Orko Garai
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kai Uwe Broulik (Gerrit)
Kai Uwe Broulik added 1 comment![]( "Open in Gerrit")
For simplicitly, a Wayland compositor typically activates a windowPlease fix this WARNING reported by Spellchecker: "simplicitly" is a possible misspelling of "simplicity" or "implicitly".
To byp...
"simplicitly" is a possible misspelling of "simplicity" or "implicitly".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
- Nick Yamane
- Orko Garai
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Orko Garai voted Code-Review+1![]( "Open in Gerrit")
- Kai Uwe Broulik
- Nick Yamane
- Vlad Zahorodnii
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Orko Garai voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[Wayland] Request XDG activation on window show
For simplicity, a Wayland compositor typically activates a window
when it is mapped. However, it does not necessarily have to and
might not want to in order to prevent stealing focus.
Therefore, explicitly request activation when the window is shown
as active. If it is not configured yet, wait for that to happen.
- M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
- M ui/ozone/platform/wayland/host/wayland_toplevel_window.h
- M ui/ozone/platform/wayland/host/xdg_activation_unittest.cc
- M ui/ozone/platform/wayland/test/wayland_test.cc
- M ui/ozone/platform/wayland/test/wayland_test.h
Code-Review: +1 by Thomas Anderson, +1 by Orko Garai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |