Fix unsafe buffer usage in ui/events/ozone/device/udev/device_manager_udev.cc [chromium/src : main]
Zekun Jiang (Gerrit)
Zekun Jiang added 1 comment![]( "Open in Gerrit")
the al patch looks good so sending as is
Related details
- Harry Cutts
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harry Cutts (Gerrit)
Harry Cutts added 1 comment![]( "Open in Gerrit")
if (std::string_view(subsystem) == "input" &&Could we rename `subsystem` to `subsystem_cstr` and then add a `std::string_view` variable, like we do for `path`, rather than constructing a new `string_view` for each branch of the `if`? (Similarly for `action`.)
Alternatively, have you considered doing a bigger refactor to make `device::udev_device_get_property_value` return a nice C++ string type (e.g. `std::optional<std::string_view>`)?
Related details
- Arthur Sonzogni
- Zekun Jiang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zekun Jiang (Gerrit)
Zekun Jiang added 1 comment![]( "Open in Gerrit")
if (std::string_view(subsystem) == "input" &&Could we rename `subsystem` to `subsystem_cstr` and then add a `std::string_view` variable, like we do for `path`, rather than constructing a new `string_view` for each branch of the `if`? (Similarly for `action`.)
Alternatively, have you considered doing a bigger refactor to make `device::udev_device_get_property_value` return a nice C++ string type (e.g. `std::optional<std::string_view>`)?
Sure thing - I'll look into doing a bigger refactor. going to mark this wip for now
Related details
- Arthur Sonzogni
- Harry Cutts
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zekun Jiang (Gerrit)
Zekun Jiang added 1 comment![]( "Open in Gerrit")
Zekun JiangCould we rename `subsystem` to `subsystem_cstr` and then add a `std::string_view` variable, like we do for `path`, rather than constructing a new `string_view` for each branch of the `if`? (Similarly for `action`.)
Alternatively, have you considered doing a bigger refactor to make `device::udev_device_get_property_value` return a nice C++ string type (e.g. `std::optional<std::string_view>`)?
Sure thing - I'll look into doing a bigger refactor. going to mark this wip for now
- Harry Cutts
- Matt Reynolds
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Reynolds (Gerrit)
Matt Reynolds voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matt Reynolds
| Code-Review | +1 |
1 comment
Related details
- Arthur Sonzogni
- Harry Cutts
- Zekun Jiang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harry Cutts (Gerrit)
Harry Cutts voted and added 1 comment![]( "Open in Gerrit")
Votes added by Harry Cutts
| Code-Review | +1 |
1 comment
if (std::string_view(subsystem) == "input" &&Zekun JiangCould we rename `subsystem` to `subsystem_cstr` and then add a `std::string_view` variable, like we do for `path`, rather than constructing a new `string_view` for each branch of the `if`? (Similarly for `action`.)
Alternatively, have you considered doing a bigger refactor to make `device::udev_device_get_property_value` return a nice C++ string type (e.g. `std::optional<std::string_view>`)?
Zekun JiangSure thing - I'll look into doing a bigger refactor. going to mark this wip for now
Done
- Arthur Sonzogni
- Zekun Jiang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zekun Jiang (Gerrit)
Zekun Jiang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Arthur Sonzogni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Fix unsafe buffer usage in ui/events/ozone/device/udev/device_manager_udev.cc
Switched to functions that return std::string instead of char* in device_manager_udev.cc.
Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
- M device/udev_linux/udev.cc
- M device/udev_linux/udev.h
- M ui/events/ozone/device/udev/device_manager_udev.cc
Code-Review: +1 by Matt Reynolds, +1 by Harry Cutts
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |