ozone/wayland: gbm: use gbm API if drm ioctl fails. [chromium/src : main]

Maksim Sisov (Gerrit)

unread,

Nov 26, 2021, 4:26:22 AM11/26/21

to Michael Spang, ozone-...@chromium.org

Attention is currently required from: Michael Spang.

Maksim Sisov would like Michael Spang to review this change.

ozone/wayland: gbm: use gbm API if drm ioctl fails.

Nouveau driver may fail to return a valid fd from drmPrimeHandleToFD,
which results the browser to crash.

However, when the gbm API is used, the fd is valid and the browser
starts normally. Thus, if the drmPrimeHandleToFD calls fail and
the bo is single planed, use gbm_bo_get_fd directly, which
increases a chance of supporting more machines than before this
patch.

Bug: 1273758
Change-Id: Iab7815ac459e6c35dc84ac288fd4d4765369d6ef
---
M ui/gfx/linux/gbm_wrapper.cc
1 file changed, 42 insertions(+), 4 deletions(-)

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

Nov 26, 2021, 4:26:28 AM11/26/21

to ozone-...@chromium.org, Michael Spang, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Michael Spang.

View Change

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Michael Spang (Gerrit)

unread,

Nov 26, 2021, 3:50:06 PM11/26/21

to Maksim Sisov, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Maksim Sisov.

View Change

1 comment:

Patchset:
- Patch Set #10:
  Can you please investigate why it fails and at least explain in the description?

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

Nov 29, 2021, 5:52:09 AM11/29/21

to ozone-...@chromium.org, Michael Spang, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Michael Spang.

View Change

1 comment:

Patchset:

- Patch Set #10:
  Can you please investigate why it fails and at least explain in the description?

- The error is the following [49022:49022:1129/114923.199405:ERROR:gbm_wrapper.cc(275)] Failed to export buffer to dma_buf: No such file or directory (2) . I've no idea what happens with the drivers as it's not my machine and I don't have a direct access to that.

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

Dec 1, 2021, 6:03:39 AM12/1/21

to ozone-...@chromium.org, Michael Spang, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Michael Spang.

View Change

1 comment:

Patchset:
- Patch Set #10:
  The error is the following [49022:49022:1129/114923.199405:ERROR:gbm_wrapper. […]
  Gentle reminder :)

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Michael Spang (Gerrit)

unread,

Dec 1, 2021, 6:52:14 PM12/1/21

to Maksim Sisov, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Maksim Sisov.

View Change

1 comment:

Patchset:
- Patch Set #10:
  Gentle reminder :)
  It's open source, we should investigate the issue more before fixing it.

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Maksim Sisov (Gerrit)

unread,

May 1, 2023, 2:44:01 AM5/1/23

to ozone-...@chromium.org, Max Ihlenfeldt, Michael Spang, Chromium LUCI CQ, chromium...@chromium.org

Maksim Sisov abandoned this change.

View Change

Abandoned

To view, visit change 3298123. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward