Revert "[X11] Make IsSelectionOwner asynchronous in PlatformClipboard" [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Mar 13, 2026, 4:31:14 PMMar 13
to David Baron, AyeAye, Rubber Stamper, Lei Zhang, Chromium LUCI CQ, Thomas Anderson, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, dcheng+c...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge, Lei Zhang and Thomas Anderson

David Baron voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Lei Zhang
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I75d81ac546c7ae6798fb57eb3c2226709f68f6b1
Gerrit-Change-Number: 7663950
Gerrit-PatchSet: 1
Gerrit-Owner: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Fri, 13 Mar 2026 20:31:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Mar 13, 2026, 4:32:20 PMMar 13
to David Baron, AyeAye, Lei Zhang, Chromium LUCI CQ, Thomas Anderson, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, dcheng+c...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge, Lei Zhang and Thomas Anderson

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Lei Zhang
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75d81ac546c7ae6798fb57eb3c2226709f68f6b1
    Gerrit-Change-Number: 7663950
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 20:32:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 13, 2026, 4:32:48 PMMar 13
    to David Baron, Rubber Stamper, AyeAye, Lei Zhang, Thomas Anderson, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, dcheng+c...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[X11] Make IsSelectionOwner asynchronous in PlatformClipboard"

    This reverts commit 8dc861921d9d2891e2e2c58f9f9404a59416d2aa.

    Reason for revert: likely cause of consistent failure of
    OmniboxViewTest.Paste on linux64-rel-ready starting from
    https://ci.chromium.org/ui/b/8687423217582013825

    The first (of multiple) failures in that test was:

    ../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1374: Failure
    Expected equality of these values:
      kSearchText
        Which is: u"abc"
      omnibox_view->GetText()
        Which is: u"about:blank"

    Original change's description:
    > [X11] Make IsSelectionOwner asynchronous in PlatformClipboard
    >
    > This change refactors the IsSelectionOwner method in the
    > PlatformClipboard interface and its implementations to be asynchronous.
    > This allows the X11 backend to eliminate a synchronous X11 Sync() call
    > in GetSelectionOwner, furthering the goal of an entirely asynchronous
    > clipboard architecture.
    >
    > R=thestig
    >
    > Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
    > Bug: 40398800
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7659748
    > Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    > Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
    > Reviewed-by: Kramer Ge <fang...@chromium.org>
    > Reviewed-by: Lei Zhang <the...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1599158}
    Bug: 40398800, 492462319
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 40398800
    Change-Id: I75d81ac546c7ae6798fb57eb3c2226709f68f6b1
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Owners-Override: David Baron <dba...@chromium.org>
    Auto-Submit: David Baron <dba...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1599287}
    Files:
    • M ui/base/clipboard/clipboard_ozone.cc
    • M ui/base/x/x11_clipboard_helper.cc
    • M ui/base/x/x11_clipboard_helper.h
    • M ui/ozone/platform/wayland/host/wayland_clipboard.cc
    • M ui/ozone/platform/wayland/host/wayland_clipboard.h
    • M ui/ozone/platform/wayland/host/wayland_clipboard_unittest.cc
    • M ui/ozone/platform/x11/x11_clipboard_ozone.cc
    • M ui/ozone/platform/x11/x11_clipboard_ozone.h
    • M ui/ozone/public/platform_clipboard.h
    Change size: M
    Delta: 9 files changed, 48 insertions(+), 143 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I75d81ac546c7ae6798fb57eb3c2226709f68f6b1
    Gerrit-Change-Number: 7663950
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages