[headless] Add DevTools Emulation.setPrimaryScreen() support on Linux [chromium/src : main]
0 views
Skip to first unread message
Peter Kvitek (Gerrit)
Mar 3, 2026, 2:35:28 PM (10 days ago) Mar 3
to Peter McNeeley, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov and Peter McNeeley
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrey Kosyakov
- Peter McNeeley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Mar 3, 2026, 2:36:12 PM (10 days ago) Mar 3
to Peter Kvitek, Kramer Ge, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov, Kramer Ge and Peter Kvitek
Peter McNeeley voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Kramer Ge
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Mar 3, 2026, 3:07:57 PM (10 days ago) Mar 3
to Peter Kvitek, Peter McNeeley, Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov and Peter Kvitek
Kramer Ge voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrey Kosyakov
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Mar 3, 2026, 4:05:29 PM (10 days ago) Mar 3
to Peter Kvitek, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Attention needed from Peter Kvitek
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Mar 3, 2026, 4:06:34 PM (10 days ago) Mar 3
to Andrey Kosyakov, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Peter Kvitek voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 3, 2026, 4:09:37 PM (10 days ago) Mar 3
to Peter Kvitek, Andrey Kosyakov, Kramer Ge, Peter McNeeley, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[headless] Add DevTools Emulation.setPrimaryScreen() support on Linux
https://crrev.com/c/7617849 introduced Chrome DevTools method Emulation.setPrimaryScreen() support in Chrome Headless Shell. This CL adds support for this method in Chrome Headless Mode on Linux.
Bug: 397350115
Change-Id: I1786423f669bb957f2dd21cff0a2868262c6ffd3
Reviewed-by: Peter McNeeley <peterm...@google.com>
Commit-Queue: Peter Kvitek <kvi...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1593459}
Files:
- M chrome/browser/devtools/inspector_protocol_config.json
- M chrome/browser/devtools/protocol/emulation_handler.cc
- M chrome/browser/devtools/protocol/emulation_handler.h
- M chrome/browser/headless/headless_mode_protocol_browsertest.cc
- M ui/ozone/platform/headless/headless_screen.cc
Change size: S
Delta: 5 files changed, 31 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov, +1 by Peter McNeeley, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages