[//ui] Internalize BufferUsageAndFormat to GBMSupportX11 [chromium/src : main]

0 views
Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,
Dec 9, 2025, 9:24:43 AM (13 days ago) Dec 9
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

File ui/gfx/buffer_types.h
Line 79, Patchset 1 (Latest):enum class BufferPlane {
Vasiliy Telezhnikov . resolved

We probably should move this to ui/ozone/common at some point, I think [this](https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/common/gl_ozone_egl.cc;drc=8bd3d24cc3bdbffe564eeeca112a6744e6766b17;l=69) and the corresponding code in SI is the only usage of this.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3410b45954669df76cfa5f233ff9d7b695b40792
Gerrit-Change-Number: 7241407
Gerrit-PatchSet: 1
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 10, 2025, 3:00:16 AM (12 days ago) Dec 10
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[//ui] Internalize BufferUsageAndFormat to GBMSupportX11

This is now the only consumer of this struct.
Bug: 356649879
Change-Id: I3410b45954669df76cfa5f233ff9d7b695b40792
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1556569}
Files:
  • M ui/gfx/buffer_types.h
  • M ui/gfx/linux/gbm_support_x11.cc
  • M ui/gfx/linux/gbm_support_x11.h
Change size: S
Delta: 3 files changed, 23 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3410b45954669df76cfa5f233ff9d7b695b40792
Gerrit-Change-Number: 7241407
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement

Colin Blundell (Gerrit)

unread,
Dec 10, 2025, 4:49:38 AM (12 days ago) Dec 10
to Chromium LUCI CQ, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org

Colin Blundell added 1 comment

File ui/gfx/buffer_types.h
Line 79, Patchset 1:enum class BufferPlane {
Vasiliy Telezhnikov . resolved

We probably should move this to ui/ozone/common at some point, I think [this](https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/common/gl_ozone_egl.cc;drc=8bd3d24cc3bdbffe564eeeca112a6744e6766b17;l=69) and the corresponding code in SI is the only usage of this.

Colin Blundell

Noted for followup work, thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3410b45954669df76cfa5f233ff9d7b695b40792
Gerrit-Change-Number: 7241407
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Dec 2025 09:49:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vasiliy Telezhnikov <vas...@chromium.org>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages