Avi Drissman (Gerrit)

unread,

Jan 6, 2026, 10:47:05 AM (5 days ago) Jan 6

to Victor Vianna, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org

Attention needed from Victor Vianna

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review

+1

1 comment

File ui/accessibility/ax_tree_manager_map.cc

Line 6, Patchset 3 (Latest):

Avi Drissman . unresolved

remove extra line

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 6, 2026, 11:12:41 AM (5 days ago) Jan 6

to Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org

Victor Vianna added 1 comment

File ui/accessibility/ax_tree_manager_map.cc

Line 6, Patchset 3:

Avi Drissman . resolved

remove extra line

Victor Vianna

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 6, 2026, 11:13:39 AM (5 days ago) Jan 6

to Avi Drissman, Chromium LUCI CQ, Akihiro Ota, chromium...@chromium.org, Henrique Ferreiro, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, mac-r...@chromium.org, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org

Victor Vianna submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/accessibility/ax_tree_manager_map.cc
Insertions: 0, Deletions: 1.

@@ -4,7 +4,6 @@
 
 #include "ui/accessibility/ax_tree_manager_map.h"
 
-
 namespace ui {
 
 AXTreeManagerMap::AXTreeManagerMap() = default;
```

Change information

Commit message:

Migrate various base::Contains() to contains() in ui

Bug: 470391351

Change-Id: I012ce8362ede6478fd785893abb18c17bdc1baaa

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7362759

Reviewed-by: Avi Drissman <a...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1564994}

Files:

M ui/accessibility/ax_node_data_unittest.cc
M ui/accessibility/ax_tree.cc
M ui/accessibility/ax_tree_manager_map.cc
M ui/accessibility/platform/automation/automation_ax_tree_wrapper.cc
M ui/accessibility/platform/ax_unique_id.cc
M ui/accessibility/platform/one_shot_accessibility_tree_search.cc
M ui/aura/host_frame_rate_throttler.cc
M ui/aura/scoped_simple_keyboard_hook.cc
M ui/aura/window_occlusion_tracker.cc
M ui/aura/window_tree_host.cc
M ui/base/accelerators/global_accelerator_listener/global_accelerator_listener_ozone.cc
M ui/base/clipboard/clipboard_non_backed.cc
M ui/base/clipboard/test/test_clipboard.cc
M ui/base/dragdrop/os_exchange_data_provider_non_backed.cc
M ui/base/interaction/element_identifier.cc
M ui/base/interaction/element_tracker.cc
M ui/base/interaction/interaction_sequence_unittest.cc
M ui/base/interaction/interactive_test_internal.cc
M ui/base/models/list_selection_model.cc
M ui/base/resource/data_pack.cc
M ui/base/x/x11_global_shortcut_listener.cc
M ui/color/color_provider_utils.cc
M ui/compositor/compositor.cc
M ui/display/display.cc
M ui/display/manager/content_protection_key_manager.cc
M ui/display/manager/touch_device_manager.cc
M ui/display/util/display_util.cc
M ui/events/gestures/gesture_recognizer_impl.cc
M ui/events/keyboard_hook_base.cc
M ui/events/ozone/chromeos/cursor_controller.cc
M ui/gfx/x/window_cache.cc
M ui/gl/gl_display.cc
M ui/gl/gl_gl_api_implementation.cc
M ui/gtk/gtk_ui.cc
M ui/gtk/os_settings_provider_gtk.cc
M ui/message_center/popup_timers_controller.cc
M ui/ozone/common/base_keyboard_hook.cc
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
M ui/ozone/platform/wayland/gpu/wayland_canvas_surface.cc
M ui/ozone/platform/wayland/host/wayland_screen.cc
M ui/ozone/platform/wayland/host/wayland_serial_tracker.cc
M ui/ozone/platform/wayland/test/wayland_ozone_ui_controls_test_helper.cc
M ui/ozone/platform/x11/x11_window_manager.cc
M ui/wm/core/cursor_util.cc

Change size: M

Delta: 44 files changed, 84 insertions(+), 134 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Victor Vianna (Gerrit)

unread,

Jan 7, 2026, 11:58:12 AM (4 days ago) Jan 7

to ccameron chromium, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, ozone-...@chromium.org, yuzo+...@chromium.org

Attention needed from ccameron chromium

Victor Vianna added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Victor Vianna . resolved

Gentle ping for ccameron@, thanks

Open in Gerrit

Related details

Attention is currently required from:

ccameron chromium

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

ccameron chromium (Gerrit)

unread,

Jan 8, 2026, 11:06:20 AM (3 days ago) Jan 8

to Victor Vianna, ccameron chromium, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, ozone-...@chromium.org, yuzo+...@chromium.org

Attention needed from Victor Vianna

ccameron chromium voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

Jan 8, 2026, 11:07:32 AM (3 days ago) Jan 8

to ccameron chromium, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Chromium LUCI CQ, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, ozone-...@chromium.org, yuzo+...@chromium.org

Victor Vianna voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 8, 2026, 12:17:40 PM (3 days ago) Jan 8

to Victor Vianna, ccameron chromium, AyeAye, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dcheng+c...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, ozone-...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Migrate various base::Contains() to contains() in ui

None of these files removes the base/containers/contains.h include
because they still use it.

Bug: 470391351

Change-Id: Ida29acad46cc3680355a7be6ad297ae4fbfb4229

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7367760

Commit-Queue: Victor Vianna <victor...@google.com>

Reviewed-by: ccameron chromium <ccam...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1566358}

Files:

M ui/accessibility/ax_event_generator.cc
M ui/accessibility/ax_tree_unittest.cc
M ui/base/clipboard/clipboard.cc
M ui/events/ash/keyboard_capability.cc
M ui/ozone/platform/drm/gpu/fake_drm_device.cc

Change size: S

Delta: 5 files changed, 22 insertions(+), 23 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by ccameron chromium

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Migrate various base::Contains() to contains() in ui [chromium/src : main]

Avi Drissman (Gerrit)

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

Victor Vianna (Gerrit)

Victor Vianna submitted the change with unreviewed changes

Unreviewed changes

Change information

Victor Vianna (Gerrit)

Victor Vianna added 1 comment

Related details

ccameron chromium (Gerrit)

ccameron chromium voted Code-Review+1

Related details

Victor Vianna (Gerrit)

Victor Vianna voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information